Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56687,
    "url": "http://patches.dpdk.org/api/patches/56687/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-20-ajit.khaparde@broadcom.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190718033616.37605-20-ajit.khaparde@broadcom.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-20-ajit.khaparde@broadcom.com",
    "date": "2019-07-18T03:36:13",
    "name": "[19/22] net/bnxt: avoid overrun in get statistics",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "7851f4068663ce9f6236c3e4921bb288466737ee",
    "submitter": {
        "id": 501,
        "url": "http://patches.dpdk.org/api/people/501/?format=api",
        "name": "Ajit Khaparde",
        "email": "ajit.khaparde@broadcom.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-20-ajit.khaparde@broadcom.com/mbox/",
    "series": [
        {
            "id": 5581,
            "url": "http://patches.dpdk.org/api/series/5581/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5581",
            "date": "2019-07-18T03:35:54",
            "name": "bnxt patchset",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/5581/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/56687/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/56687/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AC87E1BE01;\n\tThu, 18 Jul 2019 05:37:33 +0200 (CEST)",
            "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id C2D171BDF2;\n\tThu, 18 Jul 2019 05:37:05 +0200 (CEST)",
            "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 6029D30C38E;\n\tWed, 17 Jul 2019 20:37:03 -0700 (PDT)",
            "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id CC0B2AC0761;\n\tWed, 17 Jul 2019 20:37:02 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 6029D30C38E",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563421023;\n\tbh=JWmL64i9alkPXCYUH6wYtRlJUwZ1ZVcuQqnpgBhvvaI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nYUiYQArNfKqoD1FIo2EAdQ9fHmPowlv5pidY2wK3YC76Di3OaYgzuJarZszPawER\n\t41JC2mNXwIUHaAqVReRFhjS8is7T4h4dIqDKDbL/OHyfx0lr/WOYrUoY+k27ckmfov\n\t1U8aukc9c1/eSE0V/u47dHvQEWaqu4p31nSWYNlw=",
        "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>,\n\tstable@dpdk.org,\n\tKalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>",
        "Date": "Thu, 18 Jul 2019 09:06:13 +0530",
        "Message-Id": "<20190718033616.37605-20-ajit.khaparde@broadcom.com>",
        "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)",
        "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>",
        "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 19/22] net/bnxt: avoid overrun in get statistics",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nAvoid overrun in rte_eth_stats struct when the number of tx/rx\nrings in use is greater than RTE_ETHDEV_QUEUE_STAT_CNTRS.\n\nFixes: 57d5e5bc86e4 (\"net/bnxt: add statistics\")\nCc: stable@dpdk.org\nReviewed-by: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\n---\n drivers/net/bnxt/bnxt_stats.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c\nindex 3cd5144ec..4e74f8a27 100644\n--- a/drivers/net/bnxt/bnxt_stats.c\n+++ b/drivers/net/bnxt/bnxt_stats.c\n@@ -351,6 +351,7 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n \tint rc = 0;\n \tunsigned int i;\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n+\tunsigned int num_q_stats;\n \n \tmemset(bnxt_stats, 0, sizeof(*bnxt_stats));\n \tif (!(bp->flags & BNXT_FLAG_INIT_DONE)) {\n@@ -358,7 +359,10 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n \t\treturn -1;\n \t}\n \n-\tfor (i = 0; i < bp->rx_cp_nr_rings; i++) {\n+\tnum_q_stats = RTE_MIN(bp->rx_cp_nr_rings,\n+\t\t\t      (unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\n+\tfor (i = 0; i < num_q_stats; i++) {\n \t\tstruct bnxt_rx_queue *rxq = bp->rx_queues[i];\n \t\tstruct bnxt_cp_ring_info *cpr = rxq->cp_ring;\n \n@@ -370,7 +374,10 @@ int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,\n \t\t\t\trte_atomic64_read(&rxq->rx_mbuf_alloc_fail);\n \t}\n \n-\tfor (i = 0; i < bp->tx_cp_nr_rings; i++) {\n+\tnum_q_stats = RTE_MIN(bp->tx_cp_nr_rings,\n+\t\t\t      (unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\n+\tfor (i = 0; i < num_q_stats; i++) {\n \t\tstruct bnxt_tx_queue *txq = bp->tx_queues[i];\n \t\tstruct bnxt_cp_ring_info *cpr = txq->cp_ring;\n \n",
    "prefixes": [
        "19/22"
    ]
}