Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56683/?format=api
{ "id": 56683, "url": "http://patches.dpdk.org/api/patches/56683/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-16-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718033616.37605-16-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-16-ajit.khaparde@broadcom.com", "date": "2019-07-18T03:36:09", "name": "[15/22] net/bnxt: use correct RSS table sizes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c1149d978aeca238d201d5f4fd134311d205aa64", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-16-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5581, "url": "http://patches.dpdk.org/api/series/5581/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5581", "date": "2019-07-18T03:35:54", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/5581/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56683/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56683/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E42D51BDFC;\n\tThu, 18 Jul 2019 05:37:11 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id A63B01B957\n\tfor <dev@dpdk.org>; Thu, 18 Jul 2019 05:36:57 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 4D78930C390;\n\tWed, 17 Jul 2019 20:36:55 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id EF774AC0761;\n\tWed, 17 Jul 2019 20:36:54 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 4D78930C390", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563421015;\n\tbh=RYO15Y4aIMM4+gpzItMfYqweJfwzoMd8UKHS82iZ/OY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W8lL/NuAPJf88yfHcmbJ3grYzxuLv3L5ob8uCnpD0kwZGHlsRN4WyV84hhoz/ce0K\n\tTIFWM9eq79yDcrJyfOnoNG/dSnGSBw7FxhlyJ/i3HBUP/BJ/J18vB1IjJkKjD3ggmJ\n\tNlnu2DJMaMCzb+aJ6yPz1gOyk+WqSKO5i5Fa3Jbg=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>,\n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 18 Jul 2019 09:06:09 +0530", "Message-Id": "<20190718033616.37605-16-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 15/22] net/bnxt: use correct RSS table sizes", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nRSS table size is variable with BCM57500-based adapters. Use correct\nsize when allocating memory for RSS state.\n\nFixes: 05375e6f58df (\"net/bnxt: enable rss for thor-based adapters\")\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\n---\n drivers/net/bnxt/bnxt_vnic.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex c652b8f03..98415633e 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -117,6 +117,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp)\n \tconst struct rte_memzone *mz;\n \tchar mz_name[RTE_MEMZONE_NAMESIZE];\n \tuint32_t entry_length;\n+\tsize_t rss_table_size;\n \tuint16_t max_vnics;\n \tint i;\n \trte_iova_t mz_phys_addr;\n@@ -125,11 +126,12 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp)\n \t\t BNXT_MAX_MC_ADDRS * RTE_ETHER_ADDR_LEN;\n \n \tif (BNXT_CHIP_THOR(bp))\n-\t\tentry_length += BNXT_RSS_TBL_SIZE_THOR *\n-\t\t\t\t2 * sizeof(*vnic->rss_table);\n+\t\trss_table_size = BNXT_RSS_TBL_SIZE_THOR *\n+\t\t\t\t 2 * sizeof(*vnic->rss_table);\n \telse\n-\t\tentry_length += HW_HASH_INDEX_SIZE * sizeof(*vnic->rss_table);\n-\tentry_length = RTE_CACHE_LINE_ROUNDUP(entry_length);\n+\t\trss_table_size = HW_HASH_INDEX_SIZE * sizeof(*vnic->rss_table);\n+\n+\tentry_length = RTE_CACHE_LINE_ROUNDUP(entry_length + rss_table_size);\n \n \tmax_vnics = bp->max_vnics;\n \tsnprintf(mz_name, RTE_MEMZONE_NAMESIZE,\n@@ -170,10 +172,10 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp)\n \n \t\tvnic->rss_table_dma_addr = mz_phys_addr + (entry_length * i);\n \t\tvnic->rss_hash_key = (void *)((char *)vnic->rss_table +\n-\t\t\t HW_HASH_INDEX_SIZE * sizeof(*vnic->rss_table));\n+\t\t\t\t\t rss_table_size);\n \n \t\tvnic->rss_hash_key_dma_addr = vnic->rss_table_dma_addr +\n-\t\t\t HW_HASH_INDEX_SIZE * sizeof(*vnic->rss_table);\n+\t\t\t\t\t rss_table_size;\n \t\tvnic->mc_list = (void *)((char *)vnic->rss_hash_key +\n \t\t\t\tHW_HASH_KEY_SIZE);\n \t\tvnic->mc_list_dma_addr = vnic->rss_hash_key_dma_addr +\n", "prefixes": [ "15/22" ] }