Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56679/?format=api
{ "id": 56679, "url": "http://patches.dpdk.org/api/patches/56679/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-12-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718033616.37605-12-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-12-ajit.khaparde@broadcom.com", "date": "2019-07-18T03:36:05", "name": "[11/22] net/bnxt: fix error checking of FW commands", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "262b6076b49cedd05b7eea8021aa3922c7c8f18c", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-12-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5581, "url": "http://patches.dpdk.org/api/series/5581/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5581", "date": "2019-07-18T03:35:54", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/5581/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56679/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56679/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9D4E71BDE5;\n\tThu, 18 Jul 2019 05:36:57 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id DC6A21B9F6;\n\tThu, 18 Jul 2019 05:36:48 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 7D00C30C38E;\n\tWed, 17 Jul 2019 20:36:46 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id D706EAC0761;\n\tWed, 17 Jul 2019 20:36:45 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 7D00C30C38E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563421006;\n\tbh=snw9PKvTH+gILZG8R3iYj6H/iQOEdiSu8gB1UFdQxes=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XWGsorC306NJ4Fsih9HPn1m2u/rKEwAevRHMxmmtoEWnFLGsWgF/tbn5cWsZOZicq\n\tf3rzMgs4paF7RHODeSIkYtOLvXkYDxIcuvq2VwGY49vB50JV9EkDsBiBpdFLMBDKNG\n\t7IF1xqCPZzMCidJ1wyiIzjXDwUCar+NZcnZggiNA=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tstable@dpdk.org, Lance Richardson <lance.richardson@broadcom.com>", "Date": "Thu, 18 Jul 2019 09:06:05 +0530", "Message-Id": "<20190718033616.37605-12-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 11/22] net/bnxt: fix error checking of FW commands", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nHWRM_CHECK_RESULT() checks the return value of HWRM command and returns\nin case the command fails. There is no need of return value check after\nHWRM_CHECK_RESULT().\n\nFixes: 49947a13ba9e (\"net/bnxt: support Tx loopback, set VF MAC and queues drop\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 23 +++--------------------\n 1 file changed, 3 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex 52b2119a5..9bd2fcb9f 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1766,8 +1766,6 @@ bnxt_hwrm_vnic_rss_cfg_thor(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \t\t\t\t\t BNXT_USE_CHIMP_MB);\n \n \t\tHWRM_CHECK_RESULT();\n-\t\tif (rc)\n-\t\t\tbreak;\n \t}\n \n \tHWRM_UNLOCK();\n@@ -3778,16 +3776,7 @@ static int bnxt_hwrm_func_vf_vnic_query(struct bnxt *bp, uint16_t vf,\n \t\treturn -ENOMEM;\n \t}\n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n-\tif (rc) {\n-\t\tHWRM_UNLOCK();\n-\t\tPMD_DRV_LOG(ERR, \"hwrm_func_vf_vnic_query failed rc:%d\\n\", rc);\n-\t\treturn -1;\n-\t} else if (resp->error_code) {\n-\t\trc = rte_le_to_cpu_16(resp->error_code);\n-\t\tHWRM_UNLOCK();\n-\t\tPMD_DRV_LOG(ERR, \"hwrm_func_vf_vnic_query error %d\\n\", rc);\n-\t\treturn -1;\n-\t}\n+\tHWRM_CHECK_RESULT();\n \trc = rte_le_to_cpu_32(resp->vnic_id_cnt);\n \n \tHWRM_UNLOCK();\n@@ -4196,8 +4185,6 @@ bnxt_vnic_rss_configure_thor(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \t\t\t\t\t BNXT_USE_CHIMP_MB);\n \n \t\tHWRM_CHECK_RESULT();\n-\t\tif (rc)\n-\t\t\tbreak;\n \t}\n \n \tHWRM_UNLOCK();\n@@ -4275,8 +4262,7 @@ static int bnxt_hwrm_set_coal_params_thor(struct bnxt *bp,\n \n \tHWRM_PREP(req, RING_AGGINT_QCAPS, BNXT_USE_CHIMP_MB);\n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n-\tif (rc)\n-\t\tgoto out;\n+\tHWRM_CHECK_RESULT();\n \n \tagg_req->num_cmpl_dma_aggr = resp->num_cmpl_dma_aggr_max;\n \tagg_req->cmpl_aggr_dma_tmr = resp->cmpl_aggr_dma_tmr_min;\n@@ -4289,8 +4275,6 @@ static int bnxt_hwrm_set_coal_params_thor(struct bnxt *bp,\n \t HWRM_RING_CMPL_RING_CFG_AGGINT_PARAMS_INPUT_ENABLES_NUM_CMPL_DMA_AGGR;\n \tagg_req->enables = rte_cpu_to_le_32(enables);\n \n-out:\n-\tHWRM_CHECK_RESULT();\n \tHWRM_UNLOCK();\n \treturn rc;\n }\n@@ -4502,8 +4486,7 @@ int bnxt_hwrm_func_backing_store_cfg(struct bnxt *bp, uint32_t enables)\n \trc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);\n \tHWRM_CHECK_RESULT();\n \tHWRM_UNLOCK();\n-\tif (rc)\n-\t\trc = -EIO;\n+\n \treturn rc;\n }\n \n", "prefixes": [ "11/22" ] }