Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56678/?format=api
http://patches.dpdk.org/api/patches/56678/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-11-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718033616.37605-11-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-11-ajit.khaparde@broadcom.com", "date": "2019-07-18T03:36:04", "name": "[10/22] net/bnxt: retry irq callback deregistration", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ba1c5e31cad0a47efd1a2c2c83edc24362c5f669", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-11-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5581, "url": "http://patches.dpdk.org/api/series/5581/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5581", "date": "2019-07-18T03:35:54", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/5581/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56678/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56678/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7A3C41BD52;\n\tThu, 18 Jul 2019 05:36:53 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 957191B9F1;\n\tThu, 18 Jul 2019 05:36:46 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 4093430C39E;\n\tWed, 17 Jul 2019 20:36:44 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id A25B3AC0761;\n\tWed, 17 Jul 2019 20:36:43 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 4093430C39E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563421004;\n\tbh=MBaAEzLWTQF2Rc9juJ/Tyy9yk1MP4EqjINUiNVzU+xw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=GTfZSyZlvKxIOpEN3rx5Kpy4MqdSBXD8eDx7eCDv6v+7KAgLBylemOJSCudnGLwqt\n\tAMSgNZOz6XImfyqHWCvtwz0GxiOfitbeakal8Iq9XKgsfveG8kPAiv6eqDubMkRA9J\n\t71lMNilRDnKUMlJq+HWt4XrFesK0c2ITnPVYDi/U=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>,\n\tstable@dpdk.org", "Date": "Thu, 18 Jul 2019 09:06:04 +0530", "Message-Id": "<20190718033616.37605-11-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 10/22] net/bnxt: retry irq callback deregistration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nrte_intr_callback_unregister() can fail if the handler happens to\nbe active at the time of the call. Add logic to retry a reasonable\nnumber of times to help ensure that the callback is unregistered\non uninit.\n\nFixes: 7bc8e9a227cc (\"net/bnxt: support async link notification\")\nCc: stable@dpdk.org\n\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\n---\n drivers/net/bnxt/bnxt_irq.c | 63 +++++++++++++++++++++++++++----------\n drivers/net/bnxt/bnxt_irq.h | 2 +-\n 2 files changed, 48 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c\nindex 9ff16ddd8..42a2ff2a3 100644\n--- a/drivers/net/bnxt/bnxt_irq.c\n+++ b/drivers/net/bnxt/bnxt_irq.c\n@@ -51,21 +51,45 @@ static void bnxt_int_handler(void *param)\n \t\tB_CP_DB_REARM(cpr, cpr->cp_raw_cons);\n }\n \n-void bnxt_free_int(struct bnxt *bp)\n+int bnxt_free_int(struct bnxt *bp)\n {\n-\tstruct bnxt_irq *irq;\n-\n-\tirq = bp->irq_tbl;\n-\tif (irq) {\n-\t\tif (irq->requested) {\n-\t\t\trte_intr_callback_unregister(&bp->pdev->intr_handle,\n-\t\t\t\t\t\t irq->handler,\n-\t\t\t\t\t\t (void *)bp->eth_dev);\n-\t\t\tirq->requested = 0;\n+\tstruct rte_intr_handle *intr_handle = &bp->pdev->intr_handle;\n+\tstruct bnxt_irq *irq = bp->irq_tbl;\n+\tint rc = 0;\n+\n+\tif (!irq)\n+\t\treturn 0;\n+\n+\tif (irq->requested) {\n+\t\tint count = 0;\n+\n+\t\t/*\n+\t\t * Callback deregistration will fail with rc -EAGAIN if the\n+\t\t * callback is currently active. Retry every 50 ms until\n+\t\t * successful or 500 ms has elapsed.\n+\t\t */\n+\t\tdo {\n+\t\t\trc = rte_intr_callback_unregister(intr_handle,\n+\t\t\t\t\t\t\t irq->handler,\n+\t\t\t\t\t\t\t bp->eth_dev);\n+\t\t\tif (rc >= 0) {\n+\t\t\t\tirq->requested = 0;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t\trte_delay_ms(50);\n+\t\t} while (count++ < 10);\n+\n+\t\tif (rc < 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"irq cb unregister failed rc: %d\\n\",\n+\t\t\t\t rc);\n+\t\t\treturn rc;\n \t\t}\n-\t\trte_free((void *)bp->irq_tbl);\n-\t\tbp->irq_tbl = NULL;\n \t}\n+\n+\trte_free(bp->irq_tbl);\n+\tbp->irq_tbl = NULL;\n+\n+\treturn 0;\n }\n \n void bnxt_disable_int(struct bnxt *bp)\n@@ -129,13 +153,20 @@ int bnxt_setup_int(struct bnxt *bp)\n \n int bnxt_request_int(struct bnxt *bp)\n {\n+\tstruct rte_intr_handle *intr_handle = &bp->pdev->intr_handle;\n+\tstruct bnxt_irq *irq = bp->irq_tbl;\n \tint rc = 0;\n \n-\tstruct bnxt_irq *irq = bp->irq_tbl;\n+\tif (!irq)\n+\t\treturn 0;\n \n-\trte_intr_callback_register(&bp->pdev->intr_handle, irq->handler,\n-\t\t\t\t (void *)bp->eth_dev);\n+\tif (!irq->requested) {\n+\t\trc = rte_intr_callback_register(intr_handle,\n+\t\t\t\t\t\tirq->handler,\n+\t\t\t\t\t\tbp->eth_dev);\n+\t\tif (!rc)\n+\t\t\tirq->requested = 1;\n+\t}\n \n-\tirq->requested = 1;\n \treturn rc;\n }\ndiff --git a/drivers/net/bnxt/bnxt_irq.h b/drivers/net/bnxt/bnxt_irq.h\nindex 75ba2135b..460a97a09 100644\n--- a/drivers/net/bnxt/bnxt_irq.h\n+++ b/drivers/net/bnxt/bnxt_irq.h\n@@ -17,7 +17,7 @@ struct bnxt_irq {\n };\n \n struct bnxt;\n-void bnxt_free_int(struct bnxt *bp);\n+int bnxt_free_int(struct bnxt *bp);\n void bnxt_disable_int(struct bnxt *bp);\n void bnxt_enable_int(struct bnxt *bp);\n int bnxt_setup_int(struct bnxt *bp);\n", "prefixes": [ "10/22" ] }{ "id": 56678, "url": "