Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56673/?format=api
{ "id": 56673, "url": "http://patches.dpdk.org/api/patches/56673/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718033616.37605-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-6-ajit.khaparde@broadcom.com", "date": "2019-07-18T03:35:59", "name": "[05/22] net/bnxt: fix setting primary MAC address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "25b00141bf84a4397c1238a0ef74013795ffcf71", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5581, "url": "http://patches.dpdk.org/api/series/5581/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5581", "date": "2019-07-18T03:35:54", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/5581/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56673/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56673/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EB5D81B9A0;\n\tThu, 18 Jul 2019 05:36:40 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id EF6971B95C;\n\tThu, 18 Jul 2019 05:36:34 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 7814530C39E;\n\tWed, 17 Jul 2019 20:36:32 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id D0536AC0761;\n\tWed, 17 Jul 2019 20:36:31 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 7814530C39E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563420992;\n\tbh=DA/7E6DqhzCiX5YpENVroQa+hY+ERj5tfEbZA8uq3vk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KUFjz+3196QAQmGL9jtTNAuUGY3E2klWij65mxwI1C6lyeAokYXHN8Syx82fW8OV0\n\t3ZjaX8WEU2Uk3c1201pLO2gTSQgSudred2Nz5wam6RlpCcdKzBEtp+5sV5Z3jp6Db7\n\t4bH+XqBEHaoPC2m0/qtNKQDM9MoCfkCGk+JaXHsY=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tstable@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 18 Jul 2019 09:05:59 +0530", "Message-Id": "<20190718033616.37605-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 05/22] net/bnxt: fix setting primary MAC address", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\n1. Default filter is tied to VNIC 0 at index 0. After finding the filter\n with mac_index 0 and set the new MAC address, looping through\n remaining filters is unnecessary.\n2. Added a check for NULL MAC address.\n3. bnxt_hwrm_set_l2_filter() clears the existing filter configuration\n first before applying new filter settings. Hence there is no need to\n invoke bnxt_hwrm_clear_l2_filter() explicitly in\n bnxt_set_default_mac_addr_op().\n\nFixes: d69851df12b2d (\"net/bnxt: support multicast filter and set MAC addr\")\nCc: stable@dpdk.org\n\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7e0fca31e..455d8a3bf 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1699,26 +1699,28 @@ bnxt_set_default_mac_addr_op(struct rte_eth_dev *dev,\n \tif (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp))\n \t\treturn -EPERM;\n \n-\tmemcpy(bp->mac_addr, addr, sizeof(bp->mac_addr));\n+\tif (rte_is_zero_ether_addr(addr))\n+\t\treturn -EINVAL;\n \n \tSTAILQ_FOREACH(filter, &vnic->filter, next) {\n \t\t/* Default Filter is at Index 0 */\n \t\tif (filter->mac_index != 0)\n \t\t\tcontinue;\n-\t\trc = bnxt_hwrm_clear_l2_filter(bp, filter);\n-\t\tif (rc)\n-\t\t\treturn rc;\n+\n \t\tmemcpy(filter->l2_addr, bp->mac_addr, RTE_ETHER_ADDR_LEN);\n \t\tmemset(filter->l2_addr_mask, 0xff, RTE_ETHER_ADDR_LEN);\n \t\tfilter->flags |= HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_PATH_RX;\n \t\tfilter->enables |=\n \t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR |\n \t\t\tHWRM_CFA_L2_FILTER_ALLOC_INPUT_ENABLES_L2_ADDR_MASK;\n+\n \t\trc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id, filter);\n \t\tif (rc)\n \t\t\treturn rc;\n-\t\tfilter->mac_index = 0;\n+\n+\t\tmemcpy(bp->mac_addr, addr, RTE_ETHER_ADDR_LEN);\n \t\tPMD_DRV_LOG(DEBUG, \"Set MAC addr\\n\");\n+\t\treturn 0;\n \t}\n \n \treturn 0;\n", "prefixes": [ "05/22" ] }