Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56671/?format=api
{ "id": 56671, "url": "http://patches.dpdk.org/api/patches/56671/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-4-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718033616.37605-4-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-4-ajit.khaparde@broadcom.com", "date": "2019-07-18T03:35:57", "name": "[03/22] net/bnxt: fix failure to add a MAC address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "96d9a42e88f23892d58f2d2a0a110be9cf033140", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-4-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5581, "url": "http://patches.dpdk.org/api/series/5581/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5581", "date": "2019-07-18T03:35:54", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/5581/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56671/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56671/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EC3421B953;\n\tThu, 18 Jul 2019 05:36:33 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 2E5DE4CE4;\n\tThu, 18 Jul 2019 05:36:30 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id C2BA230C38E;\n\tWed, 17 Jul 2019 20:36:27 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id CBADFAC0761;\n\tWed, 17 Jul 2019 20:36:26 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com C2BA230C38E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563420987;\n\tbh=/z/xOBZCSSs8Qt7FU+xtinpvUklAvGhiSYfGSzN/cgo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=YLIQTrzhIWouWa+d2VA0IOJn7vdbHnTIImiDQl4IR6PRluO2BGURBJkq/qKWzFzVH\n\tJ9TnmTGK0Rb1MZhOAm5Js44A1E6te9YFMLJjI0WdsP8pYNgxP0kwMD11ymmtOcEOY2\n\tL9lJUiQ/N/HGud9CSdVThs0LTSFUpB9X7vFhWVwA=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tstable@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 18 Jul 2019 09:05:57 +0530", "Message-Id": "<20190718033616.37605-4-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 03/22] net/bnxt: fix failure to add a MAC address", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nHWRM command to add MAC address can fail. Driver should check\nthe return value of HWRM command and do the house keeping properly.\n\nFixes: 778b759ba10e45208 (\"net/bnxt: add MAC address\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex a37ea93d9..0c77a8c08 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -915,6 +915,7 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n \tstruct bnxt_vnic_info *vnic = &bp->vnic_info[pool];\n \tstruct bnxt_filter_info *filter;\n+\tint rc = 0;\n \n \tif (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) {\n \t\tPMD_DRV_LOG(ERR, \"Cannot add MAC address to a VF interface\\n\");\n@@ -938,10 +939,20 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev,\n \t\tPMD_DRV_LOG(ERR, \"L2 filter alloc failed\\n\");\n \t\treturn -ENODEV;\n \t}\n-\tSTAILQ_INSERT_TAIL(&vnic->filter, filter, next);\n+\n \tfilter->mac_index = index;\n \tmemcpy(filter->l2_addr, mac_addr, RTE_ETHER_ADDR_LEN);\n-\treturn bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id, filter);\n+\n+\trc = bnxt_hwrm_set_l2_filter(bp, vnic->fw_vnic_id, filter);\n+\tif (!rc) {\n+\t\tSTAILQ_INSERT_TAIL(&vnic->filter, filter, next);\n+\t} else {\n+\t\tfilter->mac_index = INVALID_MAC_INDEX;\n+\t\tmemset(&filter->l2_addr, 0, RTE_ETHER_ADDR_LEN);\n+\t\tbnxt_free_filter(bp, filter);\n+\t}\n+\n+\treturn rc;\n }\n \n int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)\n", "prefixes": [ "03/22" ] }