Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56669/?format=api
{ "id": 56669, "url": "http://patches.dpdk.org/api/patches/56669/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-2-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190718033616.37605-2-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190718033616.37605-2-ajit.khaparde@broadcom.com", "date": "2019-07-18T03:35:55", "name": "[01/22] net/bnxt: fix to handle error case during port start", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "72a000d94280acbfc6ab13ed7561a0174c3efbc6", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190718033616.37605-2-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5581, "url": "http://patches.dpdk.org/api/series/5581/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5581", "date": "2019-07-18T03:35:54", "name": "bnxt patchset", "version": 1, "mbox": "http://patches.dpdk.org/series/5581/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56669/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56669/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 78016326C;\n\tThu, 18 Jul 2019 05:36:27 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 1CA1C2C17;\n\tThu, 18 Jul 2019 05:36:24 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 7174830C3A1;\n\tWed, 17 Jul 2019 20:36:22 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id AE404AC0761;\n\tWed, 17 Jul 2019 20:36:21 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 7174830C3A1", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563420982;\n\tbh=hh/Eb4NpCX6ILvA/8nsF0tnkhxrRwBHZvrGsJ4RE5uw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IY+B6Ee/5H77te5U+eztaoTAslZ3xzIOJHCG9B7fIXrQv9gY4wN6m3e3VQMEMhmBF\n\tv9AvPkxu9GFPLY9XWiROE3lf1ijyIVfWDjnHt17wcMsmtNzZrumdYwoCr3CJ/g6Utf\n\tLmeOMY5hs4zJ+g2cNMA+7BjgstNsJeZn0PS2B6jA=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tstable@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Thu, 18 Jul 2019 09:05:55 +0530", "Message-Id": "<20190718033616.37605-2-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "References": "<20190718033616.37605-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 01/22] net/bnxt: fix to handle error case during\n\tport start", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\n1. during port start, if bnxt_init_chip() return error\n bnxt_dev_start_op() invokes bnxt_shutdown_nic() which in turn calls\n bnxt_free_all_hwrm_resources() to free up resources. Hence remove the\n bnxt_free_all_hwrm_resources() from bnxt_init_chip() failure path.\n2. fix to check the return value of rte_intr_enable() as this call\n can fail.\n3. set bp->dev_stopped to 0 only when port start succeeds.\n4. handle failure cases in bnxt_init_chip() routine to do proper\n cleanup and return correct error value.\n\nFixes: b7778e8a1c00 (\"net/bnxt: refactor to properly allocate resources for PF/VF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 24 +++++++++++++++---------\n 1 file changed, 15 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex cd87d0dbc..7290c4c33 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -394,8 +394,9 @@ static int bnxt_init_chip(struct bnxt *bp)\n \t\t\t\t\tbp->rx_cp_nr_rings);\n \t\t\treturn -ENOTSUP;\n \t\t}\n-\t\tif (rte_intr_efd_enable(intr_handle, intr_vector))\n-\t\t\treturn -1;\n+\t\trc = rte_intr_efd_enable(intr_handle, intr_vector);\n+\t\tif (rc)\n+\t\t\treturn rc;\n \t}\n \n \tif (rte_intr_dp_is_en(intr_handle) && !intr_handle->intr_vec) {\n@@ -406,7 +407,8 @@ static int bnxt_init_chip(struct bnxt *bp)\n \t\tif (intr_handle->intr_vec == NULL) {\n \t\t\tPMD_DRV_LOG(ERR, \"Failed to allocate %d rx_queues\"\n \t\t\t\t\" intr_vec\", bp->eth_dev->data->nb_rx_queues);\n-\t\t\treturn -ENOMEM;\n+\t\t\trc = -ENOMEM;\n+\t\t\tgoto err_disable;\n \t\t}\n \t\tPMD_DRV_LOG(DEBUG, \"intr_handle->intr_vec = %p \"\n \t\t\t\"intr_handle->nb_efd = %d intr_handle->max_intr = %d\\n\",\n@@ -421,12 +423,14 @@ static int bnxt_init_chip(struct bnxt *bp)\n \t}\n \n \t/* enable uio/vfio intr/eventfd mapping */\n-\trte_intr_enable(intr_handle);\n+\trc = rte_intr_enable(intr_handle);\n+\tif (rc)\n+\t\tgoto err_free;\n \n \trc = bnxt_get_hwrm_link_config(bp, &new);\n \tif (rc) {\n \t\tPMD_DRV_LOG(ERR, \"HWRM Get link config failure rc: %x\\n\", rc);\n-\t\tgoto err_out;\n+\t\tgoto err_free;\n \t}\n \n \tif (!bp->link_info.link_up) {\n@@ -434,16 +438,18 @@ static int bnxt_init_chip(struct bnxt *bp)\n \t\tif (rc) {\n \t\t\tPMD_DRV_LOG(ERR,\n \t\t\t\t\"HWRM link config failure rc: %x\\n\", rc);\n-\t\t\tgoto err_out;\n+\t\t\tgoto err_free;\n \t\t}\n \t}\n \tbnxt_print_link_info(bp->eth_dev);\n \n \treturn 0;\n \n+err_free:\n+\trte_free(intr_handle->intr_vec);\n+err_disable:\n+\trte_intr_efd_disable(intr_handle);\n err_out:\n-\tbnxt_free_all_hwrm_resources(bp);\n-\n \t/* Some of the error status returned by FW may not be from errno.h */\n \tif (rc > 0)\n \t\trc = -EIO;\n@@ -759,7 +765,6 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \t\t\t\"RxQ cnt %d > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS %d\\n\",\n \t\t\tbp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \t}\n-\tbp->dev_stopped = 0;\n \n \trc = bnxt_init_chip(bp);\n \tif (rc)\n@@ -781,6 +786,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n \tbnxt_enable_int(bp);\n \tbp->flags |= BNXT_FLAG_INIT_DONE;\n+\tbp->dev_stopped = 0;\n \treturn 0;\n \n error:\n", "prefixes": [ "01/22" ] }