Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56600/?format=api
{ "id": 56600, "url": "http://patches.dpdk.org/api/patches/56600/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190717104139.21155-12-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190717104139.21155-12-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190717104139.21155-12-ajit.khaparde@broadcom.com", "date": "2019-07-17T10:41:35", "name": "[v3,11/15] net/bnxt: fix to enable disable interrupts correctly", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9ec5f477d11eecceaa09c2375e72fe3a97f8e99b", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190717104139.21155-12-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5557, "url": "http://patches.dpdk.org/api/series/5557/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5557", "date": "2019-07-17T10:41:24", "name": "bnxt patch series", "version": 3, "mbox": "http://patches.dpdk.org/series/5557/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56600/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/56600/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C45D31BDF0;\n\tWed, 17 Jul 2019 12:42:21 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 77DD21B9C9;\n\tWed, 17 Jul 2019 12:42:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 2D09330C0AA;\n\tWed, 17 Jul 2019 03:42:08 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 5C16EAC0749;\n\tWed, 17 Jul 2019 03:42:06 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 2D09330C0AA", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563360128;\n\tbh=hrnwpygoYPA7zIqrva3PL+SBGwnrP394NK0PDDu2M5Y=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Yc6gBiFs8NjUUibRxmeE9zNltQayAbW/BdJNm6QCaTlSNYdIX6zojf9UXsZwUkKgC\n\tvClXHuGVx1dPvJeT9YyWhlRb4AQBF0Swp7EQMSpCstYH070V66F4bU2KsAmQvNHZof\n\tsmNjwujgxfBdKJeWVvWP4kFXLwznyuA+8SRgYsyY=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Kalesh AP <kalesh-anakkur.purayil@broadcom.com>, \n\tstable@dpdk.org, Somnath Kotur <somnath.kotur@broadcom.com>", "Date": "Wed, 17 Jul 2019 16:11:35 +0530", "Message-Id": "<20190717104139.21155-12-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190717104139.21155-1-ajit.khaparde@broadcom.com>", "References": "<0c1b327c-2c36-652f-c88d-cbca8f873c13@intel.com>\n\t<20190717104139.21155-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 11/15] net/bnxt: fix to enable disable\n\tinterrupts correctly", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\n1. disable interrupts in dev_stop_op()\n2. enable interrupts in dev_start_op()\n3. Clean queue intr-vector mapping in dev_stop_op() and thus\n fix a possible memory leak.\n\nFixes: c09f57b49c13 (\"net/bnxt: add start/stop/link update operations\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n--\nv1->v3: Fix errors reported by check-git-log script.\n---\n drivers/net/bnxt/bnxt_ethdev.c | 17 ++++++++++++++++-\n drivers/net/bnxt/bnxt_irq.c | 2 --\n 2 files changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex e44df1881..538bed1a5 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -779,6 +779,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \n \teth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);\n \teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n+\tbnxt_enable_int(bp);\n \tbp->flags |= BNXT_FLAG_INIT_DONE;\n \treturn 0;\n \n@@ -818,6 +819,13 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev)\n static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n {\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);\n+\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n+\n+\tbnxt_disable_int(bp);\n+\n+\t/* disable uio/vfio intr/eventfd mapping */\n+\trte_intr_disable(intr_handle);\n \n \tbp->flags &= ~BNXT_FLAG_INIT_DONE;\n \tif (bp->eth_dev->data->dev_started) {\n@@ -825,6 +833,14 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)\n \t\teth_dev->data->dev_link.link_status = 0;\n \t}\n \tbnxt_set_hwrm_link_config(bp, false);\n+\n+\t/* Clean queue intr-vector mapping */\n+\trte_intr_efd_disable(intr_handle);\n+\tif (intr_handle->intr_vec != NULL) {\n+\t\trte_free(intr_handle->intr_vec);\n+\t\tintr_handle->intr_vec = NULL;\n+\t}\n+\n \tbnxt_hwrm_port_clr_stats(bp);\n \tbnxt_free_tx_mbufs(bp);\n \tbnxt_free_rx_mbufs(bp);\n@@ -3991,7 +4007,6 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \tif (rc)\n \t\tgoto error_free_int;\n \n-\tbnxt_enable_int(bp);\n \tbnxt_init_nic(bp);\n \n \treturn 0;\ndiff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c\nindex 61f7498a5..6c4dce401 100644\n--- a/drivers/net/bnxt/bnxt_irq.c\n+++ b/drivers/net/bnxt/bnxt_irq.c\n@@ -58,7 +58,6 @@ void bnxt_free_int(struct bnxt *bp)\n \tirq = bp->irq_tbl;\n \tif (irq) {\n \t\tif (irq->requested) {\n-\t\t\trte_intr_disable(&bp->pdev->intr_handle);\n \t\t\trte_intr_callback_unregister(&bp->pdev->intr_handle,\n \t\t\t\t\t\t irq->handler,\n \t\t\t\t\t\t (void *)bp->eth_dev);\n@@ -123,7 +122,6 @@ int bnxt_request_int(struct bnxt *bp)\n \n \trte_intr_callback_register(&bp->pdev->intr_handle, irq->handler,\n \t\t\t\t (void *)bp->eth_dev);\n-\trte_intr_enable(&bp->pdev->intr_handle);\n \n \tirq->requested = 1;\n \treturn rc;\n", "prefixes": [ "v3", "11/15" ] }