Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56598/?format=api
{ "id": 56598, "url": "http://patches.dpdk.org/api/patches/56598/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190717104139.21155-10-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190717104139.21155-10-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190717104139.21155-10-ajit.khaparde@broadcom.com", "date": "2019-07-17T10:41:33", "name": "[v3,09/15] net/bnxt: nq doorbell cleanups", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d01eaee3a3dd2765d77df01127595bc5a07d467f", "submitter": { "id": 501, "url": "http://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190717104139.21155-10-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 5557, "url": "http://patches.dpdk.org/api/series/5557/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5557", "date": "2019-07-17T10:41:24", "name": "bnxt patch series", "version": 3, "mbox": "http://patches.dpdk.org/series/5557/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56598/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/56598/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 363EB1BC20;\n\tWed, 17 Jul 2019 12:42:15 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 4ED221B9AF\n\tfor <dev@dpdk.org>; Wed, 17 Jul 2019 12:42:05 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 1FB5A30C0AB;\n\tWed, 17 Jul 2019 03:42:04 -0700 (PDT)", "from C02VPB22HTD6.wifi.broadcom.net (c02vpb22htd6.wifi.broadcom.net\n\t[10.122.43.105])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id A9990AC0749;\n\tWed, 17 Jul 2019 03:42:02 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 1FB5A30C0AB", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1563360124;\n\tbh=5ATZ2wUafOqbMn9qs7E3ffeQiiRY472jGYlEmFiN+vY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=AiayFuUUB+/PCgFD+Bj8deR/5dehGD0sgJMpBcu24cK6TTEOc1/Zr+HXQKw7a5iwg\n\td7leFAaJgzI93TjG2DT551ijWs0nbng7tIQQ4P5XLQYU8ixK3ZNH9Ul3eLtxB8ttAk\n\tBpViL6kqjmFCTTmInnVaCKuPkedZ0x+ZnL5Lq+5w=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Lance Richardson <lance.richardson@broadcom.com>", "Date": "Wed, 17 Jul 2019 16:11:33 +0530", "Message-Id": "<20190717104139.21155-10-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.20.1 (Apple Git-117)", "In-Reply-To": "<20190717104139.21155-1-ajit.khaparde@broadcom.com>", "References": "<0c1b327c-2c36-652f-c88d-cbca8f873c13@intel.com>\n\t<20190717104139.21155-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 09/15] net/bnxt: nq doorbell cleanups", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Lance Richardson <lance.richardson@broadcom.com>\n\nSimplify nq doorbell handling code by removing redundant db\nparameter and consolidating NQ doorbell macro into the inline\nfunction that uses it.\n\nAdd \"enable interrupt\" variant of nq write. This will be used\nin a subsequent commit.\n\nWhen initializing nq doorbell, don't assume that only the\n\"disable interrupt\" form will be used.\n\nFixes: f8168ca0e690 (\"net/bnxt: support thor controller\")\nSigned-off-by: Lance Richardson <lance.richardson@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ring.c | 2 +-\n drivers/net/bnxt/bnxt_ring.h | 23 ++++++++++++++++++-----\n 3 files changed, 20 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex cd809b385..3ccf784e5 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -246,6 +246,7 @@ struct bnxt_coal {\n #define DBR_TYPE_SRQ\t\t\t\t(0x2ULL << 60)\n #define DBR_TYPE_CQ\t\t\t\t(0x4ULL << 60)\n #define DBR_TYPE_NQ\t\t\t\t(0xaULL << 60)\n+#define DBR_TYPE_NQ_ARM\t\t\t\t(0xbULL << 60)\n \n #define BNXT_RSS_TBL_SIZE_THOR\t\t512\n #define BNXT_RSS_ENTRIES_PER_CTX_THOR\t64\ndiff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c\nindex 9b19459b6..faf861cc1 100644\n--- a/drivers/net/bnxt/bnxt_ring.c\n+++ b/drivers/net/bnxt/bnxt_ring.c\n@@ -341,7 +341,7 @@ static void bnxt_set_db(struct bnxt *bp,\n \t\t\tdb->db_key64 = DBR_PATH_L2 | DBR_TYPE_CQ;\n \t\t\tbreak;\n \t\tcase HWRM_RING_ALLOC_INPUT_RING_TYPE_NQ:\n-\t\t\tdb->db_key64 = DBR_PATH_L2 | DBR_TYPE_NQ;\n+\t\t\tdb->db_key64 = DBR_PATH_L2;\n \t\t\tbreak;\n \t\t}\n \t\tdb->db_key64 |= (uint64_t)fid << DBR_XID_SFT;\ndiff --git a/drivers/net/bnxt/bnxt_ring.h b/drivers/net/bnxt/bnxt_ring.h\nindex af2c5762f..e5cef3a1d 100644\n--- a/drivers/net/bnxt/bnxt_ring.h\n+++ b/drivers/net/bnxt/bnxt_ring.h\n@@ -84,15 +84,28 @@ static inline void bnxt_db_write(struct bnxt_db_info *db, uint32_t idx)\n \t\trte_write32(db->db_key32 | idx, db->doorbell);\n }\n \n+/* Ring an NQ doorbell and disable interrupts for the ring. */\n static inline void bnxt_db_nq(struct bnxt_cp_ring_info *cpr)\n {\n-\tstruct bnxt_db_info *db = &cpr->cp_db;\n+\tif (unlikely(!cpr->cp_db.db_64))\n+\t\treturn;\n+\n+\trte_smp_wmb();\n+\trte_write64(cpr->cp_db.db_key64 | DBR_TYPE_NQ |\n+\t\t RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),\n+\t\t cpr->cp_db.doorbell);\n+}\n+\n+/* Ring an NQ doorbell and enable interrupts for the ring. */\n+static inline void bnxt_db_nq_arm(struct bnxt_cp_ring_info *cpr)\n+{\n+\tif (unlikely(!cpr->cp_db.db_64))\n+\t\treturn;\n \n \trte_smp_wmb();\n-\tif (likely(db->db_64))\n-\t\trte_write64(db->db_key64 | DBR_TYPE_NQ |\n-\t\t\t RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),\n-\t\t\t db->doorbell);\n+\trte_write64(cpr->cp_db.db_key64 | DBR_TYPE_NQ_ARM |\n+\t\t RING_CMP(cpr->cp_ring_struct, cpr->cp_raw_cons),\n+\t\t cpr->cp_db.doorbell);\n }\n \n static inline void bnxt_db_cq(struct bnxt_cp_ring_info *cpr)\n", "prefixes": [ "v3", "09/15" ] }