Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56477,
    "url": "http://patches.dpdk.org/api/patches/56477/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190716161225.67317-1-ting.xu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190716161225.67317-1-ting.xu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190716161225.67317-1-ting.xu@intel.com",
    "date": "2019-07-16T16:12:25",
    "name": "[v2] net/iavf: fix driver crash when enable TSO",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "4bce0d1ff7b1c0c47b89cd8ac7783165c1b1a63f",
    "submitter": {
        "id": 1363,
        "url": "http://patches.dpdk.org/api/people/1363/?format=api",
        "name": "Xu, Ting",
        "email": "ting.xu@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190716161225.67317-1-ting.xu@intel.com/mbox/",
    "series": [
        {
            "id": 5517,
            "url": "http://patches.dpdk.org/api/series/5517/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5517",
            "date": "2019-07-16T16:12:25",
            "name": "[v2] net/iavf: fix driver crash when enable TSO",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/5517/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/56477/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/56477/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8A1263423;\n\tTue, 16 Jul 2019 11:13:00 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 59715324D;\n\tTue, 16 Jul 2019 11:12:58 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t16 Jul 2019 02:12:57 -0700",
            "from dpdk_xuting.sh.intel.com ([10.67.110.161])\n\tby orsmga001.jf.intel.com with ESMTP; 16 Jul 2019 02:12:56 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.63,497,1557212400\"; d=\"scan'208\";a=\"251097969\"",
        "From": "Ting Xu <ting.xu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, Ting Xu <ting.xu@intel.com>,\n\tstable@dpdk.org",
        "Date": "Tue, 16 Jul 2019 16:12:25 +0000",
        "Message-Id": "<20190716161225.67317-1-ting.xu@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH v2] net/iavf: fix driver crash when enable TSO",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The iavf driver crashes when forwarding packets with TSO\nenabled. The reason is that the tx context descriptor\nconfiguration is not transferred to tx-ring. This step is\nadded in this patch.\n\nFixes: 584798f8e8ab (\"net/avf: fix unused variables and label\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ting Xu <ting.xu@intel.com>\n---\n drivers/net/iavf/iavf_rxtx.c | 6 ++++++\n 1 file changed, 6 insertions(+)",
    "diff": "diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c\nindex 2d37c1705..d8eb6d296 100644\n--- a/drivers/net/iavf/iavf_rxtx.c\n+++ b/drivers/net/iavf/iavf_rxtx.c\n@@ -1580,6 +1580,9 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t/* Setup TX context descriptor if required */\n \t\t\tuint64_t cd_type_cmd_tso_mss =\n \t\t\t\tIAVF_TX_DESC_DTYPE_CONTEXT;\n+\t\t\tvolatile struct iavf_tx_context_desc *ctx_txd =\n+\t\t\t\t(volatile struct iavf_tx_context_desc *)\n+\t\t\t\t\t\t\t&txr[tx_id];\n \n \t\t\ttxn = &sw_ring[txe->next_id];\n \t\t\tRTE_MBUF_PREFETCH_TO_FREE(txn->mbuf);\n@@ -1593,6 +1596,9 @@ iavf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\t\tcd_type_cmd_tso_mss |=\n \t\t\t\t\tiavf_set_tso_ctx(tx_pkt, tx_offload);\n \n+\t\t\tctx_txd->type_cmd_tso_mss =\n+\t\t\t\trte_cpu_to_le_64(cd_type_cmd_tso_mss);\n+\n \t\t\tIAVF_DUMP_TX_DESC(txq, &txr[tx_id], tx_id);\n \t\t\ttxe->last_id = tx_last;\n \t\t\ttx_id = txe->next_id;\n",
    "prefixes": [
        "v2"
    ]
}