Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56466/?format=api
{ "id": 56466, "url": "http://patches.dpdk.org/api/patches/56466/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190716023855.184619-1-qiming.yang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190716023855.184619-1-qiming.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190716023855.184619-1-qiming.yang@intel.com", "date": "2019-07-16T02:38:55", "name": "net/ice: fix outer input set empty", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bd75011f8dcd4a9f75131c9c5237aa485976852a", "submitter": { "id": 522, "url": "http://patches.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190716023855.184619-1-qiming.yang@intel.com/mbox/", "series": [ { "id": 5506, "url": "http://patches.dpdk.org/api/series/5506/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5506", "date": "2019-07-16T02:38:55", "name": "net/ice: fix outer input set empty", "version": 1, "mbox": "http://patches.dpdk.org/series/5506/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56466/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56466/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5E9DA2082;\n\tTue, 16 Jul 2019 04:41:56 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 78853271;\n\tTue, 16 Jul 2019 04:41:54 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t15 Jul 2019 19:41:53 -0700", "from map1.sh.intel.com ([10.67.111.138])\n\tby orsmga005.jf.intel.com with ESMTP; 15 Jul 2019 19:41:52 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,496,1557212400\"; d=\"scan'208\";a=\"342572640\"", "From": "Qiming Yang <qiming.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Qiming Yang <qiming.yang@intel.com>,\n\tstable@dpdk.org", "Date": "Tue, 16 Jul 2019 10:38:55 +0800", "Message-Id": "<20190716023855.184619-1-qiming.yang@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[dpdk-dev] [PATCH] net/ice: fix outer input set empty", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Should allow the outer input set be empty.\n\nFixes: d76116a4678f (\"net/ice: add generic flow API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/ice_generic_flow.c | 41 ++++++++++----------------------------\n 1 file changed, 10 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c\nindex 05a1678..c2931a1 100644\n--- a/drivers/net/ice/ice_generic_flow.c\n+++ b/drivers/net/ice/ice_generic_flow.c\n@@ -238,13 +238,8 @@ static uint64_t ice_get_flow_field(const struct rte_flow_item pattern[],\n \t\t\tipv4_spec = item->spec;\n \t\t\tipv4_mask = item->mask;\n \n-\t\t\tif (!(ipv4_spec && ipv4_mask)) {\n-\t\t\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\t item,\n-\t\t\t\t\t \"Invalid IPv4 spec or mask.\");\n-\t\t\t\treturn 0;\n-\t\t\t}\n+\t\t\tif (!(ipv4_spec && ipv4_mask))\n+\t\t\t\tbreak;\n \n \t\t\t/* Check IPv4 mask and update input set */\n \t\t\tif (ipv4_mask->hdr.version_ihl ||\n@@ -284,12 +279,8 @@ static uint64_t ice_get_flow_field(const struct rte_flow_item pattern[],\n \t\t\tipv6_spec = item->spec;\n \t\t\tipv6_mask = item->mask;\n \n-\t\t\tif (!(ipv6_spec && ipv6_mask)) {\n-\t\t\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\titem, \"Invalid IPv6 spec or mask\");\n-\t\t\t\treturn 0;\n-\t\t\t}\n+\t\t\tif (!(ipv6_spec && ipv6_mask))\n+\t\t\t\tbreak;\n \n \t\t\tif (ipv6_mask->hdr.payload_len ||\n \t\t\t ipv6_mask->hdr.vtc_flow) {\n@@ -333,12 +324,8 @@ static uint64_t ice_get_flow_field(const struct rte_flow_item pattern[],\n \t\t\tudp_spec = item->spec;\n \t\t\tudp_mask = item->mask;\n \n-\t\t\tif (!(udp_spec && udp_mask)) {\n-\t\t\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\t\t item, \"Invalid UDP mask\");\n-\t\t\t\treturn 0;\n-\t\t\t}\n+\t\t\tif (!(udp_spec && udp_mask))\n+\t\t\t\tbreak;\n \n \t\t\t/* Check UDP mask and update input set*/\n \t\t\tif (udp_mask->hdr.dgram_len ||\n@@ -367,12 +354,8 @@ static uint64_t ice_get_flow_field(const struct rte_flow_item pattern[],\n \t\t\ttcp_spec = item->spec;\n \t\t\ttcp_mask = item->mask;\n \n-\t\t\tif (!(tcp_spec && tcp_mask)) {\n-\t\t\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\t\t item, \"Invalid TCP mask\");\n-\t\t\t\treturn 0;\n-\t\t\t}\n+\t\t\tif (!(tcp_spec && tcp_mask))\n+\t\t\t\tbreak;\n \n \t\t\t/* Check TCP mask and update input set */\n \t\t\tif (tcp_mask->hdr.sent_seq ||\n@@ -406,12 +389,8 @@ static uint64_t ice_get_flow_field(const struct rte_flow_item pattern[],\n \t\t\tsctp_spec = item->spec;\n \t\t\tsctp_mask = item->mask;\n \n-\t\t\tif (!(sctp_spec && sctp_mask)) {\n-\t\t\t\trte_flow_error_set(error, EINVAL,\n-\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n-\t\t\t\t\t\t item, \"Invalid SCTP mask\");\n-\t\t\t\treturn 0;\n-\t\t\t}\n+\t\t\tif (!(sctp_spec && sctp_mask))\n+\t\t\t\tbreak;\n \n \t\t\t/* Check SCTP mask and update input set */\n \t\t\tif (sctp_mask->hdr.cksum) {\n", "prefixes": [] }