Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56419,
    "url": "http://patches.dpdk.org/api/patches/56419/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190715022356.73350-1-qiming.yang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190715022356.73350-1-qiming.yang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190715022356.73350-1-qiming.yang@intel.com",
    "date": "2019-07-15T02:23:56",
    "name": "[v3] net/ice: fix flow validation fail",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "e4c43da536885ea8060fccfbb2e8453260b81869",
    "submitter": {
        "id": 522,
        "url": "http://patches.dpdk.org/api/people/522/?format=api",
        "name": "Qiming Yang",
        "email": "qiming.yang@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190715022356.73350-1-qiming.yang@intel.com/mbox/",
    "series": [
        {
            "id": 5484,
            "url": "http://patches.dpdk.org/api/series/5484/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5484",
            "date": "2019-07-15T02:23:56",
            "name": "[v3] net/ice: fix flow validation fail",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/5484/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/56419/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/56419/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2AB962C5E;\n\tMon, 15 Jul 2019 04:26:58 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 6D1D82BF5;\n\tMon, 15 Jul 2019 04:26:56 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Jul 2019 19:26:55 -0700",
            "from map1.sh.intel.com ([10.67.111.138])\n\tby fmsmga006.fm.intel.com with ESMTP; 14 Jul 2019 19:26:53 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.63,492,1557212400\"; d=\"scan'208\";a=\"366180964\"",
        "From": "Qiming Yang <qiming.yang@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Qiming Yang <qiming.yang@intel.com>,\n\tstable@dpdk.org",
        "Date": "Mon, 15 Jul 2019 10:23:56 +0800",
        "Message-Id": "<20190715022356.73350-1-qiming.yang@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "In-Reply-To": "<20190709040812.4191-1-qiming.yang@intel.com>",
        "References": "<20190709040812.4191-1-qiming.yang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3] net/ice: fix flow validation fail",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "ice_flow_valid_attr will return zero on success and a\nnegative value on error. Current return value check\nlogical is opposite to the expected behavior. This\npatch fixed this issue.\n\nFixes: d76116a4678f (\"net/ice: add generic flow API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/ice_generic_flow.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c\nindex d5ff278..e6a2c4b 100644\n--- a/drivers/net/ice/ice_generic_flow.c\n+++ b/drivers/net/ice/ice_generic_flow.c\n@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,\n \t\t\trte_flow_error_set(error, EINVAL,\n \t\t\t\t\t   RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\t\t   actions, \"Invalid queue ID for\"\n-\t\t\t\t\t   \" ethertype_filter.\");\n+\t\t\t\t\t   \" switch filter.\");\n \t\t\treturn -rte_errno;\n \t\t}\n \t\tbreak;\n@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,\n \t}\n \n \tret = ice_flow_valid_attr(attr, error);\n-\tif (!ret)\n+\tif (ret)\n \t\treturn ret;\n \n \tinset = ice_flow_valid_pattern(pattern, error);\n",
    "prefixes": [
        "v3"
    ]
}