Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56413/?format=api
http://patches.dpdk.org/api/patches/56413/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1a51612a8bd6b6f359aec9b0072f8763cd59cb6c.1562947317.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1a51612a8bd6b6f359aec9b0072f8763cd59cb6c.1562947317.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1a51612a8bd6b6f359aec9b0072f8763cd59cb6c.1562947317.git.anatoly.burakov@intel.com", "date": "2019-07-12T16:02:05", "name": "test: make multiprocess launch error more informative", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "62768836bff366a8fade96e462f891acdb57460c", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1a51612a8bd6b6f359aec9b0072f8763cd59cb6c.1562947317.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 5480, "url": "http://patches.dpdk.org/api/series/5480/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5480", "date": "2019-07-12T16:02:05", "name": "test: make multiprocess launch error more informative", "version": 1, "mbox": "http://patches.dpdk.org/series/5480/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56413/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/56413/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0706B1BE19;\n\tFri, 12 Jul 2019 18:02:10 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 556651BE02\n\tfor <dev@dpdk.org>; Fri, 12 Jul 2019 18:02:08 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jul 2019 09:02:07 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga001.jf.intel.com with ESMTP; 12 Jul 2019 09:02:06 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,483,1557212400\"; d=\"scan'208\";a=\"250160184\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 12 Jul 2019 17:02:05 +0100", "Message-Id": "<1a51612a8bd6b6f359aec9b0072f8763cd59cb6c.1562947317.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] test: make multiprocess launch error more\n\tinformative", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, if there is no procfs mounted, test application will\nfail to run any multiprocess-related autotests (EAL flags etc.)\nwithout a clear explanation as to why this happens.\n\nAdd a check specifically for that condition, as well as add a\ngeneral stringified error message to rte_panic.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n app/test/process.h | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/process.h b/app/test/process.h\nindex 513bc9420..128ce4121 100644\n--- a/app/test/process.h\n+++ b/app/test/process.h\n@@ -5,12 +5,16 @@\n #ifndef _PROCESS_H_\n #define _PROCESS_H_\n \n+#include <errno.h> /* errno */\n #include <limits.h> /* PATH_MAX */\n #include <libgen.h> /* basename et al */\n #include <stdlib.h> /* NULL */\n+#include <string.h> /* strerror */\n #include <unistd.h> /* readlink */\n #include <sys/wait.h>\n \n+#include <rte_string_fns.h> /* strlcpy */\n+\n #ifdef RTE_EXEC_ENV_FREEBSD\n #define self \"curproc\"\n #define exe \"file\"\n@@ -67,8 +71,15 @@ process_dup(const char *const argv[], int numargs, const char *env_value)\n \t\t/* set the environment variable */\n \t\tif (setenv(RECURSIVE_ENV_VAR, env_value, 1) != 0)\n \t\t\trte_panic(\"Cannot export environment variable\\n\");\n-\t\tif (execv(\"/proc/\" self \"/\" exe, argv_cpy) < 0)\n-\t\t\trte_panic(\"Cannot exec\\n\");\n+\n+\t\tstrlcpy(path, \"/proc/\" self \"/\" exe, sizeof(path));\n+\t\tif (execv(path, argv_cpy) < 0) {\n+\t\t\tif (errno == ENOENT) {\n+\t\t\t\tprintf(\"Could not find '%s', is procfs mounted?\\n\",\n+\t\t\t\t\t\tpath);\n+\t\t\t}\n+\t\t\trte_panic(\"Cannot exec: %s\\n\", strerror(errno));\n+\t\t}\n \t}\n \t/* parent process does a wait */\n #ifdef RTE_LIBRTE_PDUMP\n", "prefixes": [] }{ "id": 56413, "url": "