Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56397/?format=api
{ "id": 56397, "url": "http://patches.dpdk.org/api/patches/56397/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190712095729.159767-6-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190712095729.159767-6-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190712095729.159767-6-jasvinder.singh@intel.com", "date": "2019-07-12T09:57:23", "name": "[v4,05/11] sched: improve error log messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "033bbe83697b8fc90e9155406af2d538190f41c2", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190712095729.159767-6-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5473, "url": "http://patches.dpdk.org/api/series/5473/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5473", "date": "2019-07-12T09:57:18", "name": "sched: feature enhancements", "version": 4, "mbox": "http://patches.dpdk.org/series/5473/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56397/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/56397/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 563441BDEC;\n\tFri, 12 Jul 2019 11:57:35 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 050881B9ED\n\tfor <dev@dpdk.org>; Fri, 12 Jul 2019 11:57:27 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jul 2019 02:57:27 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga005.jf.intel.com with ESMTP; 12 Jul 2019 02:57:25 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,482,1557212400\"; d=\"scan'208\";a=\"341656812\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Fri, 12 Jul 2019 10:57:23 +0100", "Message-Id": "<20190712095729.159767-6-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190712095729.159767-1-jasvinder.singh@intel.com>", "References": "<20190711102659.59001-2-jasvinder.singh@intel.com>\n\t<20190712095729.159767-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 05/11] sched: improve error log messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace hard-coded numbers for reporting errors with\nerror messages.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 294 ++++++++++++++++++++++++++---------\n 1 file changed, 220 insertions(+), 74 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex c3edc7fbd..8dd4300be 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -272,46 +272,69 @@ pipe_profile_check(struct rte_sched_pipe_params *params,\n \tuint32_t i;\n \n \t/* Pipe parameters */\n-\tif (params == NULL)\n-\t\treturn -10;\n+\tif (params == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter params\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* TB rate: non-zero, not greater than port rate */\n \tif (params->tb_rate == 0 ||\n-\t\tparams->tb_rate > rate)\n-\t\treturn -11;\n+\t\tparams->tb_rate > rate) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tb rate\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* TB size: non-zero */\n-\tif (params->tb_size == 0)\n-\t\treturn -12;\n+\tif (params->tb_size == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tb size\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* TC rate: non-zero, less than pipe rate */\n \tfor (i = 0; i < RTE_SCHED_TRAFFIC_CLASS_BE; i++) {\n \t\tif ((qsize[i] == 0 && params->tc_rate[i] != 0) ||\n \t\t\t(qsize[i] != 0 && (params->tc_rate[i] == 0 ||\n-\t\t\tparams->tc_rate[i] > params->tb_rate)))\n-\t\t\treturn -13;\n-\n+\t\t\tparams->tc_rate[i] > params->tb_rate))) {\n+\t\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\t\"%s: Incorrect value for qsize or tc_rate\\n\", __func__);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n-\tif (params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE] == 0)\n-\t\treturn -13;\n+\tif (params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE] == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for be traffic class rate\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* TC period: non-zero */\n-\tif (params->tc_period == 0)\n-\t\treturn -14;\n+\tif (params->tc_period == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tc period\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n #ifdef RTE_SCHED_SUBPORT_TC_OV\n \t/* TC3 oversubscription weight: non-zero */\n-\tif (params->tc_ov_weight == 0)\n-\t\treturn -15;\n+\tif (params->tc_ov_weight == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tc ov weight\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n #endif\n \n \t/* Queue WRR weights: non-zero */\n \tfor (i = 0; i < RTE_SCHED_BE_QUEUES_PER_PIPE; i++) {\n \t\tuint32_t qindex = RTE_SCHED_TRAFFIC_CLASS_BE + i;\n \t\tif ((qsize[qindex] != 0 && params->wrr_weights[i] == 0) ||\n-\t\t\t(qsize[qindex] == 0 && params->wrr_weights[i] != 0))\n-\t\t\treturn -16;\n+\t\t\t(qsize[qindex] == 0 && params->wrr_weights[i] != 0)) {\n+\t\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\t\"%s: Incorrect value for qsize or wrr weight\\n\", __func__);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \treturn 0;\n }\n@@ -321,55 +344,82 @@ rte_sched_port_check_params(struct rte_sched_port_params *params)\n {\n \tuint32_t i;\n \n-\tif (params == NULL)\n-\t\treturn -1;\n+\tif (params == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter params\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* socket */\n-\tif (params->socket < 0)\n-\t\treturn -3;\n+\tif (params->socket < 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for socket id\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* rate */\n-\tif (params->rate == 0)\n-\t\treturn -4;\n+\tif (params->rate == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for rate\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* mtu */\n-\tif (params->mtu == 0)\n-\t\treturn -5;\n+\tif (params->mtu == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for mtu\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* n_subports_per_port: non-zero, limited to 16 bits, power of 2 */\n \tif (params->n_subports_per_port == 0 ||\n \t params->n_subports_per_port > 1u << 16 ||\n-\t !rte_is_power_of_2(params->n_subports_per_port))\n-\t\treturn -6;\n+\t !rte_is_power_of_2(params->n_subports_per_port)) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for number of subports\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* n_pipes_per_subport: non-zero, power of 2 */\n \tif (params->n_pipes_per_subport == 0 ||\n-\t !rte_is_power_of_2(params->n_pipes_per_subport))\n-\t\treturn -7;\n+\t !rte_is_power_of_2(params->n_pipes_per_subport)) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for pipes number\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n-\t/* qsize: non-zero, power of 2,\n+\t/* qsize: if non-zero, power of 2,\n \t * no bigger than 32K (due to 16-bit read/write pointers)\n \t */\n \tfor (i = 0; i < RTE_SCHED_QUEUES_PER_PIPE; i++) {\n \t\tuint16_t qsize = params->qsize[i];\n \t\tif ((qsize != 0 && !rte_is_power_of_2(qsize)) ||\n-\t\t\t((i == RTE_SCHED_TRAFFIC_CLASS_BE) && (qsize == 0)))\n-\t\t\treturn -8;\n+\t\t\t((i == RTE_SCHED_TRAFFIC_CLASS_BE) && (qsize == 0))) {\n+\t\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\t\"%s: Incorrect value for tc rate\\n\", __func__);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \t/* pipe_profiles and n_pipe_profiles */\n \tif (params->pipe_profiles == NULL ||\n \t params->n_pipe_profiles == 0 ||\n-\t params->n_pipe_profiles > params->n_max_pipe_profiles)\n-\t\treturn -9;\n+\t\t params->n_pipe_profiles > params->n_max_pipe_profiles) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for number of pipe profiles\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \tfor (i = 0; i < params->n_pipe_profiles; i++) {\n \t\tstruct rte_sched_pipe_params *p = params->pipe_profiles + i;\n \t\tint status;\n \n \t\tstatus = pipe_profile_check(p, params->rate, ¶ms->qsize[0]);\n-\t\tif (status != 0)\n-\t\t\treturn status;\n+\t\tif (status != 0) {\n+\t\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\t\"%s: Pipe profile check failed(%d)\\n\", __func__, status);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t}\n \n \treturn 0;\n@@ -823,16 +873,35 @@ rte_sched_subport_config(struct rte_sched_port *port,\n \tuint32_t i, j;\n \n \t/* Check user parameters */\n-\tif (port == NULL ||\n-\t subport_id >= port->n_subports_per_port ||\n-\t params == NULL)\n-\t\treturn -1;\n+\tif (port == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter port\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (subport_id >= port->n_subports_per_port) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for subport id\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n-\tif (params->tb_rate == 0 || params->tb_rate > port->rate)\n-\t\treturn -2;\n+\tif (params == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter params\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (params->tb_rate == 0 || params->tb_rate > port->rate) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tb rate\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n-\tif (params->tb_size == 0)\n-\t\treturn -3;\n+\tif (params->tb_size == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tb size\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \tfor (i = 0, j = 0; i < RTE_SCHED_QUEUES_PER_PIPE; i++) {\n \t\tuint32_t tc_rate = params->tc_rate[j];\n@@ -841,19 +910,27 @@ rte_sched_subport_config(struct rte_sched_port *port,\n \t\tif (((qsize == 0) &&\n \t\t\t((tc_rate != 0) && (j != RTE_SCHED_TRAFFIC_CLASS_BE))) ||\n \t\t\t((qsize != 0) && (tc_rate == 0)) ||\n-\t\t\t(tc_rate > params->tb_rate))\n-\t\t\treturn -3;\n-\n+\t\t\t(tc_rate > params->tb_rate)) {\n+\t\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\t\"%s: Incorrect value for tc rate\\n\", __func__);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t\tif (j < RTE_SCHED_TRAFFIC_CLASS_BE)\n \t\t\tj++;\n \t}\n \n \tif (port->qsize[RTE_SCHED_TRAFFIC_CLASS_BE] == 0 ||\n-\t\tparams->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE] == 0)\n-\t\treturn -3;\n+\t\tparams->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE] == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tc rate(best effort)\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n-\tif (params->tc_period == 0)\n-\t\treturn -5;\n+\tif (params->tc_period == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tc period\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \ts = port->subport + subport_id;\n \n@@ -918,17 +995,37 @@ rte_sched_pipe_config(struct rte_sched_port *port,\n \tprofile = (uint32_t) pipe_profile;\n \tdeactivate = (pipe_profile < 0);\n \n-\tif (port == NULL ||\n-\t subport_id >= port->n_subports_per_port ||\n-\t pipe_id >= port->n_pipes_per_subport ||\n-\t (!deactivate && profile >= port->n_pipe_profiles))\n-\t\treturn -1;\n+\tif (port == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter port\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (subport_id >= port->n_subports_per_port) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter subport id\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n+\tif (pipe_id >= port->n_pipes_per_subport) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter pipe id\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (!deactivate && profile >= port->n_pipe_profiles) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter pipe profile\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* Check that subport configuration is valid */\n \ts = port->subport + subport_id;\n-\tif (s->tb_period == 0)\n-\t\treturn -2;\n+\tif (s->tb_period == 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Subport configuration invalid\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \tp = port->pipe + (subport_id * port->n_pipes_per_subport + pipe_id);\n \n@@ -1015,25 +1112,37 @@ rte_sched_port_pipe_profile_add(struct rte_sched_port *port,\n \tint status;\n \n \t/* Port */\n-\tif (port == NULL)\n-\t\treturn -1;\n+\tif (port == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter port\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* Pipe profiles not exceeds the max limit */\n-\tif (port->n_pipe_profiles >= port->n_max_pipe_profiles)\n-\t\treturn -2;\n+\tif (port->n_pipe_profiles >= port->n_max_pipe_profiles) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Number of pipe profiles exceeds the max limit\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \t/* Pipe params */\n \tstatus = pipe_profile_check(params, port->rate, &port->qsize[0]);\n-\tif (status != 0)\n-\t\treturn status;\n+\tif (status != 0) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Pipe profile check failed(%d)\\n\", __func__, status);\n+\t\treturn -EINVAL;\n+\t}\n \n \tpp = &port->pipe_profiles[port->n_pipe_profiles];\n \trte_sched_pipe_profile_convert(port, params, pp, port->rate);\n \n \t/* Pipe profile not exists */\n \tfor (i = 0; i < port->n_pipe_profiles; i++)\n-\t\tif (memcmp(port->pipe_profiles + i, pp, sizeof(*pp)) == 0)\n-\t\t\treturn -3;\n+\t\tif (memcmp(port->pipe_profiles + i, pp, sizeof(*pp)) == 0) {\n+\t\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\t\"%s: Pipe profile doesn't exist\\n\", __func__);\n+\t\t\treturn -EINVAL;\n+\t\t}\n \n \t/* Pipe profile commit */\n \t*pipe_profile_id = port->n_pipe_profiles;\n@@ -1101,9 +1210,29 @@ rte_sched_subport_read_stats(struct rte_sched_port *port,\n \tstruct rte_sched_subport *s;\n \n \t/* Check user parameters */\n-\tif (port == NULL || subport_id >= port->n_subports_per_port ||\n-\t stats == NULL || tc_ov == NULL)\n-\t\treturn -1;\n+\tif (port == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter port\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (subport_id >= port->n_subports_per_port) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for subport id\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (stats == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter stats\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (tc_ov == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for tc_ov\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n \n \ts = port->subport + subport_id;\n \n@@ -1127,11 +1256,28 @@ rte_sched_queue_read_stats(struct rte_sched_port *port,\n \tstruct rte_sched_queue_extra *qe;\n \n \t/* Check user parameters */\n-\tif ((port == NULL) ||\n-\t (queue_id >= rte_sched_port_queues_per_port(port)) ||\n-\t\t(stats == NULL) ||\n-\t\t(qlen == NULL)) {\n-\t\treturn -1;\n+\tif (port == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter port\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (queue_id >= rte_sched_port_queues_per_port(port)) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for queue id\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (stats == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter stats\\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (qlen == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter qlen\\n\", __func__);\n+\t\treturn -EINVAL;\n \t}\n \tq = port->queue + queue_id;\n \tqe = port->queue_extra + queue_id;\n", "prefixes": [ "v4", "05/11" ] }