Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56396/?format=api
{ "id": 56396, "url": "http://patches.dpdk.org/api/patches/56396/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190712095729.159767-5-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190712095729.159767-5-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190712095729.159767-5-jasvinder.singh@intel.com", "date": "2019-07-12T09:57:22", "name": "[v4,04/11] sched: rename tc3 params to best-effort tc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "38f7910eabb359849943b8517148092251b85c5b", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190712095729.159767-5-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5473, "url": "http://patches.dpdk.org/api/series/5473/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5473", "date": "2019-07-12T09:57:18", "name": "sched: feature enhancements", "version": 4, "mbox": "http://patches.dpdk.org/series/5473/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56396/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/56396/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F3BB61BDE2;\n\tFri, 12 Jul 2019 11:57:31 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 47CDD1B9D6\n\tfor <dev@dpdk.org>; Fri, 12 Jul 2019 11:57:26 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Jul 2019 02:57:25 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga005.jf.intel.com with ESMTP; 12 Jul 2019 02:57:24 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,482,1557212400\"; d=\"scan'208\";a=\"341656807\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Fri, 12 Jul 2019 10:57:22 +0100", "Message-Id": "<20190712095729.159767-5-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190712095729.159767-1-jasvinder.singh@intel.com>", "References": "<20190711102659.59001-2-jasvinder.singh@intel.com>\n\t<20190712095729.159767-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 04/11] sched: rename tc3 params to best-effort\n\ttc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Change the traffic class 3 related params name to best-effort(be)\ntraffic class.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 48 ++++++++++++++++++------------------\n 1 file changed, 24 insertions(+), 24 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex e7bc609db..c3edc7fbd 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -181,7 +181,7 @@ struct rte_sched_port {\n \tuint16_t qsize[RTE_SCHED_QUEUES_PER_PIPE];\n \tuint32_t n_pipe_profiles;\n \tuint32_t n_max_pipe_profiles;\n-\tuint32_t pipe_tc3_rate_max;\n+\tuint32_t pipe_tc_be_rate_max;\n #ifdef RTE_SCHED_RED\n \tstruct rte_red_config red_config[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];\n #endif\n@@ -616,13 +616,13 @@ rte_sched_port_config_pipe_profile_table(struct rte_sched_port *port,\n \t\trte_sched_port_log_pipe_profile(port, i);\n \t}\n \n-\tport->pipe_tc3_rate_max = 0;\n+\tport->pipe_tc_be_rate_max = 0;\n \tfor (i = 0; i < port->n_pipe_profiles; i++) {\n \t\tstruct rte_sched_pipe_params *src = params->pipe_profiles + i;\n-\t\tuint32_t pipe_tc3_rate = src->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n+\t\tuint32_t pipe_tc_be_rate = src->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n \n-\t\tif (port->pipe_tc3_rate_max < pipe_tc3_rate)\n-\t\t\tport->pipe_tc3_rate_max = pipe_tc3_rate;\n+\t\tif (port->pipe_tc_be_rate_max < pipe_tc_be_rate)\n+\t\t\tport->pipe_tc_be_rate_max = pipe_tc_be_rate;\n \t}\n }\n \n@@ -890,7 +890,7 @@ rte_sched_subport_config(struct rte_sched_port *port,\n \t/* TC oversubscription */\n \ts->tc_ov_wm_min = port->mtu;\n \ts->tc_ov_wm_max = rte_sched_time_ms_to_bytes(params->tc_period,\n-\t\t\t\t\t\t port->pipe_tc3_rate_max);\n+\t\t\t\t\t\t port->pipe_tc_be_rate_max);\n \ts->tc_ov_wm = s->tc_ov_wm_max;\n \ts->tc_ov_period_id = 0;\n \ts->tc_ov = 0;\n@@ -937,21 +937,21 @@ rte_sched_pipe_config(struct rte_sched_port *port,\n \t\tparams = port->pipe_profiles + p->profile;\n \n #ifdef RTE_SCHED_SUBPORT_TC_OV\n-\t\tdouble subport_tc3_rate = (double) s->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n+\t\tdouble subport_tc_be_rate = (double) s->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) s->tc_period;\n-\t\tdouble pipe_tc3_rate = (double) params->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n+\t\tdouble pipe_tc_be_rate = (double) params->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) params->tc_period;\n-\t\tuint32_t tc3_ov = s->tc_ov;\n+\t\tuint32_t tc_be_ov = s->tc_ov;\n \n \t\t/* Unplug pipe from its subport */\n \t\ts->tc_ov_n -= params->tc_ov_weight;\n-\t\ts->tc_ov_rate -= pipe_tc3_rate;\n-\t\ts->tc_ov = s->tc_ov_rate > subport_tc3_rate;\n+\t\ts->tc_ov_rate -= pipe_tc_be_rate;\n+\t\ts->tc_ov = s->tc_ov_rate > subport_tc_be_rate;\n \n-\t\tif (s->tc_ov != tc3_ov) {\n+\t\tif (s->tc_ov != tc_be_ov) {\n \t\t\tRTE_LOG(DEBUG, SCHED,\n-\t\t\t\t\"Subport %u TC3 oversubscription is OFF (%.4lf >= %.4lf)\\n\",\n-\t\t\t\tsubport_id, subport_tc3_rate, s->tc_ov_rate);\n+\t\t\t\t\"Subport %u Best effort TC oversubscription is OFF (%.4lf >= %.4lf)\\n\",\n+\t\t\t\tsubport_id, subport_tc_be_rate, s->tc_ov_rate);\n \t\t}\n #endif\n \n@@ -980,22 +980,22 @@ rte_sched_pipe_config(struct rte_sched_port *port,\n #ifdef RTE_SCHED_SUBPORT_TC_OV\n \t{\n \t\t/* Subport TC3 oversubscription */\n-\t\tdouble subport_tc3_rate =\n+\t\tdouble subport_tc_be_rate =\n \t\t\t(double) s->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) s->tc_period;\n-\t\tdouble pipe_tc3_rate =\n+\t\tdouble pipe_tc_be_rate =\n \t\t\t(double) params->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE]\n \t\t\t/ (double) params->tc_period;\n-\t\tuint32_t tc3_ov = s->tc_ov;\n+\t\tuint32_t tc_be_ov = s->tc_ov;\n \n \t\ts->tc_ov_n += params->tc_ov_weight;\n-\t\ts->tc_ov_rate += pipe_tc3_rate;\n-\t\ts->tc_ov = s->tc_ov_rate > subport_tc3_rate;\n+\t\ts->tc_ov_rate += pipe_tc_be_rate;\n+\t\ts->tc_ov = s->tc_ov_rate > subport_tc_be_rate;\n \n-\t\tif (s->tc_ov != tc3_ov) {\n+\t\tif (s->tc_ov != tc_be_ov) {\n \t\t\tRTE_LOG(DEBUG, SCHED,\n-\t\t\t\t\"Subport %u TC3 oversubscription is ON (%.4lf < %.4lf)\\n\",\n-\t\t\t\tsubport_id, subport_tc3_rate, s->tc_ov_rate);\n+\t\t\t\t\"Subport %u Best effort TC oversubscription is ON (%.4lf < %.4lf)\\n\",\n+\t\t\t\tsubport_id, subport_tc_be_rate, s->tc_ov_rate);\n \t\t}\n \t\tp->tc_ov_period_id = s->tc_ov_period_id;\n \t\tp->tc_ov_credits = s->tc_ov_wm;\n@@ -1039,8 +1039,8 @@ rte_sched_port_pipe_profile_add(struct rte_sched_port *port,\n \t*pipe_profile_id = port->n_pipe_profiles;\n \tport->n_pipe_profiles++;\n \n-\tif (port->pipe_tc3_rate_max < params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE])\n-\t\tport->pipe_tc3_rate_max = params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n+\tif (port->pipe_tc_be_rate_max < params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE])\n+\t\tport->pipe_tc_be_rate_max = params->tc_rate[RTE_SCHED_TRAFFIC_CLASS_BE];\n \n \trte_sched_port_log_pipe_profile(port, *pipe_profile_id);\n \n", "prefixes": [ "v4", "04/11" ] }