Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 56317,
    "url": "http://patches.dpdk.org/api/patches/56317/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190711022235.2958-1-tyos@jp.ibm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190711022235.2958-1-tyos@jp.ibm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190711022235.2958-1-tyos@jp.ibm.com",
    "date": "2019-07-11T02:22:35",
    "name": "vfio: fix build errors on old Linux",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "1409e4827b73ecc1c9899e22d3021dd9a96039bd",
    "submitter": {
        "id": 1099,
        "url": "http://patches.dpdk.org/api/people/1099/?format=api",
        "name": "Takeshi Yoshimura",
        "email": "tyos@jp.ibm.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190711022235.2958-1-tyos@jp.ibm.com/mbox/",
    "series": [
        {
            "id": 5444,
            "url": "http://patches.dpdk.org/api/series/5444/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5444",
            "date": "2019-07-11T02:22:35",
            "name": "vfio: fix build errors on old Linux",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/5444/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/56317/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/56317/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE62D2E81;\n\tThu, 11 Jul 2019 04:23:09 +0200 (CEST)",
            "from ns601-vm9.bullet.mail.ssk.yahoo.co.jp\n\t(ns601-vm9.bullet.mail.ssk.yahoo.co.jp [182.22.91.58])\n\tby dpdk.org (Postfix) with SMTP id 6A6BE2C6A\n\tfor <dev@dpdk.org>; Thu, 11 Jul 2019 04:23:06 +0200 (CEST)",
            "from [182.22.66.104] by ns601.bullet.mail.ssk.yahoo.co.jp with\n\tNNFMP; 11 Jul 2019 02:23:05 -0000",
            "from [182.22.91.128] by t602.bullet.mail.ssk.yahoo.co.jp with\n\tNNFMP; 11 Jul 2019 02:23:05 -0000",
            "from [127.0.0.1] by omp601.mail.ssk.yahoo.co.jp with NNFMP;\n\t11 Jul 2019 02:23:05 -0000",
            "(qmail 75823 invoked by alias); 11 Jul 2019 02:23:05 -0000",
            "from unknown (HELO localhost.localdomain) (38.119.166.65 with )\n\tby ymobsmtp6006.mail.ssk.ynwp.yahoo.co.jp with SMTP;\n\t11 Jul 2019 02:23:04 -0000"
        ],
        "X-Yahoo-Newman-Property": "ymail-5",
        "X-Yahoo-Newman-Id": "57677.67304.bm@omp601.mail.ssk.yahoo.co.jp",
        "X-YMail-JAS": "VtF8PL0VM1lO3mwISsZuyFADEcJ6JojoO0GEE9YGNtNtZi22TrLCMDragQvIYydB1lQLRjMQVtnWRb_QLuDQ8mMExMoVCsM_IvpIzJCfQg0Zb6WvveS78ZPO0jkTGXqmkExPmtt2S4cJs4c-",
        "X-Apparently-From": "<endliner2000@yahoo.co.jp>",
        "X-YMail-OSG": "wk6j18EVM1lfriJHDXc3eZGnGEvdT_yyivDPPHm4T93VaE6\n\txPaqZn001W16KEyZ1dtA8HquL0u_a_GxG6VRH18u3BhebfpQ3IscP1yAMCKU\n\tyI_N4C3p2A0Jp0ZjDhaiaMoaocLjtZl7DXzYfW4f9ir6DTP8.xaR99QJFZUu\n\tM073AdpuIe1h4e9P2FsjZhUbKPAfIz3WNEl1GkU5oo0OIorKq.OEbQiXn4QC\n\teuYb1gEqU6OCcFYy2VrF7hIHhS4fXvHiQRzh4SBrIwaTL.E_kQ2r.VkD9PtK\n\tzveAOGMQlIWIsAk84dcXdKiH3h7wEqZPvoSnKl3uoWdeRfS5QqytWkxOArrB\n\t.RsG4hB2Qi8r_KyfHe4DpOvcaF91Y9FfGpY9i60Tf_xZAXVamHYWQeRkfSn0\n\tPiRe7owDoYjlgzvWaxOSAGV_hkwg3URB50j3Lo8a_O8weUq3h1jDhLoxt1jR\n\tKgUcNWSvQaiq4EmkzGXrCcatKlOr8dgBr37NmbqJIimcDxsURft85dkU6keI\n\tdXa8RkkzdQ7nwmUa97QJCxhB2gCU7A.K2dxpC_TH5eIk2Qt5NybTFXqI5Ayo\n\tKbR6gBs3yCk77GITiintE_5GMfiQC4OF.uTcMwf.R0rIekt9fN33Rsi7nZkJ\n\t3uuimlGH_7mgluWjWBKWh8R67sbq26ozaYWchoP4WGEDtUGPwfEmqdK5oBT5\n\tUrRK1RRBi76vx3gOeSQVsTCeHM5if67a1",
        "From": "Takeshi Yoshimura <tyos@jp.ibm.com>",
        "To": "dev@dpdk.org",
        "Cc": "Burakov@dpdk.org, Anatoly <anatoly.burakov@intel.com>,\n\tThomas Monjalon <thomas@monjalon.net>,\n\tDavid Christensen <drc@linux.vnet.ibm.com>,\n\tTakeshi Yoshimura <tyos@jp.ibm.com>",
        "Date": "Wed, 10 Jul 2019 19:22:35 -0700",
        "Message-Id": "<20190711022235.2958-1-tyos@jp.ibm.com>",
        "X-Mailer": "git-send-email 2.17.2 (Apple Git-113)",
        "Subject": "[dpdk-dev] [PATCH] vfio: fix build errors on old Linux",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The commit db90b4969e2e (\"vfio: retry creating sPAPR DMA window\")\nintroduced a build breakage on old Linux. Linux <4.2 does not define ddw in\nstruct vfio_iommu_spapr_tce_info. Without ddw, we cannot change window size\nand so should give up the creation. I just exculuded the retrying code if\nddw is not supported.\n\nFixes: db90b4969e2e (\"vfio: retry creating sPAPR DMA window\")\n\nSigned-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>\n---\n lib/librte_eal/linux/eal/eal_vfio.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c\nindex 7053ebe7d..fadef427f 100644\n--- a/lib/librte_eal/linux/eal/eal_vfio.c\n+++ b/lib/librte_eal/linux/eal/eal_vfio.c\n@@ -1445,6 +1445,7 @@ vfio_spapr_create_new_dma_window(int vfio_container_fd,\n \t/* create new DMA window */\n \tret = ioctl(vfio_container_fd, VFIO_IOMMU_SPAPR_TCE_CREATE, create);\n \tif (ret) {\n+#ifdef VFIO_IOMMU_SPAPR_INFO_DDW\n \t\t/* try possible page_shift and levels for workaround */\n \t\tuint32_t levels;\n \n@@ -1463,6 +1464,7 @@ vfio_spapr_create_new_dma_window(int vfio_container_fd,\n \t\t\tif (!ret)\n \t\t\t\tbreak;\n \t\t}\n+#endif\n \t\tif (ret) {\n \t\t\tRTE_LOG(ERR, EAL, \"  cannot create new DMA window, \"\n \t\t\t\t\t\"error %i (%s)\\n\", errno, strerror(errno));\n",
    "prefixes": []
}