Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56192/?format=api
{ "id": 56192, "url": "http://patches.dpdk.org/api/patches/56192/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/cac65ccbd3ecddda378670bb55c57af9fd56b053.1562347546.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cac65ccbd3ecddda378670bb55c57af9fd56b053.1562347546.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cac65ccbd3ecddda378670bb55c57af9fd56b053.1562347546.git.anatoly.burakov@intel.com", "date": "2019-07-05T17:26:24", "name": "[v5,6/9] eal: uninline wait for mcfg complete function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ff4b15114ad59b2a794ef4be30bda9146392c620", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/cac65ccbd3ecddda378670bb55c57af9fd56b053.1562347546.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 5379, "url": "http://patches.dpdk.org/api/series/5379/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5379", "date": "2019-07-05T17:26:18", "name": "Make shared memory config non-public", "version": 5, "mbox": "http://patches.dpdk.org/series/5379/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56192/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56192/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 599E61BE99;\n\tFri, 5 Jul 2019 19:26:53 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 091501BE85\n\tfor <dev@dpdk.org>; Fri, 5 Jul 2019 19:26:45 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jul 2019 10:26:45 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby FMSMGA003.fm.intel.com with ESMTP; 05 Jul 2019 10:26:44 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,455,1557212400\"; d=\"scan'208\";a=\"172723280\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, thomas@monjalon.net,\n\tdavid.marchand@redhat.com, stephen@networkplumber.org", "Date": "Fri, 5 Jul 2019 18:26:24 +0100", "Message-Id": "<cac65ccbd3ecddda378670bb55c57af9fd56b053.1562347546.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1562347546.git.anatoly.burakov@intel.com>", "<cover.1562347546.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1562347546.git.anatoly.burakov@intel.com>", "<cover.1562332112.git.anatoly.burakov@intel.com>\n\t<cover.1562347546.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v5 6/9] eal: uninline wait for mcfg complete\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, the function to wait until config completion is\nstatic inline for no reason. Move its implementation to\nan EAL common file.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_eal/common/eal_common_mcfg.c | 10 ++++++++++\n lib/librte_eal/common/eal_memcfg.h | 10 +++-------\n lib/librte_eal/freebsd/eal/eal.c | 3 ++-\n lib/librte_eal/linux/eal/eal.c | 2 +-\n 4 files changed, 16 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_mcfg.c b/lib/librte_eal/common/eal_common_mcfg.c\nindex 337890a61..30969c6bf 100644\n--- a/lib/librte_eal/common/eal_common_mcfg.c\n+++ b/lib/librte_eal/common/eal_common_mcfg.c\n@@ -7,6 +7,16 @@\n \n #include \"eal_memcfg.h\"\n \n+void\n+eal_mcfg_wait_complete(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\n+\t/* wait until shared mem_config finish initialising */\n+\twhile (mcfg->magic != RTE_MAGIC)\n+\t\trte_pause();\n+}\n+\n void\n rte_mcfg_mem_read_lock(void)\n {\ndiff --git a/lib/librte_eal/common/eal_memcfg.h b/lib/librte_eal/common/eal_memcfg.h\nindex e5b90e31d..6c08652fe 100644\n--- a/lib/librte_eal/common/eal_memcfg.h\n+++ b/lib/librte_eal/common/eal_memcfg.h\n@@ -69,12 +69,8 @@ struct rte_mem_config {\n \tuint8_t dma_maskbits; /**< Keeps the more restricted dma mask. */\n };\n \n-static inline void\n-rte_eal_mcfg_wait_complete(struct rte_mem_config *mcfg)\n-{\n-\t/* wait until shared mem_config finish initialising */\n-\twhile (mcfg->magic != RTE_MAGIC)\n-\t\trte_pause();\n-}\n+/* wait until primary process initialization is complete */\n+void\n+eal_mcfg_wait_complete(void);\n \n #endif /* EAL_MEMCFG_H */\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex 71ba380e0..78022f68a 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -52,6 +52,7 @@\n #include \"eal_filesystem.h\"\n #include \"eal_hugepages.h\"\n #include \"eal_options.h\"\n+#include \"eal_memcfg.h\"\n \n #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)\n \n@@ -382,7 +383,7 @@ rte_config_init(void)\n \tcase RTE_PROC_SECONDARY:\n \t\tif (rte_eal_config_attach() < 0)\n \t\t\treturn -1;\n-\t\trte_eal_mcfg_wait_complete(rte_config.mem_config);\n+\t\teal_mcfg_wait_complete();\n \t\tif (rte_eal_config_reattach() < 0)\n \t\t\treturn -1;\n \t\tbreak;\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex f974cec1c..561a4f3f3 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -506,7 +506,7 @@ rte_config_init(void)\n \tcase RTE_PROC_SECONDARY:\n \t\tif (rte_eal_config_attach() < 0)\n \t\t\treturn -1;\n-\t\trte_eal_mcfg_wait_complete(rte_config.mem_config);\n+\t\teal_mcfg_wait_complete();\n \t\tif (rte_eal_config_reattach() < 0)\n \t\t\treturn -1;\n \t\teal_update_internal_config();\n", "prefixes": [ "v5", "6/9" ] }