Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56172/?format=api
{ "id": 56172, "url": "http://patches.dpdk.org/api/patches/56172/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190705171626.13448-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190705171626.13448-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190705171626.13448-2-stephen@networkplumber.org", "date": "2019-07-05T17:16:16", "name": "[v8,01/11] net/ether: deinline non-critical functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a2a7ae297612f38cd251f4521af639f9f87724ae", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190705171626.13448-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 5376, "url": "http://patches.dpdk.org/api/series/5376/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5376", "date": "2019-07-05T17:16:15", "name": "ether: improvements and optimizations", "version": 8, "mbox": "http://patches.dpdk.org/series/5376/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56172/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56172/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CEF521BE1B;\n\tFri, 5 Jul 2019 19:16:39 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 8D1151BDF1\n\tfor <dev@dpdk.org>; Fri, 5 Jul 2019 19:16:36 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id p184so4571509pfp.7\n\tfor <dev@dpdk.org>; Fri, 05 Jul 2019 10:16:36 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t21sm8991014pjh.25.2019.07.05.10.16.34\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tFri, 05 Jul 2019 10:16:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=/p8EL3C6Wse7N0Loz1qhcs5fm4pxbB+kaNXMKFNLfIU=;\n\tb=zO4NHqgaVSeF/f0KBAcxeIl8Ama3vHw83HcxI1+WuktqHarG+exs4EKm0CVUBaJiyl\n\tdPKgD5pcNVmdM5OXsj5rs9fMLECMZRB2255+Y/TNtyVSsdRqQEc/Nhrp4eLs1IOCh6Ib\n\t1ft6Q+zmMw6Qi4ti3VyWGALo8NS/PgxWpVu4fdWIEGwSFMkJDLfh3/zS3STFpfot9MgO\n\taKlgWAmxINHO32CJlC+nVpWCBxWHIAxMUBrRmfagrbo/JnWe72BwI5RnBCVVf9bHq2Ve\n\tuGxsE34nbyW+mU1daSpNL8AMYrRQkyKiCsSbUM0F2kmI9/Gijg238wyBv1Qz7rntGCce\n\t1IFA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=/p8EL3C6Wse7N0Loz1qhcs5fm4pxbB+kaNXMKFNLfIU=;\n\tb=oMlIMpGwicjmYXMHRi+KncJQs4rkMxcXzTurJqrr7en9QnD1ur/7oZfIxqed5aLRnU\n\tar1OIO+gHw/4tSvAlL7/bldx2ujB3swtdnIZI8BIiQYuEjQdxXm7DWqAQsgrsPvfdtnv\n\tnRVLCKM1NU2wuqq9qSeza+twhEU/UBbtruSg8bXQI85T2KHyk6Ess6wwHqjUg+HHeAtn\n\tryzExWI/L45kg6cPbGCGYsfX1OWrU6MF5xonS06vbbd0gKmV4GK8o7yRiw01EEJUbnNR\n\ts8MaJrGY7sLKM8R7toBgziddrRytVa1cW/q0n8lZ7zwe29+FO/EUkCOyOmOSolqxFvY6\n\tyGJA==", "X-Gm-Message-State": "APjAAAXwD0N9Kk0ZqEee4A0hQ7iXCxIHjvq5xk9Di/ZeapDPmLkLPq1b\n\tKiipNc66k1f2ohtol+Z6N5xi0y+kUJw=", "X-Google-Smtp-Source": "APXvYqxxrnCHew0Qn+NtfKY8hlAxe0ZJtNuBZGUSBiNtEU7KnVm+U+iRy4VbU4W2xfYBK/RTKTXVdQ==", "X-Received": "by 2002:a17:90a:cf0d:: with SMTP id\n\th13mr6821216pju.63.1562346995493; \n\tFri, 05 Jul 2019 10:16:35 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tRami Rosen <ramirose@gmail.com>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>,\n\tOlivier Matz <olivier.matz@6wind.com>", "Date": "Fri, 5 Jul 2019 10:16:16 -0700", "Message-Id": "<20190705171626.13448-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190705171626.13448-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190705171626.13448-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v8 01/11] net/ether: deinline non-critical\n\tfunctions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Formatting Ethernet address and getting a random value are\nnot in critical path so they should not be inlined.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by: Rami Rosen <ramirose@gmail.com>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\nAcked-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/axgbe/Makefile | 2 +-\n drivers/net/memif/Makefile | 2 +-\n lib/librte_net/Makefile | 1 +\n lib/librte_net/meson.build | 2 +-\n lib/librte_net/rte_ether.c | 29 +++++++++++++++++++++++++++++\n lib/librte_net/rte_ether.h | 25 ++++---------------------\n lib/librte_net/rte_net_version.map | 7 +++++++\n 7 files changed, 44 insertions(+), 24 deletions(-)\n create mode 100644 lib/librte_net/rte_ether.c", "diff": "diff --git a/drivers/net/axgbe/Makefile b/drivers/net/axgbe/Makefile\nindex 72215aedaf55..c2d4336800c0 100644\n--- a/drivers/net/axgbe/Makefile\n+++ b/drivers/net/axgbe/Makefile\n@@ -17,7 +17,7 @@ LIBABIVER := 1\n \n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool\n LDLIBS += -lrte_pci -lrte_bus_pci\n-LDLIBS += -lrte_ethdev\n+LDLIBS += -lrte_ethdev -lrte_net\n \n #\n # all source are stored in SRCS-y\ndiff --git a/drivers/net/memif/Makefile b/drivers/net/memif/Makefile\nindex fdbdf3378019..3d92b08f259b 100644\n--- a/drivers/net/memif/Makefile\n+++ b/drivers/net/memif/Makefile\n@@ -21,7 +21,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API\n # - rte_mp_reply\n # - rte_mp_request_sync\n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool\n-LDLIBS += -lrte_ethdev -lrte_kvargs\n+LDLIBS += -lrte_ethdev -lrte_kvargs -lrte_net\n LDLIBS += -lrte_hash\n LDLIBS += -lrte_bus_vdev\n \ndiff --git a/lib/librte_net/Makefile b/lib/librte_net/Makefile\nindex c3082069ab50..1244c9fd54c9 100644\n--- a/lib/librte_net/Makefile\n+++ b/lib/librte_net/Makefile\n@@ -14,6 +14,7 @@ LIBABIVER := 1\n \n SRCS-$(CONFIG_RTE_LIBRTE_NET) := rte_net.c\n SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_net_crc.c\n+SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_ether.c\n SRCS-$(CONFIG_RTE_LIBRTE_NET) += rte_arp.c\n \n # install includes\ndiff --git a/lib/librte_net/meson.build b/lib/librte_net/meson.build\nindex 7d66f693cbf3..868a93fd6b6b 100644\n--- a/lib/librte_net/meson.build\n+++ b/lib/librte_net/meson.build\n@@ -16,5 +16,5 @@ headers = files('rte_ip.h',\n \t'rte_net_crc.h',\n \t'rte_mpls.h')\n \n-sources = files('rte_arp.c', 'rte_net.c', 'rte_net_crc.c')\n+sources = files('rte_arp.c', 'rte_ether.c', 'rte_net.c', 'rte_net_crc.c')\n deps += ['mbuf']\ndiff --git a/lib/librte_net/rte_ether.c b/lib/librte_net/rte_ether.c\nnew file mode 100644\nindex 000000000000..974fe815b335\n--- /dev/null\n+++ b/lib/librte_net/rte_ether.c\n@@ -0,0 +1,29 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2010-2014 Intel Corporation\n+ */\n+\n+#include <rte_ether.h>\n+\n+void\n+rte_eth_random_addr(uint8_t *addr)\n+{\n+\tuint64_t rand = rte_rand();\n+\tuint8_t *p = (uint8_t *)&rand;\n+\n+\trte_memcpy(addr, p, RTE_ETHER_ADDR_LEN);\n+\taddr[0] &= (uint8_t)~RTE_ETHER_GROUP_ADDR;\t/* clear multicast bit */\n+\taddr[0] |= RTE_ETHER_LOCAL_ADMIN_ADDR;\t/* set local assignment bit */\n+}\n+\n+void\n+rte_ether_format_addr(char *buf, uint16_t size,\n+\t\t const struct rte_ether_addr *eth_addr)\n+{\n+\tsnprintf(buf, size, \"%02X:%02X:%02X:%02X:%02X:%02X\",\n+\t\t eth_addr->addr_bytes[0],\n+\t\t eth_addr->addr_bytes[1],\n+\t\t eth_addr->addr_bytes[2],\n+\t\t eth_addr->addr_bytes[3],\n+\t\t eth_addr->addr_bytes[4],\n+\t\t eth_addr->addr_bytes[5]);\n+}\ndiff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex 1868cb7077d2..df1a51462a37 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -207,15 +207,8 @@ static inline int rte_is_valid_assigned_ether_addr(const struct rte_ether_addr *\n * @param addr\n * A pointer to Ethernet address.\n */\n-static inline void rte_eth_random_addr(uint8_t *addr)\n-{\n-\tuint64_t rand = rte_rand();\n-\tuint8_t *p = (uint8_t *)&rand;\n-\n-\trte_memcpy(addr, p, RTE_ETHER_ADDR_LEN);\n-\taddr[0] &= (uint8_t)~RTE_ETHER_GROUP_ADDR; /* clear multicast bit */\n-\taddr[0] |= RTE_ETHER_LOCAL_ADMIN_ADDR; /* set local assignment bit */\n-}\n+void\n+rte_eth_random_addr(uint8_t *addr);\n \n /**\n * Fast copy an Ethernet address.\n@@ -254,19 +247,9 @@ static inline void rte_ether_addr_copy(const struct rte_ether_addr *ea_from,\n * @param eth_addr\n * A pointer to a ether_addr structure.\n */\n-static inline void\n+void\n rte_ether_format_addr(char *buf, uint16_t size,\n-\t\t const struct rte_ether_addr *eth_addr)\n-{\n-\tsnprintf(buf, size, \"%02X:%02X:%02X:%02X:%02X:%02X\",\n-\t\t eth_addr->addr_bytes[0],\n-\t\t eth_addr->addr_bytes[1],\n-\t\t eth_addr->addr_bytes[2],\n-\t\t eth_addr->addr_bytes[3],\n-\t\t eth_addr->addr_bytes[4],\n-\t\t eth_addr->addr_bytes[5]);\n-}\n-\n+\t\t const struct rte_ether_addr *eth_addr);\n /**\n * Ethernet header: Contains the destination address, source address\n * and frame type.\ndiff --git a/lib/librte_net/rte_net_version.map b/lib/librte_net/rte_net_version.map\nindex 26c06e7c7ae7..f1e1b84ab491 100644\n--- a/lib/librte_net/rte_net_version.map\n+++ b/lib/librte_net/rte_net_version.map\n@@ -13,6 +13,13 @@ DPDK_17.05 {\n \n } DPDK_16.11;\n \n+DPDK_19.08 {\n+\tglobal:\n+\n+\trte_eth_random_addr;\n+\trte_ether_format_addr;\n+} DPDK_17.05;\n+\n EXPERIMENTAL {\n \tglobal:\n \n", "prefixes": [ "v8", "01/11" ] }