Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56081/?format=api
{ "id": 56081, "url": "http://patches.dpdk.org/api/patches/56081/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1562238988-13138-1-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1562238988-13138-1-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1562238988-13138-1-git-send-email-viacheslavo@mellanox.com", "date": "2019-07-04T11:16:28", "name": "[v2] net/mlx5: zero out UDP csum for IPv6 encap headers", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3d6c9fbfd0b02f54373bf006a4d9ee3d7de304de", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 3268, "url": "http://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1562238988-13138-1-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 5337, "url": "http://patches.dpdk.org/api/series/5337/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5337", "date": "2019-07-04T11:16:28", "name": "[v2] net/mlx5: zero out UDP csum for IPv6 encap headers", "version": 2, "mbox": "http://patches.dpdk.org/series/5337/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56081/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56081/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 661671BDFD;\n\tThu, 4 Jul 2019 13:16:39 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 3B2701BDFA\n\tfor <dev@dpdk.org>; Thu, 4 Jul 2019 13:16:38 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 4 Jul 2019 14:16:30 +0300", "from pegasus12.mtr.labs.mlnx. (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x64BGUYg027647;\n\tThu, 4 Jul 2019 14:16:30 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "rasland@mellanox.com, Eli Britstein <elibr@mellanox.com>", "Date": "Thu, 4 Jul 2019 11:16:28 +0000", "Message-Id": "<1562238988-13138-1-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH v2] net/mlx5: zero out UDP csum for IPv6 encap\n\theaders", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Eli Britstein <elibr@mellanox.com>\n\nMellanox NICs do not support UDP checksum hardware tx offload over IPv6.\nThis limitation becomes critical for UDP based tunnels like VXLAN.\nBeside the UDP checksum validity is required by IPv6 there is an option\nin Linux to allow accepting UDP zero sum (see udp6zerocsumrx in iproute2\npackage).\n\nThis patch zeroes out the UDP checksum field for encapsulation headers\nin raw encap action.\n\nSigned-off-by: Eli Britstein <elibr@mellanox.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 46 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 46 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 933ad0b..0e6d17d 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -1362,6 +1362,50 @@ struct field_modify_info modify_tcp[] = {\n \treturn 0;\n }\n \n+static int\n+flow_dv_zero_encap_udp_csum(void *data, struct rte_flow_error *error)\n+{\n+\tstruct rte_ether_hdr *eth = NULL;\n+\tstruct rte_vlan_hdr *vlan = NULL;\n+\tstruct rte_ipv6_hdr *ipv6 = NULL;\n+\tstruct rte_udp_hdr *udp = NULL;\n+\tchar *next_hdr;\n+\tuint16_t proto;\n+\n+\teth = (struct rte_ether_hdr *)data;\n+\tnext_hdr = (char *)(eth + 1);\n+\tproto = RTE_BE16(eth->ether_type);\n+\n+\t/* VLAN skipping */\n+\twhile (proto == RTE_ETHER_TYPE_VLAN || proto == RTE_ETHER_TYPE_QINQ) {\n+\t\tnext_hdr += sizeof(struct rte_vlan_hdr);\n+\t\tvlan = (struct rte_vlan_hdr *)next_hdr;\n+\t\tproto = RTE_BE16(vlan->eth_proto);\n+\t}\n+\n+\t/* HW calculates IPv4 csum. no need to proceed */\n+\tif (proto == RTE_ETHER_TYPE_IPV4)\n+\t\treturn 0;\n+\n+\t/* non IPv4/IPv6 header. not supported */\n+\tif (proto != RTE_ETHER_TYPE_IPV6) {\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION,\n+\t\t\t\t\t NULL, \"Cannot offload non IPv4/IPv6\");\n+\t}\n+\n+\tipv6 = (struct rte_ipv6_hdr *)next_hdr;\n+\n+\t/* ignore non UDP */\n+\tif (ipv6->proto != IPPROTO_UDP)\n+\t\treturn 0;\n+\n+\tudp = (struct rte_udp_hdr *)(ipv6 + 1);\n+\tudp->dgram_cksum = 0;\n+\n+\treturn 0;\n+}\n+\n /**\n * Convert L2 encap action to DV specification.\n *\n@@ -1400,6 +1444,8 @@ struct field_modify_info modify_tcp[] = {\n \t\t\t(const struct rte_flow_action_raw_encap *)action->conf;\n \t\tres.size = raw_encap_data->size;\n \t\tmemcpy(res.buf, raw_encap_data->data, res.size);\n+\t\tif (flow_dv_zero_encap_udp_csum(res.buf, error))\n+\t\t\treturn -rte_errno;\n \t} else {\n \t\tif (action->type == RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP)\n \t\t\tencap_data =\n", "prefixes": [ "v2" ] }