Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56077/?format=api
{ "id": 56077, "url": "http://patches.dpdk.org/api/patches/56077/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1562234612-631-4-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1562234612-631-4-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1562234612-631-4-git-send-email-arybchenko@solarflare.com", "date": "2019-07-04T10:03:32", "name": "[3/3] event/opdl: fix to set positive rte_errno", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4edab8c2ca13a6ed645afad501a81623eb26f3fc", "submitter": { "id": 607, "url": "http://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1562234612-631-4-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 5335, "url": "http://patches.dpdk.org/api/series/5335/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5335", "date": "2019-07-04T10:03:29", "name": "eventdev fixes to set positive rte_errno", "version": 1, "mbox": "http://patches.dpdk.org/series/5335/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56077/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56077/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A47C71BDE4;\n\tThu, 4 Jul 2019 12:04:07 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9F17D1BDF3;\n\tThu, 4 Jul 2019 12:04:05 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n\tBBAB99C0066; Thu, 4 Jul 2019 10:04:04 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 4 Jul 2019 03:04:02 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 4 Jul 2019 03:04:01 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx64A40cX021421; Thu, 4 Jul 2019 11:04:00 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t959411613C2; Thu, 4 Jul 2019 11:04:00 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Jerin Jacob <jerinj@marvell.com>, Liang Ma <liang.j.ma@intel.com>, \"Peter\n\tMccarthy\" <peter.mccarthy@intel.com>", "CC": "<dev@dpdk.org>, Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>,\n\t<stable@dpdk.org>", "Date": "Thu, 4 Jul 2019 11:03:32 +0100", "Message-ID": "<1562234612-631-4-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1562234612-631-1-git-send-email-arybchenko@solarflare.com>", "References": "<1562234612-631-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24738.005", "X-TM-AS-Result": "No-7.383800-4.000000-10", "X-TMASE-MatchedRID": "p9rK+f8v5s+mnG2tP+vqUW6HurDH4PpP9teeW6UfkyB0+P0tQGP+S51b\n\tYL8THayD6eCSFghTVfiaYG6s7Uku2+O3C1C2ZcTlnFVnNmvv47tLXPA26IG0hN9RlPzeVuQQXmr\n\tnY1Xus+2HUUm9FGrCb3FypV9HM4SoCyoWuBSi9xXHmyDJSEsI2805KBm2/UMhmyiLZetSf8mfop\n\t0ytGwvXiq2rl3dzGQ1HyQ+JiGcJ0z/ITeMF4QpX3OrmhMVxztXYGX7BITnTWCeD+VpjsfJ6Q==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--7.383800-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24738.005", "X-MDID": "1562234645-IqDWJVzBYrnF", "Subject": "[dpdk-dev] [PATCH 3/3] event/opdl: fix to set positive rte_errno", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>\n\nFixes: 0bf298e39286 (\"event/opdl: add event port config get/set\")\nFixes: 3c7f3dcfb099 (\"event/opdl: add PMD main body and helper function\")\nFixes: 4236ce9bf5bf (\"event/opdl: add OPDL ring infrastructure library\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dilshod Urazov <Dilshod.Urazov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/event/opdl/opdl_evdev.c | 10 +++++-----\n drivers/event/opdl/opdl_evdev_init.c | 12 ++++++------\n drivers/event/opdl/opdl_ring.c | 2 +-\n 3 files changed, 12 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c\nindex d2d2be4..3beca89 100644\n--- a/drivers/event/opdl/opdl_evdev.c\n+++ b/drivers/event/opdl/opdl_evdev.c\n@@ -102,7 +102,7 @@\n \t\t\t dev->data->dev_id,\n \t\t\t\tqueues[0],\n \t\t\t\tp->id);\n-\t\trte_errno = -EINVAL;\n+\t\trte_errno = EINVAL;\n \t\treturn 0;\n \t}\n \n@@ -113,7 +113,7 @@\n \t\t\t dev->data->dev_id,\n \t\t\t\tnum,\n \t\t\t\tp->id);\n-\t\trte_errno = -EDQUOT;\n+\t\trte_errno = EDQUOT;\n \t\treturn 0;\n \t}\n \n@@ -123,7 +123,7 @@\n \t\t\t dev->data->dev_id,\n \t\t\t\tp->id,\n \t\t\t\tqueues[0]);\n-\t\trte_errno = -EINVAL;\n+\t\trte_errno = EINVAL;\n \t\treturn 0;\n \t}\n \n@@ -134,7 +134,7 @@\n \t\t\t\tp->id,\n \t\t\t\tp->external_qid,\n \t\t\t\tqueues[0]);\n-\t\trte_errno = -EINVAL;\n+\t\trte_errno = EINVAL;\n \t\treturn 0;\n \t}\n \n@@ -160,7 +160,7 @@\n \t\t\t dev->data->dev_id,\n \t\t\t queues[0],\n \t\t\t p->id);\n-\t\trte_errno = -EINVAL;\n+\t\trte_errno = EINVAL;\n \t\treturn 0;\n \t}\n \tRTE_SET_USED(nb_unlinks);\ndiff --git a/drivers/event/opdl/opdl_evdev_init.c b/drivers/event/opdl/opdl_evdev_init.c\nindex 582ad69..15aae47 100644\n--- a/drivers/event/opdl/opdl_evdev_init.c\n+++ b/drivers/event/opdl/opdl_evdev_init.c\n@@ -35,7 +35,7 @@\n \t\t\t\t\t p->id,\n \t\t\t\t\t ev[i].queue_id,\n \t\t\t\t\t p->next_external_qid);\n-\t\t\t\trte_errno = -EINVAL;\n+\t\t\t\trte_errno = EINVAL;\n \t\t\t\treturn 0;\n \t\t\t}\n \t\t}\n@@ -63,7 +63,7 @@\n \t} else {\n \t\tif (num > 0 &&\n \t\t\t\tev[0].queue_id != p->next_external_qid) {\n-\t\t\trte_errno = -EINVAL;\n+\t\t\trte_errno = EINVAL;\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -116,7 +116,7 @@\n \tRTE_SET_USED(ev);\n \tRTE_SET_USED(num);\n \n-\trte_errno = -ENOSPC;\n+\trte_errno = ENOSPC;\n \n \treturn 0;\n }\n@@ -145,7 +145,7 @@\n \n \n \tif (enqueued < num)\n-\t\trte_errno = -ENOSPC;\n+\t\trte_errno = ENOSPC;\n \n \treturn enqueued;\n }\n@@ -164,7 +164,7 @@\n \tRTE_SET_USED(ev);\n \tRTE_SET_USED(num);\n \n-\trte_errno = -ENOSPC;\n+\trte_errno = ENOSPC;\n \n \treturn 0;\n }\n@@ -240,7 +240,7 @@\n \t\t\t \"Attempt to dequeue num of events larger than port (%d) max\",\n \t\t\t opdl_pmd_dev_id(p->opdl),\n \t\t\t p->id);\n-\t\trte_errno = -EINVAL;\n+\t\trte_errno = EINVAL;\n \t\treturn 0;\n \t}\n \ndiff --git a/drivers/event/opdl/opdl_ring.c b/drivers/event/opdl/opdl_ring.c\nindex e988f1c..e8b29e2 100644\n--- a/drivers/event/opdl/opdl_ring.c\n+++ b/drivers/event/opdl/opdl_ring.c\n@@ -756,7 +756,7 @@ struct opdl_ring {\n opdl_stage_disclaim(struct opdl_stage *s, uint32_t num_entries, bool block)\n {\n \tif (num_entries != s->num_event) {\n-\t\trte_errno = -EINVAL;\n+\t\trte_errno = EINVAL;\n \t\treturn 0;\n \t}\n \tif (s->threadsafe == false) {\n", "prefixes": [ "3/3" ] }