Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/56051/?format=api
{ "id": 56051, "url": "http://patches.dpdk.org/api/patches/56051/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190703234313.10782-2-rmody@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190703234313.10782-2-rmody@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190703234313.10782-2-rmody@marvell.com", "date": "2019-07-03T23:43:12", "name": "[2/3] net/bnx2x: fix link events polling for SRIOV", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8f81d3f6010d709a01b28dbd4f8dfa21f0a0e4d7", "submitter": { "id": 1211, "url": "http://patches.dpdk.org/api/people/1211/?format=api", "name": "Rasesh Mody", "email": "rmody@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190703234313.10782-2-rmody@marvell.com/mbox/", "series": [ { "id": 5321, "url": "http://patches.dpdk.org/api/series/5321/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5321", "date": "2019-07-03T23:43:11", "name": "[1/3] net/bnx2x: fix read VF id", "version": 1, "mbox": "http://patches.dpdk.org/series/5321/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/56051/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/56051/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7B21E2C2B;\n\tThu, 4 Jul 2019 01:44:12 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 91D052956;\n\tThu, 4 Jul 2019 01:44:10 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx63NfBVJ010160; Wed, 3 Jul 2019 16:44:09 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2tgrv1bd24-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tWed, 03 Jul 2019 16:44:09 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com\n\t(10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tWed, 3 Jul 2019 16:44:08 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Wed, 3 Jul 2019 16:44:08 -0700", "from irv1user08.caveonetworks.com (unknown [10.104.116.105])\n\tby maili.marvell.com (Postfix) with ESMTP id 655713F7041;\n\tWed, 3 Jul 2019 16:44:08 -0700 (PDT)", "(from rmody@localhost)\n\tby irv1user08.caveonetworks.com (8.14.4/8.14.4/Submit) id\n\tx63Ni8a9011796; Wed, 3 Jul 2019 16:44:08 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-type; s=pfpt0818;\n\tbh=Syf5Yx809pFoBbkBurHdd8Q+7Mod1nTjB/5+93F9gYI=; \n\tb=kD7obRkRtLzvlHmApM/mKvL4SWFQBGzTRAa4YByPd/oJHPE/i32IvCNU/daCLAosTRHX\n\tdYF2BmFrEgKEyFTlZoPWSx4+UCfeHlV+UjzeIXRMgUeJB0GKpqn764FvL/LJVQ7Sja9p\n\tthttYUR09Ps9bogjYQ+blzITNNRrdTWY2JFETFfRKMBuB3f4fknlfFyRf7Vc42JYLNZw\n\toQer6UkpDxsvSxuysy80xRDPPtjFklBFNeIbB+exsIHPptTchi7jWefAuV17ZqcgfCub\n\tVuqRW5gcCzin52wYNMj/rw4rwfEDJavbtxjURdWXm81JNJX4QGWHpkAQTRFNx5g3nuI/\n\tIA== ", "X-Authentication-Warning": "irv1user08.caveonetworks.com: rmody set sender to\n\trmody@marvell.com using -f", "From": "Rasesh Mody <rmody@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Rasesh Mody <rmody@marvell.com>, <ferruh.yigit@intel.com>,\n\t<GR-Everest-DPDK-Dev@marvell.com>, <stable@dpdk.org>", "Date": "Wed, 3 Jul 2019 16:43:12 -0700", "Message-ID": "<20190703234313.10782-2-rmody@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20190703234313.10782-1-rmody@marvell.com>", "References": "<20190703234313.10782-1-rmody@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-07-03_06:, , signatures=0", "Subject": "[dpdk-dev] [PATCH 2/3] net/bnx2x: fix link events polling for SRIOV", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We do not need to schedule periodic poll for slowpath link events\nfor SRIOV. The link events are handled by the PF driver.\n\nFixes: 6041aa619f9a (\"net/bnx2x: fix poll link status\")\nCc: stable@dpdk.org\n\nSigned-off-by: Rasesh Mody <rmody@marvell.com>\n---\n drivers/net/bnx2x/bnx2x_ethdev.c | 19 ++++++++++++-------\n 1 file changed, 12 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c\nindex 10b4fdb8e..127811b92 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.c\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.c\n@@ -218,9 +218,12 @@ bnx2x_dev_start(struct rte_eth_dev *dev)\n \tPMD_INIT_FUNC_TRACE(sc);\n \n \t/* start the periodic callout */\n-\tif (atomic_load_acq_long(&sc->periodic_flags) == PERIODIC_STOP) {\n-\t\tbnx2x_periodic_start(dev);\n-\t\tPMD_DRV_LOG(DEBUG, sc, \"Periodic poll re-started\");\n+\tif (IS_PF(sc)) {\n+\t\tif (atomic_load_acq_long(&sc->periodic_flags) ==\n+\t\t PERIODIC_STOP) {\n+\t\t\tbnx2x_periodic_start(dev);\n+\t\t\tPMD_DRV_LOG(DEBUG, sc, \"Periodic poll re-started\");\n+\t\t}\n \t}\n \n \tret = bnx2x_init(sc);\n@@ -258,10 +261,10 @@ bnx2x_dev_stop(struct rte_eth_dev *dev)\n \t\trte_intr_disable(&sc->pci_dev->intr_handle);\n \t\trte_intr_callback_unregister(&sc->pci_dev->intr_handle,\n \t\t\t\tbnx2x_interrupt_handler, (void *)dev);\n-\t}\n \n-\t/* stop the periodic callout */\n-\tbnx2x_periodic_stop(dev);\n+\t\t/* stop the periodic callout */\n+\t\tbnx2x_periodic_stop(dev);\n+\t}\n \n \tret = bnx2x_nic_unload(sc, UNLOAD_NORMAL, FALSE);\n \tif (ret) {\n@@ -680,7 +683,9 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)\n \treturn 0;\n \n out:\n-\tbnx2x_periodic_stop(eth_dev);\n+\tif (IS_PF(sc))\n+\t\tbnx2x_periodic_stop(eth_dev);\n+\n \treturn ret;\n }\n \n", "prefixes": [ "2/3" ] }