Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 55994,
    "url": "http://patches.dpdk.org/api/patches/55994/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1562144316-14687-3-git-send-email-gavin.hu@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1562144316-14687-3-git-send-email-gavin.hu@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1562144316-14687-3-git-send-email-gavin.hu@arm.com",
    "date": "2019-07-03T08:58:33",
    "name": "[RFC,v2,2/5] ticketlock: use new API to reduce contention on aarch64",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9b288cf20da5a5df5fe7afb51cb910512f53fa88",
    "submitter": {
        "id": 1018,
        "url": "http://patches.dpdk.org/api/people/1018/?format=api",
        "name": "Gavin Hu",
        "email": "gavin.hu@arm.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1562144316-14687-3-git-send-email-gavin.hu@arm.com/mbox/",
    "series": [
        {
            "id": 5303,
            "url": "http://patches.dpdk.org/api/series/5303/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5303",
            "date": "2019-07-03T08:58:31",
            "name": "use WFE for locks and ring on aarch64",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/5303/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/55994/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/55994/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8322F1BDFB;\n\tWed,  3 Jul 2019 10:59:01 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id 8A90A1B964\n\tfor <dev@dpdk.org>; Wed,  3 Jul 2019 10:58:56 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1DE6ECFC;\n\tWed,  3 Jul 2019 01:58:56 -0700 (PDT)",
            "from net-arm-thunderx2.shanghai.arm.com\n\t(net-arm-thunderx2.shanghai.arm.com [10.169.40.40])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t5A1E43F718; Wed,  3 Jul 2019 01:58:55 -0700 (PDT)"
        ],
        "From": "Gavin Hu <gavin.hu@arm.com>",
        "To": "dev@dpdk.org",
        "Cc": "nd@arm.com",
        "Date": "Wed,  3 Jul 2019 16:58:33 +0800",
        "Message-Id": "<1562144316-14687-3-git-send-email-gavin.hu@arm.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": [
            "<1562144316-14687-1-git-send-email-gavin.hu@arm.com>",
            "<1561911676-37718-1-git-send-email-gavin.hu@arm.com>"
        ],
        "References": [
            "<1562144316-14687-1-git-send-email-gavin.hu@arm.com>",
            "<1561911676-37718-1-git-send-email-gavin.hu@arm.com>"
        ],
        "Subject": "[dpdk-dev] [RFC v2 2/5] ticketlock: use new API to reduce\n\tcontention on aarch64",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "While using ticket lock, cores repeatedly poll the lock variable.\nThis is replaced by rte_wait_until_equal API.\n\nRunning ticketlock_autotest on ThunderX2, with different numbers of cores\nand depths of rings, 3%~8% performance gains were measured.\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n---\n lib/librte_eal/common/include/generic/rte_ticketlock.h | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/include/generic/rte_ticketlock.h b/lib/librte_eal/common/include/generic/rte_ticketlock.h\nindex 191146f..8fa1f62 100644\n--- a/lib/librte_eal/common/include/generic/rte_ticketlock.h\n+++ b/lib/librte_eal/common/include/generic/rte_ticketlock.h\n@@ -64,8 +64,7 @@ static inline __rte_experimental void\n rte_ticketlock_lock(rte_ticketlock_t *tl)\n {\n \tuint16_t me = __atomic_fetch_add(&tl->s.next, 1, __ATOMIC_RELAXED);\n-\twhile (__atomic_load_n(&tl->s.current, __ATOMIC_ACQUIRE) != me)\n-\t\trte_pause();\n+\trte_wait_until_equal16(&tl->s.current, me, __ATOMIC_ACQUIRE);\n }\n \n /**\n",
    "prefixes": [
        "RFC",
        "v2",
        "2/5"
    ]
}