Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55888/?format=api
{ "id": 55888, "url": "http://patches.dpdk.org/api/patches/55888/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190702144445.12103-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190702144445.12103-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190702144445.12103-5-bruce.richardson@intel.com", "date": "2019-07-02T14:44:44", "name": "[v3,4/5] examples/vdpa: support building from pkg-config info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7285a768c7da1c6fe66e7930d127e51ea84764a4", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190702144445.12103-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 5286, "url": "http://patches.dpdk.org/api/series/5286/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5286", "date": "2019-07-02T14:44:40", "name": "improve building examples", "version": 3, "mbox": "http://patches.dpdk.org/series/5286/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55888/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55888/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EDCA91B9DC;\n\tTue, 2 Jul 2019 16:45:06 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 58F301B9DC\n\tfor <dev@dpdk.org>; Tue, 2 Jul 2019 16:45:05 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jul 2019 07:45:04 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby fmsmga002.fm.intel.com with ESMTP; 02 Jul 2019 07:45:03 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,443,1557212400\"; d=\"scan'208\";a=\"190683453\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bluca@debian.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 2 Jul 2019 15:44:44 +0100", "Message-Id": "<20190702144445.12103-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190702144445.12103-1-bruce.richardson@intel.com>", "References": "<20190517114734.7072-1-bruce.richardson@intel.com>\n\t<20190702144445.12103-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 4/5] examples/vdpa: support building from\n\tpkg-config info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vdpa example app did not check for a libdpdk pkg-config file and\nattempt to build using that. Add support for that method of compile to\nalign the app with the other examples.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n examples/vdpa/Makefile | 51 ++++++++++++++++++++++++++++++++++++------\n 1 file changed, 44 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/vdpa/Makefile b/examples/vdpa/Makefile\nindex ab2bbdf76..734042380 100644\n--- a/examples/vdpa/Makefile\n+++ b/examples/vdpa/Makefile\n@@ -1,6 +1,47 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Intel Corporation\n \n+# binary name\n+APP = vdpa\n+\n+# all source are stored in SRCS-y\n+SRCS-y := main.c\n+CFLAGS += -DALLOW_EXPERIMENTAL_API\n+\n+# Build using pkg-config variables if possible\n+$(shell pkg-config --exists libdpdk)\n+ifeq ($(.SHELLSTATUS),0)\n+\n+all: shared\n+.PHONY: shared static\n+shared: build/$(APP)-shared\n+\tln -sf $(APP)-shared build/$(APP)\n+static: build/$(APP)-static\n+\tln -sf $(APP)-static build/$(APP)\n+\n+PKGCONF=pkg-config --define-prefix\n+\n+PC_FILE := $(shell $(PKGCONF) --path libdpdk)\n+CFLAGS += -O3 $(shell $(PKGCONF) --cflags libdpdk)\n+LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)\n+LDFLAGS_STATIC = -Wl,-Bstatic $(shell $(PKGCONF) --static --libs libdpdk)\n+\n+build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)\n+\n+build/$(APP)-static: $(SRCS-y) Makefile $(PC_FILE) | build\n+\t$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_STATIC)\n+\n+build:\n+\t@mkdir -p $@\n+\n+.PHONY: clean\n+clean:\n+\trm -f build/$(APP) build/$(APP)-static build/$(APP)-shared\n+\ttest -d build && rmdir -p build || true\n+\n+else\n+\n ifeq ($(RTE_SDK),)\n $(error \"Please define RTE_SDK environment variable\")\n endif\n@@ -16,12 +57,6 @@ please change the definition of the RTE_TARGET environment variable)\n all:\n else\n \n-# binary name\n-APP = vdpa\n-\n-# all source are stored in SRCS-y\n-SRCS-y := main.c\n-\n CFLAGS += -O2 -D_FILE_OFFSET_BITS=64\n CFLAGS += $(WERROR_FLAGS)\n CFLAGS += -D_GNU_SOURCE\n@@ -29,4 +64,6 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API\n \n include $(RTE_SDK)/mk/rte.extapp.mk\n \n-endif\n+endif # linuxapp\n+\n+endif # pkg-config\n", "prefixes": [ "v3", "4/5" ] }