Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55860/?format=api
{ "id": 55860, "url": "http://patches.dpdk.org/api/patches/55860/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190702095608.20722-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190702095608.20722-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190702095608.20722-3-bruce.richardson@intel.com", "date": "2019-07-02T09:56:07", "name": "[v3,2/3] raw/skeleton: remove compile-time constant for device id", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0f04a700e0ab57be48b74f27bf6b2d2c40b1ab85", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190702095608.20722-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 5275, "url": "http://patches.dpdk.org/api/series/5275/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5275", "date": "2019-07-02T09:56:05", "name": "fixes and improvements for rawdev", "version": 3, "mbox": "http://patches.dpdk.org/series/5275/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55860/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2A72C1B99A;\n\tTue, 2 Jul 2019 11:56:25 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id ABDAB1B994\n\tfor <dev@dpdk.org>; Tue, 2 Jul 2019 11:56:22 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jul 2019 02:56:22 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby fmsmga001.fm.intel.com with ESMTP; 02 Jul 2019 02:56:21 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,442,1557212400\"; d=\"scan'208\";a=\"184471057\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tHemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Tue, 2 Jul 2019 10:56:07 +0100", "Message-Id": "<20190702095608.20722-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190702095608.20722-1-bruce.richardson@intel.com>", "References": "<20190619170802.7691-1-bruce.richardson@intel.com>\n\t<20190702095608.20722-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/3] raw/skeleton: remove compile-time\n\tconstant for device id", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use a variable value rather than compile-time constant zero as the\ndevice id for the skeleton rawdev tests. This ensures we can make the\ntests work even if other rawdevs are present.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n .../skeleton_rawdev/skeleton_rawdev_test.c | 55 ++++++++++---------\n 1 file changed, 28 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c\nindex 3250c2296..a6be99aee 100644\n--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c\n+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c\n@@ -14,7 +14,6 @@\n /* Using relative path as skeleton_rawdev is not part of exported headers */\n #include \"skeleton_rawdev.h\"\n \n-#define TEST_DEV_ID 0\n #define TEST_DEV_NAME \"rawdev_skeleton\"\n \n #define SKELDEV_LOGS(level, fmt, args...) \\\n@@ -37,6 +36,8 @@ static int passed;\n static int failed;\n static int unsupported;\n \n+static uint16_t test_dev_id;\n+\n static int\n testsuite_setup(void)\n {\n@@ -88,7 +89,7 @@ static int\n test_rawdev_socket_id(void)\n {\n \tint socket_id;\n-\tsocket_id = rte_rawdev_socket_id(TEST_DEV_ID);\n+\tsocket_id = rte_rawdev_socket_id(test_dev_id);\n \tRTE_TEST_ASSERT(socket_id != -EINVAL,\n \t\t\t\"Failed to get socket_id %d\", socket_id);\n \tsocket_id = rte_rawdev_socket_id(RTE_RAWDEV_MAX_DEVS);\n@@ -105,12 +106,12 @@ test_rawdev_info_get(void)\n \tstruct rte_rawdev_info rdev_info = {0};\n \tstruct skeleton_rawdev_conf skel_conf = {0};\n \n-\tret = rte_rawdev_info_get(TEST_DEV_ID, NULL);\n+\tret = rte_rawdev_info_get(test_dev_id, NULL);\n \tRTE_TEST_ASSERT(ret == -EINVAL, \"Expected -EINVAL, %d\", ret);\n \n \trdev_info.dev_private = &skel_conf;\n \n-\tret = rte_rawdev_info_get(TEST_DEV_ID, &rdev_info);\n+\tret = rte_rawdev_info_get(test_dev_id, &rdev_info);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to get raw dev info\");\n \n \treturn TEST_SUCCESS;\n@@ -125,7 +126,7 @@ test_rawdev_configure(void)\n \tstruct skeleton_rawdev_conf rdev_conf_get = {0};\n \n \t/* Check invalid configuration */\n-\tret = rte_rawdev_configure(TEST_DEV_ID, NULL);\n+\tret = rte_rawdev_configure(test_dev_id, NULL);\n \tRTE_TEST_ASSERT(ret == -EINVAL,\n \t\t\t\"Null configure; Expected -EINVAL, got %d\", ret);\n \n@@ -135,12 +136,12 @@ test_rawdev_configure(void)\n \t\t\t\t SKELETON_CAPA_FW_RESET;\n \n \trdev_info.dev_private = &rdev_conf_set;\n-\tret = rte_rawdev_configure(TEST_DEV_ID,\n+\tret = rte_rawdev_configure(test_dev_id,\n \t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to configure rawdev (%d)\", ret);\n \n \trdev_info.dev_private = &rdev_conf_get;\n-\tret = rte_rawdev_info_get(TEST_DEV_ID,\n+\tret = rte_rawdev_info_get(test_dev_id,\n \t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n@@ -168,7 +169,7 @@ test_rawdev_queue_default_conf_get(void)\n \n \t/* Get the current configuration */\n \trdev_info.dev_private = &rdev_conf_get;\n-\tret = rte_rawdev_info_get(TEST_DEV_ID,\n+\tret = rte_rawdev_info_get(test_dev_id,\n \t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\n@@ -181,7 +182,7 @@ test_rawdev_queue_default_conf_get(void)\n \t * depth = DEF_DEPTH\n \t */\n \tfor (i = 0; i < rdev_conf_get.num_queues; i++) {\n-\t\trte_rawdev_queue_conf_get(TEST_DEV_ID, i, &q);\n+\t\trte_rawdev_queue_conf_get(test_dev_id, i, &q);\n \t\tRTE_TEST_ASSERT_EQUAL(q.depth, SKELETON_QUEUE_DEF_DEPTH,\n \t\t\t\t \"Invalid default depth of queue (%d)\",\n \t\t\t\t q.depth);\n@@ -199,7 +200,7 @@ test_rawdev_queue_count(void)\n \tunsigned int q_count;\n \n \t/* Get the current configuration */\n-\tq_count = rte_rawdev_queue_count(TEST_DEV_ID);\n+\tq_count = rte_rawdev_queue_count(test_dev_id);\n \tRTE_TEST_ASSERT_EQUAL(q_count, 1, \"Invalid queue count (%d)\", q_count);\n \n \treturn TEST_SUCCESS;\n@@ -216,7 +217,7 @@ test_rawdev_queue_setup(void)\n \n \t/* Get the current configuration */\n \trdev_info.dev_private = &rdev_conf_get;\n-\tret = rte_rawdev_info_get(TEST_DEV_ID,\n+\tret = rte_rawdev_info_get(test_dev_id,\n \t\t\t\t (rte_rawdev_obj_t)&rdev_info);\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n@@ -230,11 +231,11 @@ test_rawdev_queue_setup(void)\n \t/* Modify the queue depth for Queue 0 and attach it */\n \tqset.depth = 15;\n \tqset.state = SKELETON_QUEUE_ATTACH;\n-\tret = rte_rawdev_queue_setup(TEST_DEV_ID, 0, &qset);\n+\tret = rte_rawdev_queue_setup(test_dev_id, 0, &qset);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to setup queue (%d)\", ret);\n \n \t/* Now, fetching the queue 0 should show depth as 15 */\n-\tret = rte_rawdev_queue_conf_get(TEST_DEV_ID, 0, &qget);\n+\tret = rte_rawdev_queue_conf_get(test_dev_id, 0, &qget);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to get queue config (%d)\", ret);\n \n \tRTE_TEST_ASSERT_EQUAL(qset.depth, qget.depth,\n@@ -254,11 +255,11 @@ test_rawdev_queue_release(void)\n \tstruct skeleton_rawdev_queue qget = {0};\n \n \t/* Now, fetching the queue 0 should show depth as 100 */\n-\tret = rte_rawdev_queue_release(TEST_DEV_ID, 0);\n+\tret = rte_rawdev_queue_release(test_dev_id, 0);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to release queue 0; (%d)\", ret);\n \n \t/* Now, fetching the queue 0 should show depth as default */\n-\tret = rte_rawdev_queue_conf_get(TEST_DEV_ID, 0, &qget);\n+\tret = rte_rawdev_queue_conf_get(test_dev_id, 0, &qget);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to get queue config (%d)\", ret);\n \n \tRTE_TEST_ASSERT_EQUAL(qget.depth, SKELETON_QUEUE_DEF_DEPTH,\n@@ -278,21 +279,21 @@ test_rawdev_attr_set_get(void)\n \tuint64_t ret_value;\n \n \t/* Set an attribute and fetch it */\n-\tret = rte_rawdev_set_attr(TEST_DEV_ID, \"Test1\", 100);\n+\tret = rte_rawdev_set_attr(test_dev_id, \"Test1\", 100);\n \tRTE_TEST_ASSERT(!ret, \"Unable to set an attribute (Test1)\");\n \n \tdummy_value = &set_value;\n \t*dummy_value = 200;\n-\tret = rte_rawdev_set_attr(TEST_DEV_ID, \"Test2\", (uintptr_t)dummy_value);\n+\tret = rte_rawdev_set_attr(test_dev_id, \"Test2\", (uintptr_t)dummy_value);\n \n \t/* Check if attributes have been set */\n-\tret = rte_rawdev_get_attr(TEST_DEV_ID, \"Test1\", &ret_value);\n+\tret = rte_rawdev_get_attr(test_dev_id, \"Test1\", &ret_value);\n \tRTE_TEST_ASSERT_EQUAL(ret_value, 100,\n \t\t\t \"Attribute (Test1) not set correctly (%\" PRIu64 \")\",\n \t\t\t ret_value);\n \n \tret_value = 0;\n-\tret = rte_rawdev_get_attr(TEST_DEV_ID, \"Test2\", &ret_value);\n+\tret = rte_rawdev_get_attr(test_dev_id, \"Test2\", &ret_value);\n \tRTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), set_value,\n \t\t\t \"Attribute (Test2) not set correctly (%\" PRIu64 \")\",\n \t\t\t ret_value);\n@@ -316,7 +317,7 @@ test_rawdev_start_stop(void)\n \tRTE_TEST_ASSERT(dummy_firmware != NULL,\n \t\t\t\"Failed to create firmware memory backing\");\n \n-\tret = rte_rawdev_firmware_load(TEST_DEV_ID, dummy_firmware);\n+\tret = rte_rawdev_firmware_load(test_dev_id, dummy_firmware);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Firmware loading failed (%d)\", ret);\n \n \t/* Skeleton doesn't do anything with the firmware area - that is dummy\n@@ -325,8 +326,8 @@ test_rawdev_start_stop(void)\n \trte_free(dummy_firmware);\n \tdummy_firmware = NULL;\n \n-\trte_rawdev_start(TEST_DEV_ID);\n-\tret = rte_rawdev_info_get(TEST_DEV_ID, (rte_rawdev_obj_t)&rdev_info);\n+\trte_rawdev_start(test_dev_id);\n+\tret = rte_rawdev_info_get(test_dev_id, (rte_rawdev_obj_t)&rdev_info);\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\n@@ -334,8 +335,8 @@ test_rawdev_start_stop(void)\n \t\t\t \"Device start failed. State is (%d)\",\n \t\t\t rdev_conf_get.device_state);\n \n-\trte_rawdev_stop(TEST_DEV_ID);\n-\tret = rte_rawdev_info_get(TEST_DEV_ID, (rte_rawdev_obj_t)&rdev_info);\n+\trte_rawdev_stop(test_dev_id);\n+\tret = rte_rawdev_info_get(test_dev_id, (rte_rawdev_obj_t)&rdev_info);\n \tRTE_TEST_ASSERT_SUCCESS(ret,\n \t\t\t\t\"Failed to obtain rawdev configuration (%d)\",\n \t\t\t\tret);\n@@ -344,7 +345,7 @@ test_rawdev_start_stop(void)\n \t\t\t rdev_conf_get.device_state);\n \n \t/* Unloading the firmware once device is stopped */\n-\tret = rte_rawdev_firmware_unload(TEST_DEV_ID);\n+\tret = rte_rawdev_firmware_unload(test_dev_id);\n \tRTE_TEST_ASSERT_SUCCESS(ret, \"Failed to unload firmware (%d)\", ret);\n \n \treturn TEST_SUCCESS;\n@@ -365,7 +366,7 @@ test_rawdev_enqdeq(void)\n \tsnprintf(buffers[0].buf_addr, strlen(TEST_DEV_NAME) + 2, \"%s%d\",\n \t\t TEST_DEV_NAME, 0);\n \n-\tret = rte_rawdev_enqueue_buffers(TEST_DEV_ID,\n+\tret = rte_rawdev_enqueue_buffers(test_dev_id,\n \t\t\t\t\t (struct rte_rawdev_buf **)&buffers,\n \t\t\t\t\t count, &queue_id);\n \tRTE_TEST_ASSERT_EQUAL((unsigned int)ret, count,\n@@ -375,7 +376,7 @@ test_rawdev_enqdeq(void)\n \tif (!deq_buffers)\n \t\tgoto cleanup;\n \n-\tret = rte_rawdev_dequeue_buffers(TEST_DEV_ID,\n+\tret = rte_rawdev_dequeue_buffers(test_dev_id,\n \t\t\t\t\t(struct rte_rawdev_buf **)&deq_buffers,\n \t\t\t\t\tcount, &queue_id);\n \tRTE_TEST_ASSERT_EQUAL((unsigned int)ret, count,\n", "prefixes": [ "v3", "2/3" ] }