Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55777/?format=api
{ "id": 55777, "url": "http://patches.dpdk.org/api/patches/55777/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/ae7910d46c3cf307dfeb2f96ef5231b7d9f8260e.1561994563.git.dekelp@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<ae7910d46c3cf307dfeb2f96ef5231b7d9f8260e.1561994563.git.dekelp@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/ae7910d46c3cf307dfeb2f96ef5231b7d9f8260e.1561994563.git.dekelp@mellanox.com", "date": "2019-07-01T15:43:10", "name": "[v9,2/3] app/testpmd: add actions to modify TCP header fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d56cfeed285e7cbffef897b15747aa05e5d1004b", "submitter": { "id": 1082, "url": "http://patches.dpdk.org/api/people/1082/?format=api", "name": "Dekel Peled", "email": "dekelp@mellanox.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/ae7910d46c3cf307dfeb2f96ef5231b7d9f8260e.1561994563.git.dekelp@mellanox.com/mbox/", "series": [ { "id": 5256, "url": "http://patches.dpdk.org/api/series/5256/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5256", "date": "2019-07-01T15:43:08", "name": "add actions to modify header fields", "version": 9, "mbox": "http://patches.dpdk.org/series/5256/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55777/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55777/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EC1271B9F6;\n\tMon, 1 Jul 2019 17:45:24 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id C40531B9F5\n\tfor <dev@dpdk.org>; Mon, 1 Jul 2019 17:45:23 +0200 (CEST)", "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 1 Jul 2019 18:45:18 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x61FieEq028876;\n\tMon, 1 Jul 2019 18:45:18 +0300" ], "From": "Dekel Peled <dekelp@mellanox.com>", "To": "adrien.mazarguil@6wind.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, \n\tbernard.iremonger@intel.com, yskoh@mellanox.com, shahafs@mellanox.com,\n\tviacheslavo@mellanox.com, arybchenko@solarflare.com", "Cc": "dev@dpdk.org, orika@mellanox.com", "Date": "Mon, 1 Jul 2019 18:43:10 +0300", "Message-Id": "<ae7910d46c3cf307dfeb2f96ef5231b7d9f8260e.1561994563.git.dekelp@mellanox.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1561994563.git.dekelp@mellanox.com>", "References": "<1553177917-43297-1-git-send-email-dekelp@mellanox.com>\n\t<cover.1561994563.git.dekelp@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v9 2/3] app/testpmd: add actions to modify TCP\n\theader fields", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add actions:\n- INC_TCP_SEQ - Increase sequence number in the outermost TCP header.\n- DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.\n- INC_TCP_ACK - Increase acknowledgment number in the outermost TCP\n header.\n- DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP\n header.\n\nOriginal work by Xiaoyu Min.\n\nThis patch uses the new approach introduced by [1], using the new\nmacro ARG_ENTRY_HTON to pass a single integer argument to each of\nthe new actions.\n\n[1] http://patches.dpdk.org/patch/55773/\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n app/test-pmd/cmdline_flow.c | 92 +++++++++++++++++++++++++++++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 +++++\n 2 files changed, 108 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex fa7bd13..e644efa 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -272,6 +272,14 @@ enum index {\n \tACTION_SET_MAC_SRC_MAC_SRC,\n \tACTION_SET_MAC_DST,\n \tACTION_SET_MAC_DST_MAC_DST,\n+\tACTION_INC_TCP_SEQ,\n+\tACTION_INC_TCP_SEQ_VALUE,\n+\tACTION_DEC_TCP_SEQ,\n+\tACTION_DEC_TCP_SEQ_VALUE,\n+\tACTION_INC_TCP_ACK,\n+\tACTION_INC_TCP_ACK_VALUE,\n+\tACTION_DEC_TCP_ACK,\n+\tACTION_DEC_TCP_ACK_VALUE,\n };\n \n /** Maximum size for pattern in struct rte_flow_item_raw. */\n@@ -893,6 +901,10 @@ struct parse_action_priv {\n \tACTION_SET_TTL,\n \tACTION_SET_MAC_SRC,\n \tACTION_SET_MAC_DST,\n+\tACTION_INC_TCP_SEQ,\n+\tACTION_DEC_TCP_SEQ,\n+\tACTION_INC_TCP_ACK,\n+\tACTION_DEC_TCP_ACK,\n \tZERO,\n };\n \n@@ -1055,6 +1067,30 @@ struct parse_action_priv {\n \tZERO,\n };\n \n+static const enum index action_inc_tcp_seq[] = {\n+\tACTION_INC_TCP_SEQ_VALUE,\n+\tACTION_NEXT,\n+\tZERO,\n+};\n+\n+static const enum index action_dec_tcp_seq[] = {\n+\tACTION_DEC_TCP_SEQ_VALUE,\n+\tACTION_NEXT,\n+\tZERO,\n+};\n+\n+static const enum index action_inc_tcp_ack[] = {\n+\tACTION_INC_TCP_ACK_VALUE,\n+\tACTION_NEXT,\n+\tZERO,\n+};\n+\n+static const enum index action_dec_tcp_ack[] = {\n+\tACTION_DEC_TCP_ACK_VALUE,\n+\tACTION_NEXT,\n+\tZERO,\n+};\n+\n static int parse_init(struct context *, const struct token *,\n \t\t const char *, unsigned int,\n \t\t void *, unsigned int);\n@@ -2862,6 +2898,62 @@ static int comp_vc_action_rss_queue(struct context *, const struct token *,\n \t\t\t (struct rte_flow_action_set_mac, mac_addr)),\n \t\t.call = parse_vc_conf,\n \t},\n+\t[ACTION_INC_TCP_SEQ] = {\n+\t\t.name = \"inc_tcp_seq\",\n+\t\t.help = \"increase TCP sequence number\",\n+\t\t.priv = PRIV_ACTION(INC_TCP_SEQ, sizeof(rte_be32_t)),\n+\t\t.next = NEXT(action_inc_tcp_seq),\n+\t\t.call = parse_vc,\n+\t},\n+\t[ACTION_INC_TCP_SEQ_VALUE] = {\n+\t\t.name = \"value\",\n+\t\t.help = \"the value to increase TCP sequence number by\",\n+\t\t.next = NEXT(action_inc_tcp_seq, NEXT_ENTRY(UNSIGNED)),\n+\t\t.args = ARGS(ARG_ENTRY_HTON(rte_be32_t)),\n+\t\t.call = parse_vc_conf,\n+\t},\n+\t[ACTION_DEC_TCP_SEQ] = {\n+\t\t.name = \"dec_tcp_seq\",\n+\t\t.help = \"decrease TCP sequence number\",\n+\t\t.priv = PRIV_ACTION(DEC_TCP_SEQ, sizeof(rte_be32_t)),\n+\t\t.next = NEXT(action_dec_tcp_seq),\n+\t\t.call = parse_vc,\n+\t},\n+\t[ACTION_DEC_TCP_SEQ_VALUE] = {\n+\t\t.name = \"value\",\n+\t\t.help = \"the value to decrease TCP sequence number by\",\n+\t\t.next = NEXT(action_dec_tcp_seq, NEXT_ENTRY(UNSIGNED)),\n+\t\t.args = ARGS(ARG_ENTRY_HTON(rte_be32_t)),\n+\t\t.call = parse_vc_conf,\n+\t},\n+\t[ACTION_INC_TCP_ACK] = {\n+\t\t.name = \"inc_tcp_ack\",\n+\t\t.help = \"increase TCP acknowledgment number\",\n+\t\t.priv = PRIV_ACTION(INC_TCP_ACK, sizeof(rte_be32_t)),\n+\t\t.next = NEXT(action_inc_tcp_ack),\n+\t\t.call = parse_vc,\n+\t},\n+\t[ACTION_INC_TCP_ACK_VALUE] = {\n+\t\t.name = \"value\",\n+\t\t.help = \"the value to increase TCP acknowledgment number by\",\n+\t\t.next = NEXT(action_inc_tcp_ack, NEXT_ENTRY(UNSIGNED)),\n+\t\t.args = ARGS(ARG_ENTRY_HTON(rte_be32_t)),\n+\t\t.call = parse_vc_conf,\n+\t},\n+\t[ACTION_DEC_TCP_ACK] = {\n+\t\t.name = \"dec_tcp_ack\",\n+\t\t.help = \"decrease TCP acknowledgment number\",\n+\t\t.priv = PRIV_ACTION(DEC_TCP_ACK, sizeof(rte_be32_t)),\n+\t\t.next = NEXT(action_dec_tcp_ack),\n+\t\t.call = parse_vc,\n+\t},\n+\t[ACTION_DEC_TCP_ACK_VALUE] = {\n+\t\t.name = \"value\",\n+\t\t.help = \"the value to decrease TCP acknowledgment number by\",\n+\t\t.next = NEXT(action_dec_tcp_ack, NEXT_ENTRY(UNSIGNED)),\n+\t\t.args = ARGS(ARG_ENTRY_HTON(rte_be32_t)),\n+\t\t.call = parse_vc_conf,\n+\t},\n };\n \n /** Remove and return last entry from argument stack. */\ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex cb83a3c..49a9e15 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -4106,6 +4106,22 @@ This section lists supported actions and their attributes, if any.\n \n - ``mac_addr {MAC-48}``: new destination MAC address\n \n+- ``inc_tcp_seq``: Increase sequence number in the outermost TCP header.\n+\n+ - ``value {unsigned}``: Value to increase TCP sequence number by.\n+\n+- ``dec_tcp_seq``: Decrease sequence number in the outermost TCP header.\n+\n+ - ``value {unsigned}``: Value to decrease TCP sequence number by.\n+\n+- ``inc_tcp_ack``: Increase acknowledgment number in the outermost TCP header.\n+\n+ - ``value {unsigned}``: Value to increase TCP acknowledgment number by.\n+\n+- ``dec_tcp_ack``: Decrease acknowledgment number in the outermost TCP header.\n+\n+ - ``value {unsigned}``: Value to decrease TCP acknowledgment number by.\n+\n Destroying flow rules\n ~~~~~~~~~~~~~~~~~~~~~\n \n", "prefixes": [ "v9", "2/3" ] }