Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55735/?format=api
{ "id": 55735, "url": "http://patches.dpdk.org/api/patches/55735/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190701050450.43330-2-leyi.rong@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190701050450.43330-2-leyi.rong@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190701050450.43330-2-leyi.rong@intel.com", "date": "2019-07-01T05:04:48", "name": "[v2,1/3] net/ice/base: add support for IPv6 based switch filters", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b1a66220378d4b0037c71d9010c280d0a802bbc2", "submitter": { "id": 1204, "url": "http://patches.dpdk.org/api/people/1204/?format=api", "name": "Leyi Rong", "email": "leyi.rong@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190701050450.43330-2-leyi.rong@intel.com/mbox/", "series": [ { "id": 5237, "url": "http://patches.dpdk.org/api/series/5237/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5237", "date": "2019-07-01T05:04:47", "name": "update ice code that were not working correctly", "version": 2, "mbox": "http://patches.dpdk.org/series/5237/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55735/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55735/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E8AE5689;\n\tMon, 1 Jul 2019 07:06:28 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id DC56931FC\n\tfor <dev@dpdk.org>; Mon, 1 Jul 2019 07:06:25 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t30 Jun 2019 22:06:25 -0700", "from lrong-srv-03.sh.intel.com ([10.67.119.177])\n\tby orsmga004.jf.intel.com with ESMTP; 30 Jun 2019 22:06:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,437,1557212400\"; d=\"scan'208\";a=\"314765274\"", "From": "Leyi Rong <leyi.rong@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, Leyi Rong <leyi.rong@intel.com>,\n\tKevin Scott <kevin.c.scott@intel.com>,\n\tPaul M Stillwell Jr <paul.m.stillwell.jr@intel.com>", "Date": "Mon, 1 Jul 2019 13:04:48 +0800", "Message-Id": "<20190701050450.43330-2-leyi.rong@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190701050450.43330-1-leyi.rong@intel.com>", "References": "<20190626023025.7039-1-leyi.rong@intel.com>\n\t<20190701050450.43330-1-leyi.rong@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/3] net/ice/base: add support for IPv6 based\n\tswitch filters", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "- Add IPv6 switch rule support.\n- Add IPv6 training packet.\n- Correct name of IPv6 header variable.\n- Fix enum values so that they point to the proper\n ice_prot_ext_tbl_entry field.\n\nSigned-off-by: Kevin Scott <kevin.c.scott@intel.com>\nSigned-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>\nSigned-off-by: Leyi Rong <leyi.rong@intel.com>\n---\n drivers/net/ice/base/ice_protocol_type.h | 16 ++---\n drivers/net/ice/base/ice_switch.c | 87 +++++++++++++++++++++++-\n 2 files changed, 93 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_protocol_type.h b/drivers/net/ice/base/ice_protocol_type.h\nindex 033efdb5a..368ab0d16 100644\n--- a/drivers/net/ice/base/ice_protocol_type.h\n+++ b/drivers/net/ice/base/ice_protocol_type.h\n@@ -32,8 +32,8 @@ enum ice_protocol_type {\n \tICE_MAC_IL,\n \tICE_IPV4_OFOS,\n \tICE_IPV4_IL,\n-\tICE_IPV6_IL,\n \tICE_IPV6_OFOS,\n+\tICE_IPV6_IL,\n \tICE_TCP_IL,\n \tICE_UDP_OF,\n \tICE_UDP_ILOS,\n@@ -200,13 +200,13 @@ struct ice_nvgre {\n };\n \n union ice_prot_hdr {\n-\t\tstruct ice_ether_hdr eth_hdr;\n-\t\tstruct ice_ipv4_hdr ipv4_hdr;\n-\t\tstruct ice_ipv6_hdr ice_ipv6_ofos_hdr;\n-\t\tstruct ice_l4_hdr l4_hdr;\n-\t\tstruct ice_sctp_hdr sctp_hdr;\n-\t\tstruct ice_udp_tnl_hdr tnl_hdr;\n-\t\tstruct ice_nvgre nvgre_hdr;\n+\tstruct ice_ether_hdr eth_hdr;\n+\tstruct ice_ipv4_hdr ipv4_hdr;\n+\tstruct ice_ipv6_hdr ipv6_hdr;\n+\tstruct ice_l4_hdr l4_hdr;\n+\tstruct ice_sctp_hdr sctp_hdr;\n+\tstruct ice_udp_tnl_hdr tnl_hdr;\n+\tstruct ice_nvgre nvgre_hdr;\n };\n \n /* This is mapping table entry that maps every word within a given protocol\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex dbf4c5fb0..feacfa483 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -243,6 +243,73 @@ dummy_tcp_packet[] = {\n \t0x00, 0x00,\t/* 2 bytes for 4 byte alignment */\n };\n \n+static const\n+struct ice_dummy_pkt_offsets dummy_tcp_ipv6_packet_offsets[] = {\n+\t{ ICE_MAC_OFOS,\t\t0 },\n+\t{ ICE_IPV6_OFOS,\t14 },\n+\t{ ICE_TCP_IL,\t\t54 },\n+\t{ ICE_PROTOCOL_LAST,\t0 },\n+};\n+\n+static const u8\n+dummy_tcp_ipv6_packet[] = {\n+\t0x00, 0x00, 0x00, 0x00, /* ICE_MAC_OFOS 0 */\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x86, 0xDD,\n+\n+\t0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 40 */\n+\t0x00, 0x14, 0x06, 0x00, /* Next header is TCP */\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\n+\t0x00, 0x00, 0x00, 0x00, /* ICE_TCP_IL 54 */\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x50, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\n+\t0x00, 0x00, /* 2 bytes for 4 byte alignment */\n+};\n+\n+static const\n+struct ice_dummy_pkt_offsets dummy_udp_ipv6_packet_offsets[] = {\n+\t{ ICE_MAC_OFOS,\t\t0 },\n+\t{ ICE_IPV6_OFOS,\t14 },\n+\t{ ICE_UDP_ILOS,\t\t54 },\n+\t{ ICE_PROTOCOL_LAST,\t0 },\n+};\n+\n+static const u8\n+dummy_udp_ipv6_packet[] = {\n+\t0x00, 0x00, 0x00, 0x00, /* ICE_MAC_OFOS 0 */\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x86, 0xDD,\n+\n+\t0x60, 0x00, 0x00, 0x00, /* ICE_IPV6_OFOS 40 */\n+\t0x00, 0x08, 0x11, 0x00, /* Next header UDP*/\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\t0x00, 0x00, 0x00, 0x00,\n+\n+\t0x00, 0x00, 0x00, 0x00, /* ICE_UDP_ILOS 54 */\n+\t0x00, 0x08, 0x00, 0x00,\n+\n+\t0x00, 0x00, /* 2 bytes for 4 byte alignment */\n+};\n+\n /* this is a recipe to profile bitmap association */\n static ice_declare_bitmap(recipe_to_profile[ICE_MAX_NUM_RECIPES],\n \t\t\t ICE_MAX_NUM_PROFILES);\n@@ -5275,7 +5342,7 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t u16 *pkt_len,\n \t\t const struct ice_dummy_pkt_offsets **offsets)\n {\n-\tbool tcp = false, udp = false;\n+\tbool tcp = false, udp = false, ipv6 = false;\n \tu16 i;\n \n \tfor (i = 0; i < lkups_cnt; i++) {\n@@ -5283,6 +5350,8 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\t\tudp = true;\n \t\telse if (lkups[i].type == ICE_TCP_IL)\n \t\t\ttcp = true;\n+\t\telse if (lkups[i].type == ICE_IPV6_OFOS)\n+\t\t\tipv6 = true;\n \t}\n \n \tif (tun_type == ICE_SW_TUN_NVGRE || tun_type == ICE_ALL_TUNNELS) {\n@@ -5307,11 +5376,21 @@ ice_find_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\treturn;\n \t}\n \n-\tif (udp) {\n+\tif (udp && !ipv6) {\n \t\t*pkt = dummy_udp_packet;\n \t\t*pkt_len = sizeof(dummy_udp_packet);\n \t\t*offsets = dummy_udp_packet_offsets;\n \t\treturn;\n+\t} else if (udp && ipv6) {\n+\t\t*pkt = dummy_udp_ipv6_packet;\n+\t\t*pkt_len = sizeof(dummy_udp_ipv6_packet);\n+\t\t*offsets = dummy_udp_ipv6_packet_offsets;\n+\t\treturn;\n+\t} else if ((tcp && ipv6) || ipv6) {\n+\t\t*pkt = dummy_tcp_ipv6_packet;\n+\t\t*pkt_len = sizeof(dummy_tcp_ipv6_packet);\n+\t\t*offsets = dummy_tcp_ipv6_packet_offsets;\n+\t\treturn;\n \t}\n \n \t*pkt = dummy_tcp_packet;\n@@ -5375,6 +5454,10 @@ ice_fill_adv_dummy_packet(struct ice_adv_lkup_elem *lkups, u16 lkups_cnt,\n \t\tcase ICE_IPV4_IL:\n \t\t\tlen = sizeof(struct ice_ipv4_hdr);\n \t\t\tbreak;\n+\t\tcase ICE_IPV6_OFOS:\n+\t\tcase ICE_IPV6_IL:\n+\t\t\tlen = sizeof(struct ice_ipv6_hdr);\n+\t\t\tbreak;\n \t\tcase ICE_TCP_IL:\n \t\tcase ICE_UDP_OF:\n \t\tcase ICE_UDP_ILOS:\n", "prefixes": [ "v2", "1/3" ] }