Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55725/?format=api
http://patches.dpdk.org/api/patches/55725/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190630180609.36705-56-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190630180609.36705-56-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190630180609.36705-56-jerinj@marvell.com", "date": "2019-06-30T18:06:07", "name": "[v2,55/57] net/octeontx2: add device stop and close operations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8e7d5078ae988039702709a03cdc62c70928cb18", "submitter": { "id": 1188, "url": "http://patches.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 310, "url": "http://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190630180609.36705-56-jerinj@marvell.com/mbox/", "series": [ { "id": 5236, "url": "http://patches.dpdk.org/api/series/5236/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5236", "date": "2019-06-30T18:05:12", "name": "OCTEON TX2 Ethdev driver", "version": 2, "mbox": "http://patches.dpdk.org/series/5236/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55725/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/55725/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 786371BC27;\n\tSun, 30 Jun 2019 20:12:29 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n\t[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id AF1231B998\n\tfor <dev@dpdk.org>; Sun, 30 Jun 2019 20:09:22 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n\tby mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx5UI73OQ028454 for <dev@dpdk.org>; Sun, 30 Jun 2019 11:09:22 -0700", "from sc-exch01.marvell.com ([199.233.58.181])\n\tby mx0a-0016f401.pphosted.com with ESMTP id 2te5bn4gq7-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n\tfor <dev@dpdk.org>; Sun, 30 Jun 2019 11:09:21 -0700", "from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSun, 30 Jun 2019 11:09:20 -0700", "from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com\n\t(10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Sun, 30 Jun 2019 11:09:20 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n\tby maili.marvell.com (Postfix) with ESMTP id F01263F703F;\n\tSun, 30 Jun 2019 11:09:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=nhm4EIOq7uWb2P5tTX6N3G5IY6fTTQXMr3GQFDZfo2k=;\n\tb=U1XHS3WxowJCdGTpqfwlq9VUq6B4ySQXHQORUh6xi1e0E26DP4bwOHOjI/dBdH1bPQO0\n\tuHVg1eFiZ7QilrZqU052O7w0XKEjgpjEeOy5iLIWPV4+ihEeBX3qOOs7hwDcyD+07/mW\n\tzNzSq6sn4MjtJLyE7DFLU3vXMOvVN8srBJDVAk0/Z9cGDQC502mfc0q9Z34pGsILhknQ\n\t5M81AdI5qUj3iGWix1PRXHhM94CIFa1aHyZ4e806tAk6LNslRQB2R55rn9SPSEYwBTG5\n\tji/W4RIcz/X9LrnXypNaqpttjTVoyCRansjqJwkeGrW7rijx+7xorEShu6rUMKfczqFI\n\ttg== ", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram\n\t<ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>", "CC": "Vamsi Attunuru <vattunuru@marvell.com>", "Date": "Sun, 30 Jun 2019 23:36:07 +0530", "Message-ID": "<20190630180609.36705-56-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190630180609.36705-1-jerinj@marvell.com>", "References": "<20190602152434.23996-1-jerinj@marvell.com>\n\t<20190630180609.36705-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-06-30_08:, , signatures=0", "Subject": "[dpdk-dev] [PATCH v2 55/57] net/octeontx2: add device stop and\n\tclose operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nithin Dabilpuram <ndabilpuram@marvell.com>\n\nAdd device stop, close and reset operations.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\nSigned-off-by: Vamsi Attunuru <vattunuru@marvell.com>\n---\n drivers/net/octeontx2/otx2_ethdev.c | 75 +++++++++++++++++++++++++++++\n 1 file changed, 75 insertions(+)", "diff": "diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c\nindex 7f33f8808..e23bed603 100644\n--- a/drivers/net/octeontx2/otx2_ethdev.c\n+++ b/drivers/net/octeontx2/otx2_ethdev.c\n@@ -184,6 +184,19 @@ cgx_intlbk_enable(struct otx2_eth_dev *dev, bool en)\n \treturn otx2_mbox_process(mbox);\n }\n \n+static int\n+nix_cgx_stop_link_event(struct otx2_eth_dev *dev)\n+{\n+\tstruct otx2_mbox *mbox = dev->mbox;\n+\n+\tif (otx2_dev_is_vf(dev))\n+\t\treturn 0;\n+\n+\totx2_mbox_alloc_msg_cgx_stop_linkevents(mbox);\n+\n+\treturn otx2_mbox_process(mbox);\n+}\n+\n static inline void\n nix_rx_queue_reset(struct otx2_eth_rxq *rxq)\n {\n@@ -1189,6 +1202,7 @@ otx2_nix_configure(struct rte_eth_dev *eth_dev)\n \tif (dev->configured == 1) {\n \t\totx2_nix_rxchan_bpid_cfg(eth_dev, false);\n \t\totx2_nix_vlan_fini(eth_dev);\n+\t\totx2_flow_free_all_resources(dev);\n \t\toxt2_nix_unregister_queue_irqs(eth_dev);\n \t\tnix_set_nop_rxtx_function(eth_dev);\n \t\trc = nix_store_queue_cfg_and_then_release(eth_dev);\n@@ -1406,6 +1420,37 @@ otx2_nix_rx_queue_stop(struct rte_eth_dev *eth_dev, uint16_t qidx)\n \treturn rc;\n }\n \n+static void\n+otx2_nix_dev_stop(struct rte_eth_dev *eth_dev)\n+{\n+\tstruct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);\n+\tstruct rte_mbuf *rx_pkts[32];\n+\tstruct otx2_eth_rxq *rxq;\n+\tint count, i, j, rc;\n+\n+\tnix_cgx_stop_link_event(dev);\n+\tnpc_rx_disable(dev);\n+\n+\t/* Stop rx queues and free up pkts pending */\n+\tfor (i = 0; i < eth_dev->data->nb_rx_queues; i++) {\n+\t\trc = otx2_nix_rx_queue_stop(eth_dev, i);\n+\t\tif (rc)\n+\t\t\tcontinue;\n+\n+\t\trxq = eth_dev->data->rx_queues[i];\n+\t\tcount = dev->rx_pkt_burst_no_offload(rxq, rx_pkts, 32);\n+\t\twhile (count) {\n+\t\t\tfor (j = 0; j < count; j++)\n+\t\t\t\trte_pktmbuf_free(rx_pkts[j]);\n+\t\t\tcount = dev->rx_pkt_burst_no_offload(rxq, rx_pkts, 32);\n+\t\t}\n+\t}\n+\n+\t/* Stop tx queues */\n+\tfor (i = 0; i < eth_dev->data->nb_tx_queues; i++)\n+\t\totx2_nix_tx_queue_stop(eth_dev, i);\n+}\n+\n static int\n otx2_nix_dev_start(struct rte_eth_dev *eth_dev)\n {\n@@ -1458,6 +1503,8 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev)\n \treturn rc;\n }\n \n+static int otx2_nix_dev_reset(struct rte_eth_dev *eth_dev);\n+static void otx2_nix_dev_close(struct rte_eth_dev *eth_dev);\n \n /* Initialize and register driver with DPDK Application */\n static const struct eth_dev_ops otx2_eth_dev_ops = {\n@@ -1469,11 +1516,14 @@ static const struct eth_dev_ops otx2_eth_dev_ops = {\n \t.rx_queue_setup = otx2_nix_rx_queue_setup,\n \t.rx_queue_release = otx2_nix_rx_queue_release,\n \t.dev_start = otx2_nix_dev_start,\n+\t.dev_stop = otx2_nix_dev_stop,\n+\t.dev_close = otx2_nix_dev_close,\n \t.tx_queue_start = otx2_nix_tx_queue_start,\n \t.tx_queue_stop = otx2_nix_tx_queue_stop,\n \t.rx_queue_start = otx2_nix_rx_queue_start,\n \t.rx_queue_stop = otx2_nix_rx_queue_stop,\n \t.dev_supported_ptypes_get = otx2_nix_supported_ptypes_get,\n+\t.dev_reset = otx2_nix_dev_reset,\n \t.stats_get = otx2_nix_dev_stats_get,\n \t.stats_reset = otx2_nix_dev_stats_reset,\n \t.get_reg = otx2_nix_dev_get_reg,\n@@ -1725,9 +1775,14 @@ otx2_eth_dev_uninit(struct rte_eth_dev *eth_dev, bool mbox_close)\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn 0;\n \n+\t/* Clear the flag since we are closing down */\n+\tdev->configured = 0;\n+\n \t/* Disable nix bpid config */\n \totx2_nix_rxchan_bpid_cfg(eth_dev, false);\n \n+\tnpc_rx_disable(dev);\n+\n \t/* Disable vlan offloads */\n \totx2_nix_vlan_fini(eth_dev);\n \n@@ -1738,6 +1793,8 @@ otx2_eth_dev_uninit(struct rte_eth_dev *eth_dev, bool mbox_close)\n \tif (otx2_ethdev_is_ptp_en(dev))\n \t\totx2_nix_timesync_disable(eth_dev);\n \n+\tnix_cgx_stop_link_event(dev);\n+\n \t/* Free up SQs */\n \tfor (i = 0; i < eth_dev->data->nb_tx_queues; i++) {\n \t\totx2_nix_tx_queue_release(eth_dev->data->tx_queues[i]);\n@@ -1793,6 +1850,24 @@ otx2_eth_dev_uninit(struct rte_eth_dev *eth_dev, bool mbox_close)\n \treturn 0;\n }\n \n+static void\n+otx2_nix_dev_close(struct rte_eth_dev *eth_dev)\n+{\n+\totx2_eth_dev_uninit(eth_dev, true);\n+}\n+\n+static int\n+otx2_nix_dev_reset(struct rte_eth_dev *eth_dev)\n+{\n+\tint rc;\n+\n+\trc = otx2_eth_dev_uninit(eth_dev, false);\n+\tif (rc)\n+\t\treturn rc;\n+\n+\treturn otx2_eth_dev_init(eth_dev);\n+}\n+\n static int\n nix_remove(struct rte_pci_device *pci_dev)\n {\n", "prefixes": [ "v2", "55/57" ] }{ "id": 55725, "url": "