Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55671/?format=api
{ "id": 55671, "url": "http://patches.dpdk.org/api/patches/55671/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1561911676-37718-4-git-send-email-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1561911676-37718-4-git-send-email-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1561911676-37718-4-git-send-email-gavin.hu@arm.com", "date": "2019-06-30T16:21:14", "name": "[RFC,3/5] ring: use wfe to wait for ring tail update on aarch64", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "bb892c05f340411abf01ad8c928cdcc49ee2d5fa", "submitter": { "id": 1018, "url": "http://patches.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1561911676-37718-4-git-send-email-gavin.hu@arm.com/mbox/", "series": [ { "id": 5234, "url": "http://patches.dpdk.org/api/series/5234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5234", "date": "2019-06-30T16:21:11", "name": "use WFE for locks and ring on aarch64", "version": 1, "mbox": "http://patches.dpdk.org/series/5234/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55671/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/55671/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F2A8A1B998;\n\tSun, 30 Jun 2019 18:21:50 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id 6E97B1B96B\n\tfor <dev@dpdk.org>; Sun, 30 Jun 2019 18:21:46 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF47E13D5;\n\tSun, 30 Jun 2019 09:21:45 -0700 (PDT)", "from net-arm-thunderx2.shanghai.arm.com\n\t(net-arm-thunderx2.shanghai.arm.com [10.169.40.40])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t14F9F3F718; Sun, 30 Jun 2019 09:21:43 -0700 (PDT)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, jerinj@marvell.com, hemant.agrawal@nxp.com,\n\tbruce.richardson@intel.com, chaozhu@linux.vnet.ibm.com,\n\tHonnappa.Nagarahalli@arm.com, nd@arm.com, gavin.hu@arm.com", "Date": "Mon, 1 Jul 2019 00:21:14 +0800", "Message-Id": "<1561911676-37718-4-git-send-email-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1561911676-37718-1-git-send-email-gavin.hu@arm.com>", "References": "<1561911676-37718-1-git-send-email-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [RFC 3/5] ring: use wfe to wait for ring tail update on\n\taarch64", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Instead of polling for tail to be updated, use wfe instruction.\n\n50%~70% performance gain was measured by running ring_perf_autotest on\nThunderX2.\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Steve Capper <steve.capper@arm.com>\nReviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n\n---\n lib/librte_ring/rte_ring_c11_mem.h | 5 +++--\n lib/librte_ring/rte_ring_generic.h | 4 ++--\n 2 files changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_ring/rte_ring_c11_mem.h b/lib/librte_ring/rte_ring_c11_mem.h\nindex 0fb73a3..f1de79c 100644\n--- a/lib/librte_ring/rte_ring_c11_mem.h\n+++ b/lib/librte_ring/rte_ring_c11_mem.h\n@@ -2,6 +2,7 @@\n *\n * Copyright (c) 2017,2018 HXT-semitech Corporation.\n * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org\n+ * Copyright (c) 2019 Arm Limited\n * All rights reserved.\n * Derived from FreeBSD's bufring.h\n * Used as BSD-3 Licensed with permission from Kip Macy.\n@@ -21,8 +22,8 @@ update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,\n \t * we need to wait for them to complete\n \t */\n \tif (!single)\n-\t\twhile (unlikely(ht->tail != old_val))\n-\t\t\trte_pause();\n+\t\tif (unlikely(ht->tail != old_val))\n+\t\t\trte_wait_until_equal_relaxed(&ht->tail, old_val);\n \n \t__atomic_store_n(&ht->tail, new_val, __ATOMIC_RELEASE);\n }\ndiff --git a/lib/librte_ring/rte_ring_generic.h b/lib/librte_ring/rte_ring_generic.h\nindex 953cdbb..bb0dce0 100644\n--- a/lib/librte_ring/rte_ring_generic.h\n+++ b/lib/librte_ring/rte_ring_generic.h\n@@ -23,8 +23,8 @@ update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,\n \t * we need to wait for them to complete\n \t */\n \tif (!single)\n-\t\twhile (unlikely(ht->tail != old_val))\n-\t\t\trte_pause();\n+\t\tif (unlikely(ht->tail != old_val))\n+\t\t\trte_wait_until_equal_relaxed(&ht->tail, old_val);\n \n \tht->tail = new_val;\n }\n", "prefixes": [ "RFC", "3/5" ] }