Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 55667,
    "url": "http://patches.dpdk.org/api/patches/55667/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/8b43b7e77d467429b45cb86eb09e218d721dd0de.1561872899.git.dekelp@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<8b43b7e77d467429b45cb86eb09e218d721dd0de.1561872899.git.dekelp@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/8b43b7e77d467429b45cb86eb09e218d721dd0de.1561872899.git.dekelp@mellanox.com",
    "date": "2019-06-30T07:59:08",
    "name": "[v8,1/3] ethdev: add actions to modify TCP header fields",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5987e7d1e45a1238fd3d0e796f46adc7a63369e8",
    "submitter": {
        "id": 1082,
        "url": "http://patches.dpdk.org/api/people/1082/?format=api",
        "name": "Dekel Peled",
        "email": "dekelp@mellanox.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/8b43b7e77d467429b45cb86eb09e218d721dd0de.1561872899.git.dekelp@mellanox.com/mbox/",
    "series": [
        {
            "id": 5233,
            "url": "http://patches.dpdk.org/api/series/5233/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5233",
            "date": "2019-06-30T07:59:07",
            "name": "add actions to modify header fields",
            "version": 8,
            "mbox": "http://patches.dpdk.org/series/5233/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/55667/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/55667/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 07DEF1B945;\n\tSun, 30 Jun 2019 10:00:13 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 2BF81374C\n\tfor <dev@dpdk.org>; Sun, 30 Jun 2019 10:00:04 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 30 Jun 2019 11:00:00 +0300",
            "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x5U7xxXF027511;\n\tSun, 30 Jun 2019 11:00:00 +0300"
        ],
        "From": "Dekel Peled <dekelp@mellanox.com>",
        "To": "adrien.mazarguil@6wind.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, \n\tbernard.iremonger@intel.com, yskoh@mellanox.com, shahafs@mellanox.com,\n\tviacheslavo@mellanox.com, arybchenko@solarflare.com",
        "Cc": "dev@dpdk.org, orika@mellanox.com",
        "Date": "Sun, 30 Jun 2019 10:59:08 +0300",
        "Message-Id": "<8b43b7e77d467429b45cb86eb09e218d721dd0de.1561872899.git.dekelp@mellanox.com>",
        "X-Mailer": "git-send-email 1.7.1",
        "In-Reply-To": "<cover.1561872899.git.dekelp@mellanox.com>",
        "References": "<cover.1561655345.git.dekelp@mellanox.com>\n\t<cover.1561872899.git.dekelp@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v8 1/3] ethdev: add actions to modify TCP header\n\tfields",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add actions:\n- INC_TCP_SEQ - Increase sequence number in the outermost TCP header.\n- DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header.\n- INC_TCP_ACK - Increase acknowledgment number in the outermost TCP\n\t\theader.\n- DEC_TCP_ACK - Decrease acknowledgment number in the outermost TCP\n\t\theader.\n\nOriginal work by Xiaoyu Min.\n\nThis patch introduces a new approach, using a simple integer instead\nof using an action-specific structure for each of these actions.\nThis approach can be later applied to modify existing actions which\nrequire only a single integer.\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\nAcked-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/prog_guide/rte_flow.rst | 35 ++++++++++++++++++++++++++++++++++-\n lib/librte_ethdev/rte_flow.c       |  4 ++++\n lib/librte_ethdev/rte_flow.h       | 34 +++++++++++++++++++++++++++++++++-\n 3 files changed, 71 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst\nindex a34d012..783a904 100644\n--- a/doc/guides/prog_guide/rte_flow.rst\n+++ b/doc/guides/prog_guide/rte_flow.rst\n@@ -1214,7 +1214,8 @@ Actions\n ~~~~~~~\n \n Each possible action is represented by a type. Some have associated\n-configuration structures. Several actions combined in a list can be assigned\n+configuration structures, some others use a simple integer.\n+Several actions combined in a list can be assigned\n to a flow rule and are performed in order.\n \n They fall in three categories:\n@@ -2345,6 +2346,38 @@ Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error will be returned.\n    | ``mac_addr`` | MAC address   |\n    +--------------+---------------+\n \n+Action: ``INC_TCP_SEQ``\n+^^^^^^^^^^^^^^^^^^^^^^^\n+\n+Increase sequence number in the outermost TCP header.\n+Value to increase TCP sequence number by is a big-endian 32 bit integer.\n+\n+Using this action on non-matching traffic will result in undefined behavior.\n+\n+Action: ``DEC_TCP_SEQ``\n+^^^^^^^^^^^^^^^^^^^^^^^\n+\n+Decrease sequence number in the outermost TCP header.\n+Value to decrease TCP sequence number by is a big-endian 32 bit integer.\n+\n+Using this action on non-matching traffic will result in undefined behavior.\n+\n+Action: ``INC_TCP_ACK``\n+^^^^^^^^^^^^^^^^^^^^^^^\n+\n+Increase acknowledgment number in the outermost TCP header.\n+Value to increase TCP acknowledgment number by is a big-endian 32 bit integer.\n+\n+Using this action on non-matching traffic will result in undefined behavior.\n+\n+Action: ``DEC_TCP_ACK``\n+^^^^^^^^^^^^^^^^^^^^^^^\n+\n+Decrease acknowledgment number in the outermost TCP header.\n+Value to decrease TCP acknowledgment number by is a big-endian 32 bit integer.\n+\n+Using this action on non-matching traffic will result in undefined behavior.\n+\n Negative types\n ~~~~~~~~~~~~~~\n \ndiff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c\nindex 3277be1..0c9f6c6 100644\n--- a/lib/librte_ethdev/rte_flow.c\n+++ b/lib/librte_ethdev/rte_flow.c\n@@ -143,6 +143,10 @@ struct rte_flow_desc_data {\n \tMK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)),\n \tMK_FLOW_ACTION(SET_MAC_SRC, sizeof(struct rte_flow_action_set_mac)),\n \tMK_FLOW_ACTION(SET_MAC_DST, sizeof(struct rte_flow_action_set_mac)),\n+\tMK_FLOW_ACTION(INC_TCP_SEQ, sizeof(rte_be32_t)),\n+\tMK_FLOW_ACTION(DEC_TCP_SEQ, sizeof(rte_be32_t)),\n+\tMK_FLOW_ACTION(INC_TCP_ACK, sizeof(rte_be32_t)),\n+\tMK_FLOW_ACTION(DEC_TCP_ACK, sizeof(rte_be32_t)),\n };\n \n static int\ndiff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h\nindex f3a8fb1..f5db6b6 100644\n--- a/lib/librte_ethdev/rte_flow.h\n+++ b/lib/librte_ethdev/rte_flow.h\n@@ -1650,6 +1650,38 @@ enum rte_flow_action_type {\n \t * See struct rte_flow_action_set_mac.\n \t */\n \tRTE_FLOW_ACTION_TYPE_SET_MAC_DST,\n+\n+\t/**\n+\t * Increase sequence number in the outermost TCP header.\n+\t *\n+\t * Using this action on non-matching traffic will result in\n+\t * undefined behavior.\n+\t */\n+\tRTE_FLOW_ACTION_TYPE_INC_TCP_SEQ,\n+\n+\t/**\n+\t * Decrease sequence number in the outermost TCP header.\n+\t *\n+\t * Using this action on non-matching traffic will result in\n+\t * undefined behavior.\n+\t */\n+\tRTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ,\n+\n+\t/**\n+\t * Increase acknowledgment number in the outermost TCP header.\n+\t *\n+\t * Using this action on non-matching traffic will result in\n+\t * undefined behavior.\n+\t */\n+\tRTE_FLOW_ACTION_TYPE_INC_TCP_ACK,\n+\n+\t/**\n+\t * Decrease acknowledgment number in the outermost TCP header.\n+\t *\n+\t * Using this action on non-matching traffic will result in\n+\t * undefined behavior.\n+\t */\n+\tRTE_FLOW_ACTION_TYPE_DEC_TCP_ACK,\n };\n \n /**\n@@ -2140,7 +2172,7 @@ struct rte_flow_action_set_mac {\n  */\n struct rte_flow_action {\n \tenum rte_flow_action_type type; /**< Action type. */\n-\tconst void *conf; /**< Pointer to action configuration structure. */\n+\tconst void *conf; /**< Pointer to action configuration. */\n };\n \n /**\n",
    "prefixes": [
        "v8",
        "1/3"
    ]
}