Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55487/?format=api
http://patches.dpdk.org/api/patches/55487/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/cef079d4a357b76cc1b746c8203f7191ef0a1646.1561635481.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cef079d4a357b76cc1b746c8203f7191ef0a1646.1561635481.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cef079d4a357b76cc1b746c8203f7191ef0a1646.1561635481.git.anatoly.burakov@intel.com", "date": "2019-06-27T11:38:57", "name": "[v3,02/14] drivers: use new memory locking API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "67485e3c0d1f42e7e4f948cef7604832ff00cae2", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/cef079d4a357b76cc1b746c8203f7191ef0a1646.1561635481.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 5198, "url": "http://patches.dpdk.org/api/series/5198/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5198", "date": "2019-06-27T11:38:55", "name": "Make shared memory config non-public", "version": 3, "mbox": "http://patches.dpdk.org/series/5198/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55487/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55487/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 55FB749E0;\n\tThu, 27 Jun 2019 13:39:19 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 4208E2BF7\n\tfor <dev@dpdk.org>; Thu, 27 Jun 2019 13:39:16 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Jun 2019 04:39:15 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga001.jf.intel.com with ESMTP; 27 Jun 2019 04:39:12 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,423,1557212400\"; d=\"scan'208\";a=\"245785811\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Hemant Agrawal <hemant.agrawal@nxp.com>,\n\tShreyansh Jain <shreyansh.jain@nxp.com>,\n\tMatan Azrad <matan@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>,\n\tYongseok Koh <yskoh@mellanox.com>, \n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,\n\tdavid.marchand@redhat.com, thomas@monjalon.net,\n\tstephen@networkplumber.org", "Date": "Thu, 27 Jun 2019 12:38:57 +0100", "Message-Id": "<cef079d4a357b76cc1b746c8203f7191ef0a1646.1561635481.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1561635481.git.anatoly.burakov@intel.com>", "<cover.1561635481.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1561635481.git.anatoly.burakov@intel.com>", "<cover.1561478388.git.anatoly.burakov@intel.com>\n\t<cover.1561635481.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v3 02/14] drivers: use new memory locking API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace usages of direct access to shared memory config with\ncalls to the new API.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/fslmc/fslmc_vfio.c | 8 +++-----\n drivers/net/mlx4/mlx4_mr.c | 11 +++++------\n drivers/net/mlx5/mlx5_mr.c | 11 +++++------\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++----\n 4 files changed, 16 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c\nindex 1aae56fa9..44e4fa6e2 100644\n--- a/drivers/bus/fslmc/fslmc_vfio.c\n+++ b/drivers/bus/fslmc/fslmc_vfio.c\n@@ -347,14 +347,12 @@ fslmc_dmamap_seg(const struct rte_memseg_list *msl __rte_unused,\n int rte_fslmc_vfio_dmamap(void)\n {\n \tint i = 0, ret;\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n-\trte_rwlock_t *mem_lock = &mcfg->memory_hotplug_lock;\n \n \t/* Lock before parsing and registering callback to memory subsystem */\n-\trte_rwlock_read_lock(mem_lock);\n+\trte_mcfg_mem_read_lock();\n \n \tif (rte_memseg_walk(fslmc_dmamap_seg, &i) < 0) {\n-\t\trte_rwlock_read_unlock(mem_lock);\n+\t\trte_mcfg_mem_read_unlock();\n \t\treturn -1;\n \t}\n \n@@ -378,7 +376,7 @@ int rte_fslmc_vfio_dmamap(void)\n \t/* Existing segments have been mapped and memory callback for hotplug\n \t * has been installed.\n \t */\n-\trte_rwlock_read_unlock(mem_lock);\n+\trte_mcfg_mem_read_unlock();\n \n \treturn 0;\n }\ndiff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c\nindex 48d458ad4..80827ce75 100644\n--- a/drivers/net/mlx4/mlx4_mr.c\n+++ b/drivers/net/mlx4/mlx4_mr.c\n@@ -593,7 +593,6 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t\t uintptr_t addr)\n {\n \tstruct mlx4_priv *priv = dev->data->dev_private;\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tconst struct rte_memseg_list *msl;\n \tconst struct rte_memseg *ms;\n \tstruct mlx4_mr *mr = NULL;\n@@ -696,7 +695,7 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t * just single page. If not, go on with the big chunk atomically from\n \t * here.\n \t */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_lock();\n \tdata_re = data;\n \tif (len > msl->page_sz &&\n \t !rte_memseg_contig_walk(mr_find_contig_memsegs_cb, &data_re)) {\n@@ -714,7 +713,7 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t\t */\n \t\tdata.start = RTE_ALIGN_FLOOR(addr, msl->page_sz);\n \t\tdata.end = data.start + msl->page_sz;\n-\t\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\t\trte_mcfg_mem_read_unlock();\n \t\tmr_free(mr);\n \t\tgoto alloc_resources;\n \t}\n@@ -734,7 +733,7 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t\tDEBUG(\"port %u found MR for %p on final lookup, abort\",\n \t\t dev->data->port_id, (void *)addr);\n \t\trte_rwlock_write_unlock(&priv->mr.rwlock);\n-\t\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\t\trte_mcfg_mem_read_unlock();\n \t\t/*\n \t\t * Must be unlocked before calling rte_free() because\n \t\t * mlx4_mr_mem_event_free_cb() can be called inside.\n@@ -802,12 +801,12 @@ mlx4_mr_create_primary(struct rte_eth_dev *dev, struct mlx4_mr_cache *entry,\n \t/* Lookup can't fail. */\n \tassert(entry->lkey != UINT32_MAX);\n \trte_rwlock_write_unlock(&priv->mr.rwlock);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_unlock();\n \treturn entry->lkey;\n err_mrlock:\n \trte_rwlock_write_unlock(&priv->mr.rwlock);\n err_memlock:\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_unlock();\n err_nolock:\n \t/*\n \t * In case of error, as this can be called in a datapath, a warning\ndiff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c\nindex 66e8e874e..872d0591e 100644\n--- a/drivers/net/mlx5/mlx5_mr.c\n+++ b/drivers/net/mlx5/mlx5_mr.c\n@@ -580,7 +580,6 @@ mlx5_mr_create_primary(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry,\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n \tstruct mlx5_ibv_shared *sh = priv->sh;\n \tstruct mlx5_dev_config *config = &priv->config;\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tconst struct rte_memseg_list *msl;\n \tconst struct rte_memseg *ms;\n \tstruct mlx5_mr *mr = NULL;\n@@ -684,7 +683,7 @@ mlx5_mr_create_primary(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry,\n \t * just single page. If not, go on with the big chunk atomically from\n \t * here.\n \t */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_lock();\n \tdata_re = data;\n \tif (len > msl->page_sz &&\n \t !rte_memseg_contig_walk(mr_find_contig_memsegs_cb, &data_re)) {\n@@ -702,7 +701,7 @@ mlx5_mr_create_primary(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry,\n \t\t */\n \t\tdata.start = RTE_ALIGN_FLOOR(addr, msl->page_sz);\n \t\tdata.end = data.start + msl->page_sz;\n-\t\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\t\trte_mcfg_mem_read_unlock();\n \t\tmr_free(mr);\n \t\tgoto alloc_resources;\n \t}\n@@ -722,7 +721,7 @@ mlx5_mr_create_primary(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry,\n \t\tDEBUG(\"port %u found MR for %p on final lookup, abort\",\n \t\t dev->data->port_id, (void *)addr);\n \t\trte_rwlock_write_unlock(&sh->mr.rwlock);\n-\t\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\t\trte_mcfg_mem_read_unlock();\n \t\t/*\n \t\t * Must be unlocked before calling rte_free() because\n \t\t * mlx5_mr_mem_event_free_cb() can be called inside.\n@@ -790,12 +789,12 @@ mlx5_mr_create_primary(struct rte_eth_dev *dev, struct mlx5_mr_cache *entry,\n \t/* Lookup can't fail. */\n \tassert(entry->lkey != UINT32_MAX);\n \trte_rwlock_write_unlock(&sh->mr.rwlock);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_unlock();\n \treturn entry->lkey;\n err_mrlock:\n \trte_rwlock_write_unlock(&sh->mr.rwlock);\n err_memlock:\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_unlock();\n err_nolock:\n \t/*\n \t * In case of error, as this can be called in a datapath, a warning\ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex e743695e4..c3ab9a21d 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -125,7 +125,6 @@ is_vhost_user_by_type(const char *path)\n int\n virtio_user_start_device(struct virtio_user_dev *dev)\n {\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n \tuint64_t features;\n \tint ret;\n \n@@ -142,7 +141,7 @@ virtio_user_start_device(struct virtio_user_dev *dev)\n \t * replaced when we get proper supports from the\n \t * memory subsystem in the future.\n \t */\n-\trte_rwlock_read_lock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_lock();\n \tpthread_mutex_lock(&dev->mutex);\n \n \tif (is_vhost_user_by_type(dev->path) && dev->vhostfd < 0)\n@@ -180,12 +179,12 @@ virtio_user_start_device(struct virtio_user_dev *dev)\n \n \tdev->started = true;\n \tpthread_mutex_unlock(&dev->mutex);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_unlock();\n \n \treturn 0;\n error:\n \tpthread_mutex_unlock(&dev->mutex);\n-\trte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);\n+\trte_mcfg_mem_read_unlock();\n \t/* TODO: free resource here or caller to check */\n \treturn -1;\n }\n", "prefixes": [ "v3", "02/14" ] }{ "id": 55487, "url": "