Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55482/?format=api
{ "id": 55482, "url": "http://patches.dpdk.org/api/patches/55482/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1561635235-22238-7-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1561635235-22238-7-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1561635235-22238-7-git-send-email-david.marchand@redhat.com", "date": "2019-06-27T11:33:52", "name": "[6/9] net/atlantic: add missing experimental api tags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f5e06d3b2fae2fbac6f9909076a2d56c7b21c458", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1561635235-22238-7-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 5197, "url": "http://patches.dpdk.org/api/series/5197/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5197", "date": "2019-06-27T11:33:47", "name": "experimental tags fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/5197/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55482/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/55482/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CC68E5B3E;\n\tThu, 27 Jun 2019 13:34:42 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 2A5675680;\n\tThu, 27 Jun 2019 13:34:40 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 86FA9C057F3B;\n\tThu, 27 Jun 2019 11:34:34 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-76.brq.redhat.com\n\t[10.40.204.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CB07B1975B;\n\tThu, 27 Jun 2019 11:34:30 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "nhorman@tuxdriver.com, aconole@redhat.com, thomas@monjalon.net,\n\tstable@dpdk.org, Igor Russkikh <igor.russkikh@aquantia.com>,\n\tPavel Belous <pavel.belous@aquantia.com>", "Date": "Thu, 27 Jun 2019 13:33:52 +0200", "Message-Id": "<1561635235-22238-7-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]); Thu, 27 Jun 2019 11:34:39 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 6/9] net/atlantic: add missing experimental api\n\ttags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Those symbols are declared in the library map but the prototypes are\nmissing the experimental tag.\nWithout it, existing users won't notice it is experimental.\n\nFixes: ec0dec44ecb9 (\"net/atlantic: enable MACsec configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n drivers/net/atlantic/rte_pmd_atlantic.c | 12 ++++++------\n drivers/net/atlantic/rte_pmd_atlantic.h | 24 ++++++++++++++++++++++++\n 2 files changed, 30 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/rte_pmd_atlantic.c b/drivers/net/atlantic/rte_pmd_atlantic.c\nindex 5bf4da2..2962f5c 100644\n--- a/drivers/net/atlantic/rte_pmd_atlantic.c\n+++ b/drivers/net/atlantic/rte_pmd_atlantic.c\n@@ -8,7 +8,7 @@\n #include \"atl_ethdev.h\"\n \n \n-__rte_experimental int\n+int\n rte_pmd_atl_macsec_enable(uint16_t port,\n \t\t\t uint8_t encr, uint8_t repl_prot)\n {\n@@ -24,7 +24,7 @@\n \treturn atl_macsec_enable(dev, encr, repl_prot);\n }\n \n-__rte_experimental int\n+int\n rte_pmd_atl_macsec_disable(uint16_t port)\n {\n \tstruct rte_eth_dev *dev;\n@@ -39,7 +39,7 @@\n \treturn atl_macsec_disable(dev);\n }\n \n-__rte_experimental int\n+int\n rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac)\n {\n \tstruct rte_eth_dev *dev;\n@@ -54,7 +54,7 @@\n \treturn atl_macsec_config_txsc(dev, mac);\n }\n \n-__rte_experimental int\n+int\n rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi)\n {\n \tstruct rte_eth_dev *dev;\n@@ -69,7 +69,7 @@\n \treturn atl_macsec_config_rxsc(dev, mac, pi);\n }\n \n-__rte_experimental int\n+int\n rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an,\n \t\t\t\t uint32_t pn, uint8_t *key)\n {\n@@ -85,7 +85,7 @@\n \treturn atl_macsec_select_txsa(dev, idx, an, pn, key);\n }\n \n-__rte_experimental int\n+int\n rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an,\n \t\t\t\t uint32_t pn, uint8_t *key)\n {\ndiff --git a/drivers/net/atlantic/rte_pmd_atlantic.h b/drivers/net/atlantic/rte_pmd_atlantic.h\nindex e4db7c6..c020856 100644\n--- a/drivers/net/atlantic/rte_pmd_atlantic.h\n+++ b/drivers/net/atlantic/rte_pmd_atlantic.h\n@@ -14,6 +14,9 @@\n #include <rte_ethdev_driver.h>\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n+ *\n * Enable MACsec offload.\n *\n * @param port\n@@ -29,9 +32,13 @@\n * - (-ENODEV) if *port* invalid.\n * - (-ENOTSUP) if hardware doesn't support this feature.\n */\n+__rte_experimental\n int rte_pmd_atl_macsec_enable(uint16_t port, uint8_t encr, uint8_t repl_prot);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n+ *\n * Disable MACsec offload.\n *\n * @param port\n@@ -41,9 +48,13 @@\n * - (-ENODEV) if *port* invalid.\n * - (-ENOTSUP) if hardware doesn't support this feature.\n */\n+__rte_experimental\n int rte_pmd_atl_macsec_disable(uint16_t port);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n+ *\n * Configure Tx SC (Secure Connection).\n *\n * @param port\n@@ -55,9 +66,13 @@\n * - (-ENODEV) if *port* invalid.\n * - (-ENOTSUP) if hardware doesn't support this feature.\n */\n+__rte_experimental\n int rte_pmd_atl_macsec_config_txsc(uint16_t port, uint8_t *mac);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n+ *\n * Configure Rx SC (Secure Connection).\n *\n * @param port\n@@ -71,9 +86,13 @@\n * - (-ENODEV) if *port* invalid.\n * - (-ENOTSUP) if hardware doesn't support this feature.\n */\n+__rte_experimental\n int rte_pmd_atl_macsec_config_rxsc(uint16_t port, uint8_t *mac, uint16_t pi);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n+ *\n * Enable Tx SA (Secure Association).\n *\n * @param port\n@@ -92,10 +111,14 @@\n * - (-ENOTSUP) if hardware doesn't support this feature.\n * - (-EINVAL) if bad parameter.\n */\n+__rte_experimental\n int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an,\n \t\t\t\t uint32_t pn, uint8_t *key);\n \n /**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice\n+ *\n * Enable Rx SA (Secure Association).\n *\n * @param port\n@@ -114,6 +137,7 @@ int rte_pmd_atl_macsec_select_txsa(uint16_t port, uint8_t idx, uint8_t an,\n * - (-ENOTSUP) if hardware doesn't support this feature.\n * - (-EINVAL) if bad parameter.\n */\n+__rte_experimental\n int rte_pmd_atl_macsec_select_rxsa(uint16_t port, uint8_t idx, uint8_t an,\n \t\t\t\t uint32_t pn, uint8_t *key);\n \n", "prefixes": [ "6/9" ] }