Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55475/?format=api
http://patches.dpdk.org/api/patches/55475/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1561635235-22238-2-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1561635235-22238-2-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1561635235-22238-2-git-send-email-david.marchand@redhat.com", "date": "2019-06-27T11:33:47", "name": "[1/9] eal: hide internal hotplug symbol", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ffe685cfd22a212b13805b3ccd7ccabfc064102e", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1561635235-22238-2-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 5197, "url": "http://patches.dpdk.org/api/series/5197/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5197", "date": "2019-06-27T11:33:47", "name": "experimental tags fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/5197/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55475/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/55475/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 867802BF7;\n\tThu, 27 Jun 2019 13:34:18 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id B74BC2BE5;\n\tThu, 27 Jun 2019 13:34:16 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 277553082200;\n\tThu, 27 Jun 2019 11:34:16 +0000 (UTC)", "from dmarchan.remote.csb (ovpn-204-76.brq.redhat.com\n\t[10.40.204.76])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 96AD31975B;\n\tThu, 27 Jun 2019 11:34:12 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "nhorman@tuxdriver.com, aconole@redhat.com, thomas@monjalon.net,\n\tstable@dpdk.org", "Date": "Thu, 27 Jun 2019 13:33:47 +0200", "Message-Id": "<1561635235-22238-2-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>", "References": "<1561635235-22238-1-git-send-email-david.marchand@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.47]); Thu, 27 Jun 2019 11:34:16 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 1/9] eal: hide internal hotplug symbol", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This api was experimental and not properly marked in the map file.\nBut looking more closely, this is just an internal wrapper for EAL init.\nHide it in the hotplug code.\n\nFixes: 244d5130719c (\"eal: enable hotplug on multi-process\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_eal/common/hotplug_mp.c | 2 +-\n lib/librte_eal/common/hotplug_mp.h | 9 +++++++++\n lib/librte_eal/common/include/rte_eal.h | 9 ---------\n lib/librte_eal/linux/eal/eal.c | 3 ++-\n 4 files changed, 12 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c\nindex 4f316ba..ee79190 100644\n--- a/lib/librte_eal/common/hotplug_mp.c\n+++ b/lib/librte_eal/common/hotplug_mp.c\n@@ -438,7 +438,7 @@ int eal_dev_hotplug_request_to_secondary(struct eal_dev_mp_req *req)\n \treturn 0;\n }\n \n-int rte_mp_dev_hotplug_init(void)\n+int eal_mp_dev_hotplug_init(void)\n {\n \tint ret;\n \ndiff --git a/lib/librte_eal/common/hotplug_mp.h b/lib/librte_eal/common/hotplug_mp.h\nindex 597fde3..8fcf9b5 100644\n--- a/lib/librte_eal/common/hotplug_mp.h\n+++ b/lib/librte_eal/common/hotplug_mp.h\n@@ -29,6 +29,15 @@ struct eal_dev_mp_req {\n };\n \n /**\n+ * Register all mp action callbacks for hotplug.\n+ *\n+ * @return\n+ * 0 on success, negative on error.\n+ */\n+int\n+eal_mp_dev_hotplug_init(void);\n+\n+/**\n * This is a synchronous wrapper for secondary process send\n * request to primary process, this is invoked when an attach\n * or detach request is issued from primary process.\ndiff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h\nindex cf701e1..27808a3 100644\n--- a/lib/librte_eal/common/include/rte_eal.h\n+++ b/lib/librte_eal/common/include/rte_eal.h\n@@ -409,15 +409,6 @@ typedef int (*rte_mp_async_reply_t)(const struct rte_mp_msg *request,\n rte_mp_reply(struct rte_mp_msg *msg, const char *peer);\n \n /**\n- * Register all mp action callbacks for hotplug.\n- *\n- * @return\n- * 0 on success, negative on error.\n- */\n-int __rte_experimental\n-rte_mp_dev_hotplug_init(void);\n-\n-/**\n * Usage function typedef used by the application usage function.\n *\n * Use this function typedef to define and call rte_set_application_usage_hook()\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex d96ed3a..ea7d09c 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -59,6 +59,7 @@\n #include \"eal_hugepages.h\"\n #include \"eal_options.h\"\n #include \"eal_vfio.h\"\n+#include \"hotplug_mp.h\"\n \n #define MEMSIZE_IF_NO_HUGE_PAGE (64ULL * 1024ULL * 1024ULL)\n \n@@ -1062,7 +1063,7 @@ static void rte_eal_init_alert(const char *msg)\n \t}\n \n \t/* register multi-process action callbacks for hotplug */\n-\tif (rte_mp_dev_hotplug_init() < 0) {\n+\tif (eal_mp_dev_hotplug_init() < 0) {\n \t\trte_eal_init_alert(\"failed to register mp callback for hotplug\");\n \t\treturn -1;\n \t}\n", "prefixes": [ "1/9" ] }{ "id": 55475, "url": "