Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55377/?format=api
{ "id": 55377, "url": "http://patches.dpdk.org/api/patches/55377/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625211520.43181-4-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625211520.43181-4-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625211520.43181-4-honnappa.nagarahalli@arm.com", "date": "2019-06-25T21:15:20", "name": "[3/3] lib/hash: adjust tbl_chng_cnt position", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a4b083a88bf2b87913bb12439a8b1e6b2eb5aa73", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625211520.43181-4-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 5166, "url": "http://patches.dpdk.org/api/series/5166/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5166", "date": "2019-06-25T21:15:17", "name": "lib/hash: perf improvements for lock-free", "version": 1, "mbox": "http://patches.dpdk.org/series/5166/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55377/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55377/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E76771B9AF;\n\tTue, 25 Jun 2019 23:15:46 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n\tby dpdk.org (Postfix) with ESMTP id C4C581B99D;\n\tTue, 25 Jun 2019 23:15:40 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2AD89106F;\n\tTue, 25 Jun 2019 14:15:40 -0700 (PDT)", "from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com\n\t[10.118.12.65])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t195F73F7D8; Tue, 25 Jun 2019 14:15:40 -0700 (PDT)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "yipeng1.wang@intel.com, sameh.gobriel@intel.com,\n\tbruce.richardson@intel.com, pablo.de.lara.guarch@intel.com,\n\thonnappa.nagarahalli@arm.com", "Cc": "gavin.hu@arm.com, ruifeng.wang@arm.com, dev@dpdk.org, nd@arm.com,\n\tstable@dpdk.org", "Date": "Tue, 25 Jun 2019 16:15:20 -0500", "Message-Id": "<20190625211520.43181-4-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190625211520.43181-1-honnappa.nagarahalli@arm.com>", "References": "<20190625211520.43181-1-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH 3/3] lib/hash: adjust tbl_chng_cnt position", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "tbl_chng_cnt is one of the first elements of the structure used in\nthe lookup. Move it to the beginning of the cache line to gain\nperformance.\n\nFixes: e605a1d36 (\"hash: add lock-free r/w concurrency\")\nCc: stable@dpdk.org\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\nTested-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/librte_hash/rte_cuckoo_hash.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_hash/rte_cuckoo_hash.h b/lib/librte_hash/rte_cuckoo_hash.h\nindex fb19bb27d..af6451b5c 100644\n--- a/lib/librte_hash/rte_cuckoo_hash.h\n+++ b/lib/librte_hash/rte_cuckoo_hash.h\n@@ -170,7 +170,9 @@ struct rte_hash {\n \n \t/* Fields used in lookup */\n \n-\tuint32_t key_len __rte_cache_aligned;\n+\tuint32_t *tbl_chng_cnt __rte_cache_aligned;\n+\t/**< Indicates if the hash table changed from last read. */\n+\tuint32_t key_len;\n \t/**< Length of hash key. */\n \tuint8_t hw_trans_mem_support;\n \t/**< If hardware transactional memory is used. */\n@@ -218,8 +220,6 @@ struct rte_hash {\n \t * is piggy-backed to freeing of the key index.\n \t */\n \tuint32_t *ext_bkt_to_free;\n-\tuint32_t *tbl_chng_cnt;\n-\t/**< Indicates if the hash table changed from last read. */\n } __rte_cache_aligned;\n \n struct queue_node {\n", "prefixes": [ "3/3" ] }