Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55368/?format=api
{ "id": 55368, "url": "http://patches.dpdk.org/api/patches/55368/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/53ac95842cf06c1c708abf78d8c3ab6c521cee30.1561478388.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<53ac95842cf06c1c708abf78d8c3ab6c521cee30.1561478388.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/53ac95842cf06c1c708abf78d8c3ab6c521cee30.1561478388.git.anatoly.burakov@intel.com", "date": "2019-06-25T16:05:25", "name": "[v2,13/14] eal: unify internal config initialization", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "659604bbd7716324d9d025e1fb7af004fed1b5c9", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/53ac95842cf06c1c708abf78d8c3ab6c521cee30.1561478388.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 5162, "url": "http://patches.dpdk.org/api/series/5162/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5162", "date": "2019-06-25T16:05:12", "name": "Make shared memory config non-public", "version": 2, "mbox": "http://patches.dpdk.org/series/5162/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55368/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55368/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EEC651BB74;\n\tTue, 25 Jun 2019 18:06:15 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 8062C1BAB5\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 18:05:56 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 09:05:56 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga005.jf.intel.com with ESMTP; 25 Jun 2019 09:05:54 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"336894858\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, david.marchand@redhat.com,\n\tthomas@monjalon.net, stephen@networkplumber.org", "Date": "Tue, 25 Jun 2019 17:05:25 +0100", "Message-Id": "<53ac95842cf06c1c708abf78d8c3ab6c521cee30.1561478388.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<cover.1561478388.git.anatoly.burakov@intel.com>", "<cover.1561478388.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1561478388.git.anatoly.burakov@intel.com>", "<cover.1559147228.git.anatoly.burakov@intel.com>\n\t<cover.1561478388.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v2 13/14] eal: unify internal config\n\tinitialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, each EAL will update internal/shared config in their\nown way at init, resulting in needless duplication of code and\nOS-dependent behavior. Move the functions to a common file and\nadd missing FreeBSD steps.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_mcfg.c | 18 ++++++++++++++++++\n lib/librte_eal/common/eal_memcfg.h | 8 ++++++++\n lib/librte_eal/freebsd/eal/eal.c | 2 ++\n lib/librte_eal/linux/eal/eal.c | 22 ++--------------------\n 4 files changed, 30 insertions(+), 20 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_mcfg.c b/lib/librte_eal/common/eal_common_mcfg.c\nindex dc6665d6a..fe8d2b726 100644\n--- a/lib/librte_eal/common/eal_common_mcfg.c\n+++ b/lib/librte_eal/common/eal_common_mcfg.c\n@@ -31,6 +31,24 @@ eal_mcfg_wait_complete(void)\n \t\trte_pause();\n }\n \n+void\n+eal_mcfg_update_internal(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\n+\tinternal_config.legacy_mem = mcfg->legacy_mem;\n+\tinternal_config.single_file_segments = mcfg->single_file_segments;\n+}\n+\n+void\n+eal_mcfg_update_from_internal(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\n+\tmcfg->legacy_mem = internal_config.legacy_mem;\n+\tmcfg->single_file_segments = internal_config.single_file_segments;\n+}\n+\n void\n rte_mcfg_mem_read_lock(void)\n {\ndiff --git a/lib/librte_eal/common/eal_memcfg.h b/lib/librte_eal/common/eal_memcfg.h\nindex 6e2d3abc9..908542e18 100644\n--- a/lib/librte_eal/common/eal_memcfg.h\n+++ b/lib/librte_eal/common/eal_memcfg.h\n@@ -68,6 +68,14 @@ struct rte_mem_config {\n \tuint8_t dma_maskbits;\n };\n \n+/* update internal config from shared mem config */\n+void\n+eal_mcfg_update_internal(void);\n+\n+/* update shared mem config from internal config */\n+void\n+eal_mcfg_update_from_internal(void);\n+\n /* wait until primary process initialization is complete */\n void\n eal_mcfg_wait_complete(void);\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex e43e01042..81eb44670 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -350,11 +350,13 @@ rte_config_init(void)\n \tswitch (rte_config.process_type){\n \tcase RTE_PROC_PRIMARY:\n \t\trte_eal_config_create();\n+\t\teal_mcfg_update_internal();\n \t\tbreak;\n \tcase RTE_PROC_SECONDARY:\n \t\trte_eal_config_attach();\n \t\teal_mcfg_wait_complete();\n \t\trte_eal_config_reattach();\n+\t\teal_mcfg_update_from_internal();\n \t\tbreak;\n \tcase RTE_PROC_AUTO:\n \tcase RTE_PROC_INVALID:\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex 4b5deaa70..e2be87e23 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -443,24 +443,6 @@ eal_proc_type_detect(void)\n \treturn ptype;\n }\n \n-/* copies data from internal config to shared config */\n-static void\n-eal_update_mem_config(void)\n-{\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n-\tmcfg->legacy_mem = internal_config.legacy_mem;\n-\tmcfg->single_file_segments = internal_config.single_file_segments;\n-}\n-\n-/* copies data from shared config to internal config */\n-static void\n-eal_update_internal_config(void)\n-{\n-\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n-\tinternal_config.legacy_mem = mcfg->legacy_mem;\n-\tinternal_config.single_file_segments = mcfg->single_file_segments;\n-}\n-\n /* Sets up rte_config structure with the pointer to shared memory config.*/\n static void\n rte_config_init(void)\n@@ -470,13 +452,13 @@ rte_config_init(void)\n \tswitch (rte_config.process_type){\n \tcase RTE_PROC_PRIMARY:\n \t\trte_eal_config_create();\n-\t\teal_update_mem_config();\n+\t\teal_mcfg_update_from_internal();\n \t\tbreak;\n \tcase RTE_PROC_SECONDARY:\n \t\trte_eal_config_attach();\n \t\teal_mcfg_wait_complete();\n \t\trte_eal_config_reattach();\n-\t\teal_update_internal_config();\n+\t\teal_mcfg_update_internal();\n \t\tbreak;\n \tcase RTE_PROC_AUTO:\n \tcase RTE_PROC_INVALID:\n", "prefixes": [ "v2", "13/14" ] }