Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55346/?format=api
http://patches.dpdk.org/api/patches/55346/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-23-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-23-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-23-jasvinder.singh@intel.com", "date": "2019-06-25T15:32:11", "name": "[v2,22/28] sched: update sched queue stats API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "cfa23912ef2be842d50a061606c5d979d6d217d4", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-23-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55346/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 78D1F1BBEE;\n\tTue, 25 Jun 2019 17:32:55 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id C09961BADD\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:31 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:31 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:30 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711651\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:32:11 +0100", "Message-Id": "<20190625153217.24301-23-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 22/28] sched: update sched queue stats API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update queue stats read api implementation of the scheduler to allow\nconfiguration flexiblity for pipe traffic classes and queues, and subport\nlevel configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 59 ++++++++++++++++++++++++------------\n 1 file changed, 39 insertions(+), 20 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 63073aad0..cc1dcf7ab 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -284,16 +284,6 @@ enum rte_sched_subport_array {\n \te_RTE_SCHED_SUBPORT_ARRAY_TOTAL,\n };\n \n-#ifdef RTE_SCHED_COLLECT_STATS\n-\n-static inline uint32_t\n-rte_sched_port_queues_per_subport(struct rte_sched_port *port)\n-{\n-\treturn RTE_SCHED_QUEUES_PER_PIPE * port->n_pipes_per_subport;\n-}\n-\n-#endif\n-\n static inline uint32_t\n rte_sched_subport_queues(struct rte_sched_subport *subport)\n {\n@@ -318,9 +308,14 @@ rte_sched_subport_qsize(struct rte_sched_subport *subport, uint32_t qindex)\n }\n \n static inline uint32_t\n-rte_sched_port_queues_per_port(struct rte_sched_port *port)\n+rte_sched_port_queues(struct rte_sched_port *port)\n {\n-\treturn RTE_SCHED_QUEUES_PER_PIPE * port->n_pipes_per_subport * port->n_subports_per_port;\n+\tuint32_t n_queues = 0, i;\n+\n+\tfor (i = 0; i < port->n_subports_per_port; i++)\n+\t\tn_queues += rte_sched_subport_queues(port->subports[i]);\n+\n+\treturn n_queues;\n }\n \n static int\n@@ -1470,18 +1465,42 @@ rte_sched_queue_read_stats(struct rte_sched_port *port,\n \tstruct rte_sched_queue_stats *stats,\n \tuint16_t *qlen)\n {\n+\tuint32_t subport_id, qindex;\n+\tstruct rte_sched_subport *s;\n \tstruct rte_sched_queue *q;\n \tstruct rte_sched_queue_extra *qe;\n \n \t/* Check user parameters */\n-\tif ((port == NULL) ||\n-\t (queue_id >= rte_sched_port_queues_per_port(port)) ||\n-\t\t(stats == NULL) ||\n-\t\t(qlen == NULL)) {\n-\t\treturn -1;\n-\t}\n-\tq = port->queue + queue_id;\n-\tqe = port->queue_extra + queue_id;\n+\tif (port == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter port \\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (queue_id >= rte_sched_port_queues(port)) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for queue id \\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (stats == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter stats \\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (qlen == NULL) {\n+\t\tRTE_LOG(ERR, SCHED,\n+\t\t\t\"%s: Incorrect value for parameter qlen \\n\", __func__);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tsubport_id = (queue_id >> (port->max_subport_pipes_log2 + 4)) &\n+\t\t\t\t\t(port->n_subports_per_port - 1);\n+\ts = port->subports[subport_id];\n+\tqindex = ((1 << (port->max_subport_pipes_log2 + 4)) - 1) & queue_id;\n+\tq = s->queue + qindex;\n+\tqe = s->queue_extra + qindex;\n \n \t/* Copy queue stats and clear */\n \tmemcpy(stats, &qe->stats, sizeof(struct rte_sched_queue_stats));\n", "prefixes": [ "v2", "22/28" ] }{ "id": 55346, "url": "