Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55345/?format=api
{ "id": 55345, "url": "http://patches.dpdk.org/api/patches/55345/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-22-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-22-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-22-jasvinder.singh@intel.com", "date": "2019-06-25T15:32:10", "name": "[v2,21/28] sched: update packet dequeue API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "889082c1e78547e35140e9d7ef17f24d109b8dd0", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-22-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55345/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55345/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 28FA71BBE9;\n\tTue, 25 Jun 2019 17:32:54 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 6B16A1BB0C\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:30 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:30 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:28 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711643\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:32:10 +0100", "Message-Id": "<20190625153217.24301-22-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 21/28] sched: update packet dequeue API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update packet dequeue api implementation to allow configuration\nflexiblity for pipe traffic classes and queues, and subport\nlevel configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 54 ++++++++++++++++++++++++++----------\n 1 file changed, 40 insertions(+), 14 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 6bdf1b831..63073aad0 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -1496,9 +1496,10 @@ rte_sched_queue_read_stats(struct rte_sched_port *port,\n #ifdef RTE_SCHED_DEBUG\n \n static inline int\n-rte_sched_port_queue_is_empty(struct rte_sched_port *port, uint32_t qindex)\n+rte_sched_port_queue_is_empty(struct rte_sched_subport *subport,\n+\tuint32_t qindex)\n {\n-\tstruct rte_sched_queue *queue = port->queue + qindex;\n+\tstruct rte_sched_queue *queue = subport->queue + qindex;\n \n \treturn queue->qr == queue->qw;\n }\n@@ -1639,7 +1640,7 @@ rte_sched_port_set_queue_empty_timestamp(struct rte_sched_port *port __rte_unuse\n #ifdef RTE_SCHED_DEBUG\n \n static inline void\n-debug_check_queue_slab(struct rte_sched_port *port, uint32_t bmp_pos,\n+debug_check_queue_slab(struct rte_sched_subport *subport, uint32_t bmp_pos,\n \t\t uint64_t bmp_slab)\n {\n \tuint64_t mask;\n@@ -1651,7 +1652,7 @@ debug_check_queue_slab(struct rte_sched_port *port, uint32_t bmp_pos,\n \tpanic = 0;\n \tfor (i = 0, mask = 1; i < 64; i++, mask <<= 1) {\n \t\tif (mask & bmp_slab) {\n-\t\t\tif (rte_sched_port_queue_is_empty(port, bmp_pos + i)) {\n+\t\t\tif (rte_sched_port_queue_is_empty(subport, bmp_pos + i)) {\n \t\t\t\tprintf(\"Queue %u (slab offset %u) is empty\\n\", bmp_pos + i, i);\n \t\t\t\tpanic = 1;\n \t\t\t}\n@@ -2702,6 +2703,7 @@ rte_sched_port_time_resync(struct rte_sched_port *port)\n \tuint64_t cycles = rte_get_tsc_cycles();\n \tuint64_t cycles_diff = cycles - port->time_cpu_cycles;\n \tuint64_t bytes_diff;\n+\tuint32_t i;\n \n \t/* Compute elapsed time in bytes */\n \tbytes_diff = rte_reciprocal_divide(cycles_diff << RTE_SCHED_TIME_SHIFT,\n@@ -2714,20 +2716,21 @@ rte_sched_port_time_resync(struct rte_sched_port *port)\n \t\tport->time = port->time_cpu_bytes;\n \n \t/* Reset pipe loop detection */\n-\tport->pipe_loop = RTE_SCHED_PIPE_INVALID;\n+\tfor (i = 0; i < port->n_subports_per_port; i++)\n+\t\tport->subports[i]->pipe_loop = RTE_SCHED_PIPE_INVALID;\n }\n \n static inline int\n-rte_sched_port_exceptions(struct rte_sched_port *port, int second_pass)\n+rte_sched_port_exceptions(struct rte_sched_subport *subport, int second_pass)\n {\n \tint exceptions;\n \n \t/* Check if any exception flag is set */\n-\texceptions = (second_pass && port->busy_grinders == 0) ||\n-\t\t(port->pipe_exhaustion == 1);\n+\texceptions = (second_pass && subport->busy_grinders == 0) ||\n+\t\t(subport->pipe_exhaustion == 1);\n \n \t/* Clear exception flags */\n-\tport->pipe_exhaustion = 0;\n+\tsubport->pipe_exhaustion = 0;\n \n \treturn exceptions;\n }\n@@ -2735,7 +2738,9 @@ rte_sched_port_exceptions(struct rte_sched_port *port, int second_pass)\n int\n rte_sched_port_dequeue(struct rte_sched_port *port, struct rte_mbuf **pkts, uint32_t n_pkts)\n {\n-\tuint32_t i, count;\n+\tstruct rte_sched_subport *subport;\n+\tuint32_t subport_id = port->subport_id;\n+\tuint32_t i, n_subports = 0, count;\n \n \tport->pkts_out = pkts;\n \tport->n_pkts_out = 0;\n@@ -2744,10 +2749,31 @@ rte_sched_port_dequeue(struct rte_sched_port *port, struct rte_mbuf **pkts, uint\n \n \t/* Take each queue in the grinder one step further */\n \tfor (i = 0, count = 0; ; i++) {\n-\t\tcount += grinder_handle(port, port->subport,\n-\t\t\t\ti & (RTE_SCHED_PORT_N_GRINDERS - 1));\n-\t\tif ((count == n_pkts) ||\n-\t\t rte_sched_port_exceptions(port, i >= RTE_SCHED_PORT_N_GRINDERS)) {\n+\t\tsubport = port->subports[subport_id];\n+\n+\t\tcount += grinder_handle(port, subport, i &\n+\t\t\t\t(RTE_SCHED_PORT_N_GRINDERS - 1));\n+\t\tif (count == n_pkts) {\n+\t\t\tsubport_id++;\n+\n+\t\t\tif (subport_id == port->n_subports_per_port)\n+\t\t\t\tsubport_id = 0;\n+\n+\t\t\tport->subport_id = subport_id;\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tif (rte_sched_port_exceptions(subport, i >= RTE_SCHED_PORT_N_GRINDERS)) {\n+\t\t\ti = 0;\n+\t\t\tsubport_id++;\n+\t\t\tn_subports++;\n+\t\t}\n+\n+\t\tif (subport_id == port->n_subports_per_port)\n+\t\t\tsubport_id = 0;\n+\n+\t\tif (n_subports == port->n_subports_per_port) {\n+\t\t\tport->subport_id = subport_id;\n \t\t\tbreak;\n \t\t}\n \t}\n", "prefixes": [ "v2", "21/28" ] }