Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55342/?format=api
http://patches.dpdk.org/api/patches/55342/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-19-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-19-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-19-jasvinder.singh@intel.com", "date": "2019-06-25T15:32:07", "name": "[v2,18/28] sched: update mbuf prefetch function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2ea590937b6d8430f002ced7bf9187ead193bfe3", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-19-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55342/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55342/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DDB621BBD5;\n\tTue, 25 Jun 2019 17:32:47 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id D1ED31BB20\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:25 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:25 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:23 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711602\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:32:07 +0100", "Message-Id": "<20190625153217.24301-19-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 18/28] sched: update mbuf prefetch function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update mbuf prefetch function of the scheduler grinder to allow\nconfiguration flexiblity for pipe traffic classes and queues, and\nsubport level configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 17 ++++++++++-------\n 1 file changed, 10 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 8b440637d..607fe6c18 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -2561,13 +2561,16 @@ grinder_prefetch_tc_queue_arrays(struct rte_sched_port *port, uint32_t pos)\n }\n \n static inline void\n-grinder_prefetch_mbuf(struct rte_sched_port *port, uint32_t pos)\n+grinder_prefetch_mbuf(struct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n+\tstruct rte_mbuf **qbase;\n \tuint32_t qpos = grinder->qpos;\n-\tstruct rte_mbuf **qbase = grinder->qbase[qpos];\n-\tuint16_t qsize = grinder->qsize[qpos];\n-\tuint16_t qr = grinder->queue[qpos]->qr & (qsize - 1);\n+\tuint16_t qsize, qr;\n+\n+\tqbase = grinder->qbase[qpos];\n+\tqsize = grinder->qsize[qpos];\n+\tqr = grinder->queue[qpos]->qr & (qsize - 1);\n \n \tgrinder->pkt = qbase[qr];\n \trte_prefetch0(grinder->pkt);\n@@ -2612,7 +2615,7 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \n \tcase e_GRINDER_PREFETCH_MBUF:\n \t{\n-\t\tgrinder_prefetch_mbuf(port, pos);\n+\t\tgrinder_prefetch_mbuf(port->subport, pos);\n \n \t\tgrinder->state = e_GRINDER_READ_MBUF;\n \t\treturn 0;\n@@ -2627,7 +2630,7 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \t\t/* Look for next packet within the same TC */\n \t\tif (result && grinder->qmask) {\n \t\t\tgrinder_wrr(port->subport, pos);\n-\t\t\tgrinder_prefetch_mbuf(port, pos);\n+\t\t\tgrinder_prefetch_mbuf(port->subport, pos);\n \n \t\t\treturn 1;\n \t\t}\n", "prefixes": [ "v2", "18/28" ] }{ "id": 55342, "url": "