Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55341/?format=api
http://patches.dpdk.org/api/patches/55341/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-18-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-18-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-18-jasvinder.singh@intel.com", "date": "2019-06-25T15:32:06", "name": "[v2,17/28] sched: modify credits update function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6ed86dd85fefd810f24f80959114ffcd1d411cee", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-18-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55341/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55341/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 358B01BBB4;\n\tTue, 25 Jun 2019 17:32:46 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 7A91B1BB09\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:24 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:23 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:22 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711587\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:32:06 +0100", "Message-Id": "<20190625153217.24301-18-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 17/28] sched: modify credits update function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Modify credits update function of scheduler grinder to allow\nconfiguration flexiblity for pipe traffic classes and queues, and\nsubport level configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 75 +++++++++++++++++++-----------------\n 1 file changed, 40 insertions(+), 35 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 90c41e549..8b440637d 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -1958,13 +1958,14 @@ rte_sched_port_enqueue(struct rte_sched_port *port, struct rte_mbuf **pkts,\n #ifndef RTE_SCHED_SUBPORT_TC_OV\n \n static inline void\n-grinder_credits_update(struct rte_sched_port *port, uint32_t pos)\n+grinder_credits_update(struct rte_sched_port *port,\n+\tstruct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n-\tstruct rte_sched_subport *subport = grinder->subport;\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n \tstruct rte_sched_pipe *pipe = grinder->pipe;\n \tstruct rte_sched_pipe_profile *params = grinder->pipe_params;\n \tuint64_t n_periods;\n+\tuint32_t i;\n \n \t/* Subport TB */\n \tn_periods = (port->time - subport->tb_time) / subport->tb_period;\n@@ -1980,19 +1981,17 @@ grinder_credits_update(struct rte_sched_port *port, uint32_t pos)\n \n \t/* Subport TCs */\n \tif (unlikely(port->time >= subport->tc_time)) {\n-\t\tsubport->tc_credits[0] = subport->tc_credits_per_period[0];\n-\t\tsubport->tc_credits[1] = subport->tc_credits_per_period[1];\n-\t\tsubport->tc_credits[2] = subport->tc_credits_per_period[2];\n-\t\tsubport->tc_credits[3] = subport->tc_credits_per_period[3];\n+\t\tfor (i = 0; i <= RTE_SCHED_TRAFFIC_CLASS_BE; i++)\n+\t\t\tsubport->tc_credits[i] = subport->tc_credits_per_period[i];\n+\n \t\tsubport->tc_time = port->time + subport->tc_period;\n \t}\n \n \t/* Pipe TCs */\n \tif (unlikely(port->time >= pipe->tc_time)) {\n-\t\tpipe->tc_credits[0] = params->tc_credits_per_period[0];\n-\t\tpipe->tc_credits[1] = params->tc_credits_per_period[1];\n-\t\tpipe->tc_credits[2] = params->tc_credits_per_period[2];\n-\t\tpipe->tc_credits[3] = params->tc_credits_per_period[3];\n+\t\tfor (i = 0; i <= RTE_SCHED_TRAFFIC_CLASS_BE; i++)\n+\t\t\tpipe->tc_credits[i] = params->tc_credits_per_period[i];\n+\n \t\tpipe->tc_time = port->time + params->tc_period;\n \t}\n }\n@@ -2000,26 +1999,34 @@ grinder_credits_update(struct rte_sched_port *port, uint32_t pos)\n #else\n \n static inline uint32_t\n-grinder_tc_ov_credits_update(struct rte_sched_port *port, uint32_t pos)\n+grinder_tc_ov_credits_update(struct rte_sched_port *port,\n+\tstruct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n-\tstruct rte_sched_subport *subport = grinder->subport;\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n+\tstruct rte_sched_pipe *pipe = grinder->pipe;\n \tuint32_t tc_ov_consumption[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n-\tuint32_t tc_ov_consumption_max;\n+\tuint32_t tc_consumption = 0, tc_ov_consumption_max;\n \tuint32_t tc_ov_wm = subport->tc_ov_wm;\n+\tuint32_t i;\n \n \tif (subport->tc_ov == 0)\n \t\treturn subport->tc_ov_wm_max;\n \n-\ttc_ov_consumption[0] = subport->tc_credits_per_period[0] - subport->tc_credits[0];\n-\ttc_ov_consumption[1] = subport->tc_credits_per_period[1] - subport->tc_credits[1];\n-\ttc_ov_consumption[2] = subport->tc_credits_per_period[2] - subport->tc_credits[2];\n-\ttc_ov_consumption[3] = subport->tc_credits_per_period[3] - subport->tc_credits[3];\n+\tfor (i = 0; i < RTE_SCHED_TRAFFIC_CLASS_BE; i++) {\n+\t\ttc_ov_consumption[i] =\n+\t\t\tsubport->tc_credits_per_period[i] - subport->tc_credits[i];\n+\t\ttc_consumption += tc_ov_consumption[i];\n+\t}\n \n-\ttc_ov_consumption_max = subport->tc_credits_per_period[3] -\n-\t\t(tc_ov_consumption[0] + tc_ov_consumption[1] + tc_ov_consumption[2]);\n+\ttc_ov_consumption[RTE_SCHED_TRAFFIC_CLASS_BE] =\n+\t\tsubport->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE] -\n+\t\tsubport->tc_credits[RTE_SCHED_TRAFFIC_CLASS_BE];\n \n-\tif (tc_ov_consumption[3] > (tc_ov_consumption_max - port->mtu)) {\n+\ttc_ov_consumption_max =\n+\t\tsubport->tc_credits_per_period[RTE_SCHED_TRAFFIC_CLASS_BE] - tc_consumption;\n+\n+\tif (tc_ov_consumption[RTE_SCHED_TRAFFIC_CLASS_BE] >\n+\t\t(tc_ov_consumption_max - port->mtu)) {\n \t\ttc_ov_wm -= tc_ov_wm >> 7;\n \t\tif (tc_ov_wm < subport->tc_ov_wm_min)\n \t\t\ttc_ov_wm = subport->tc_ov_wm_min;\n@@ -2035,13 +2042,14 @@ grinder_tc_ov_credits_update(struct rte_sched_port *port, uint32_t pos)\n }\n \n static inline void\n-grinder_credits_update(struct rte_sched_port *port, uint32_t pos)\n+grinder_credits_update(struct rte_sched_port *port,\n+\tstruct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n-\tstruct rte_sched_subport *subport = grinder->subport;\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n \tstruct rte_sched_pipe *pipe = grinder->pipe;\n \tstruct rte_sched_pipe_profile *params = grinder->pipe_params;\n \tuint64_t n_periods;\n+\tuint32_t i;\n \n \t/* Subport TB */\n \tn_periods = (port->time - subport->tb_time) / subport->tb_period;\n@@ -2057,12 +2065,10 @@ grinder_credits_update(struct rte_sched_port *port, uint32_t pos)\n \n \t/* Subport TCs */\n \tif (unlikely(port->time >= subport->tc_time)) {\n-\t\tsubport->tc_ov_wm = grinder_tc_ov_credits_update(port, pos);\n+\t\tsubport->tc_ov_wm = grinder_tc_ov_credits_update(port, subport, pos);\n \n-\t\tsubport->tc_credits[0] = subport->tc_credits_per_period[0];\n-\t\tsubport->tc_credits[1] = subport->tc_credits_per_period[1];\n-\t\tsubport->tc_credits[2] = subport->tc_credits_per_period[2];\n-\t\tsubport->tc_credits[3] = subport->tc_credits_per_period[3];\n+\t\tfor (i = 0; i <= RTE_SCHED_TRAFFIC_CLASS_BE; i++)\n+\t\t\tsubport->tc_credits[i] = subport->tc_credits_per_period[i];\n \n \t\tsubport->tc_time = port->time + subport->tc_period;\n \t\tsubport->tc_ov_period_id++;\n@@ -2070,10 +2076,9 @@ grinder_credits_update(struct rte_sched_port *port, uint32_t pos)\n \n \t/* Pipe TCs */\n \tif (unlikely(port->time >= pipe->tc_time)) {\n-\t\tpipe->tc_credits[0] = params->tc_credits_per_period[0];\n-\t\tpipe->tc_credits[1] = params->tc_credits_per_period[1];\n-\t\tpipe->tc_credits[2] = params->tc_credits_per_period[2];\n-\t\tpipe->tc_credits[3] = params->tc_credits_per_period[3];\n+\t\tfor (i = 0; i <= RTE_SCHED_TRAFFIC_CLASS_BE; i++)\n+\t\t\tpipe->tc_credits[i] = params->tc_credits_per_period[i];\n+\n \t\tpipe->tc_time = port->time + params->tc_period;\n \t}\n \n@@ -2599,7 +2604,7 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \n \t\tgrinder->pipe_params = port->pipe_profiles + pipe->profile;\n \t\tgrinder_prefetch_tc_queue_arrays(port, pos);\n-\t\tgrinder_credits_update(port, pos);\n+\t\tgrinder_credits_update(port, port->subport, pos);\n \n \t\tgrinder->state = e_GRINDER_PREFETCH_MBUF;\n \t\treturn 0;\n", "prefixes": [ "v2", "17/28" ] }{ "id": 55341, "url": "