Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55339/?format=api
{ "id": 55339, "url": "http://patches.dpdk.org/api/patches/55339/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-16-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-16-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-16-jasvinder.singh@intel.com", "date": "2019-06-25T15:32:04", "name": "[v2,15/28] sched: update pipe and tc queues prefetch", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e021edd947203fb13f42fae9d3e21b89560b5744", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-16-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55339/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55339/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1A4451BB7D;\n\tTue, 25 Jun 2019 17:32:41 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 5069B1BA92\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:21 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:20 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:19 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711554\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:32:04 +0100", "Message-Id": "<20190625153217.24301-16-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 15/28] sched: update pipe and tc queues\n\tprefetch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update pipe and tc queues prefetch functions to allow\nconfiguration flexiblity for pipe traffic classes and\nqueues, and subport level configuration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 41 ++++++++++++++++++++++--------------\n 1 file changed, 25 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 382d9d929..00ee9e7a2 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -2487,9 +2487,9 @@ grinder_wrr(struct rte_sched_port *port, uint32_t pos)\n #define grinder_evict(port, pos)\n \n static inline void\n-grinder_prefetch_pipe(struct rte_sched_port *port, uint32_t pos)\n+grinder_prefetch_pipe(struct rte_sched_subport *subport, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n+\tstruct rte_sched_grinder *grinder = subport->grinder + pos;\n \n \trte_prefetch0(grinder->pipe);\n \trte_prefetch0(grinder->queue[0]);\n@@ -2498,23 +2498,32 @@ grinder_prefetch_pipe(struct rte_sched_port *port, uint32_t pos)\n static inline void\n grinder_prefetch_tc_queue_arrays(struct rte_sched_port *port, uint32_t pos)\n {\n-\tstruct rte_sched_grinder *grinder = port->grinder + pos;\n-\tuint16_t qsize, qr[4];\n+\tstruct rte_sched_grinder *grinder = port->subport->grinder + pos;\n+\tstruct rte_sched_pipe *pipe = grinder->pipe;\n+\tstruct rte_sched_queue *queue;\n+\tuint32_t i;\n+\tuint16_t qsize, qr[RTE_SCHED_MAX_QUEUES_PER_TC];\n \n-\tqsize = grinder->qsize[0];\n-\tqr[0] = grinder->queue[0]->qr & (qsize - 1);\n-\tqr[1] = grinder->queue[1]->qr & (qsize - 1);\n-\tqr[2] = grinder->queue[2]->qr & (qsize - 1);\n-\tqr[3] = grinder->queue[3]->qr & (qsize - 1);\n+\tgrinder->qpos = 0;\n+\tif (grinder->tc_index < RTE_SCHED_TRAFFIC_CLASS_BE) {\n+\t\tqueue = grinder->queue[0];\n+\t\tqsize = grinder->qsize[0];\n+\t\tqr[0] = queue->qr & (qsize - 1);\n \n-\trte_prefetch0(grinder->qbase[0] + qr[0]);\n-\trte_prefetch0(grinder->qbase[1] + qr[1]);\n+\t\trte_prefetch0(grinder->qbase[0] + qr[0]);\n+\t\treturn;\n+\t}\n+\n+\tfor (i = 0; i < pipe->n_be_queues; i++) {\n+\t\tqueue = grinder->queue[i];\n+\t\tqsize = grinder->qsize[i];\n+\t\tqr[i] = queue->qr & (qsize - 1);\n+\n+\t\trte_prefetch0(grinder->qbase[i] + qr[i]);\n+\t}\n \n \tgrinder_wrr_load(port, pos);\n \tgrinder_wrr(port, pos);\n-\n-\trte_prefetch0(grinder->qbase[2] + qr[2]);\n-\trte_prefetch0(grinder->qbase[3] + qr[3]);\n }\n \n static inline void\n@@ -2545,7 +2554,7 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \tcase e_GRINDER_PREFETCH_PIPE:\n \t{\n \t\tif (grinder_next_pipe(port->subport, pos)) {\n-\t\t\tgrinder_prefetch_pipe(port, pos);\n+\t\t\tgrinder_prefetch_pipe(port->subport, pos);\n \t\t\tport->busy_grinders++;\n \n \t\t\tgrinder->state = e_GRINDER_PREFETCH_TC_QUEUE_ARRAYS;\n@@ -2606,7 +2615,7 @@ grinder_handle(struct rte_sched_port *port, uint32_t pos)\n \n \t\t/* Look for another active pipe */\n \t\tif (grinder_next_pipe(port->subport, pos)) {\n-\t\t\tgrinder_prefetch_pipe(port, pos);\n+\t\t\tgrinder_prefetch_pipe(port->subport, pos);\n \n \t\t\tgrinder->state = e_GRINDER_PREFETCH_TC_QUEUE_ARRAYS;\n \t\t\treturn result;\n", "prefixes": [ "v2", "15/28" ] }