Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55333/?format=api
http://patches.dpdk.org/api/patches/55333/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-10-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-10-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-10-jasvinder.singh@intel.com", "date": "2019-06-25T15:31:58", "name": "[v2,09/28] sched: update pkt read and write API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "35018f7634ca29d7a1c9eb26e228e7273dc20d6e", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-10-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55333/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55333/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 90ABE1BB14;\n\tTue, 25 Jun 2019 17:32:25 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 4D2041BA90\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:13 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:12 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:11 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711482\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:31:58 +0100", "Message-Id": "<20190625153217.24301-10-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 09/28] sched: update pkt read and write API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update run time packet read and write api implementation\nto allow configuration flexiblity for pipe traffic classes\nand queues, and subport level configuration of the pipe\nparameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 32 +++++++++++++++++---------------\n lib/librte_sched/rte_sched.h | 8 ++++----\n 2 files changed, 21 insertions(+), 19 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex 1999bbfa3..cd82fd918 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -1433,17 +1433,15 @@ rte_sched_port_pipe_profile_add(struct rte_sched_port *port,\n \n static inline uint32_t\n rte_sched_port_qindex(struct rte_sched_port *port,\n+\tstruct rte_sched_subport *s,\n \tuint32_t subport,\n \tuint32_t pipe,\n-\tuint32_t traffic_class,\n \tuint32_t queue)\n {\n \treturn ((subport & (port->n_subports_per_port - 1)) <<\n-\t\t\t(port->n_pipes_per_subport_log2 + 4)) |\n-\t\t\t((pipe & (port->n_pipes_per_subport - 1)) << 4) |\n-\t\t\t((traffic_class &\n-\t\t\t (RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE - 1)) << 2) |\n-\t\t\t(queue & (RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS - 1));\n+\t\t\t(port->max_subport_pipes_log2 + 4)) |\n+\t\t\t((pipe & (s->n_subport_pipes - 1)) << 4) |\n+\t\t\t(queue & (RTE_SCHED_QUEUES_PER_PIPE - 1));\n }\n \n void\n@@ -1453,9 +1451,9 @@ rte_sched_port_pkt_write(struct rte_sched_port *port,\n \t\t\t uint32_t traffic_class,\n \t\t\t uint32_t queue, enum rte_color color)\n {\n-\tuint32_t queue_id = rte_sched_port_qindex(port, subport, pipe,\n-\t\t\ttraffic_class, queue);\n-\trte_mbuf_sched_set(pkt, queue_id, traffic_class, (uint8_t)color);\n+\tstruct rte_sched_subport *s = port->subports[subport];\n+\tuint32_t qindex = rte_sched_port_qindex(port, s, subport, pipe, queue);\n+\trte_mbuf_sched_set(pkt, qindex, traffic_class, (uint8_t)color);\n }\n \n void\n@@ -1464,13 +1462,17 @@ rte_sched_port_pkt_read_tree_path(struct rte_sched_port *port,\n \t\t\t\t uint32_t *subport, uint32_t *pipe,\n \t\t\t\t uint32_t *traffic_class, uint32_t *queue)\n {\n-\tuint32_t queue_id = rte_mbuf_sched_queue_get(pkt);\n+\tstruct rte_sched_subport *s;\n+\tuint32_t qindex = rte_mbuf_sched_queue_get(pkt);\n+\tuint32_t tc_id = rte_mbuf_sched_traffic_class_get(pkt);\n+\n+\t*subport = (qindex >> (port->max_subport_pipes_log2 + 4)) &\n+\t\t(port->n_subports_per_port - 1);\n \n-\t*subport = queue_id >> (port->n_pipes_per_subport_log2 + 4);\n-\t*pipe = (queue_id >> 4) & (port->n_pipes_per_subport - 1);\n-\t*traffic_class = (queue_id >> 2) &\n-\t\t\t\t(RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE - 1);\n-\t*queue = queue_id & (RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS - 1);\n+\ts = port->subports[*subport];\n+\t*pipe = (qindex >> 4) & (s->n_subport_pipes - 1);\n+\t*traffic_class = tc_id;\n+\t*queue = qindex & (RTE_SCHED_QUEUES_PER_PIPE - 1);\n }\n \n enum rte_color\ndiff --git a/lib/librte_sched/rte_sched.h b/lib/librte_sched/rte_sched.h\nindex 121e1f669..6a6ea84aa 100644\n--- a/lib/librte_sched/rte_sched.h\n+++ b/lib/librte_sched/rte_sched.h\n@@ -421,9 +421,9 @@ rte_sched_queue_read_stats(struct rte_sched_port *port,\n * @param pipe\n * Pipe ID within subport\n * @param traffic_class\n- * Traffic class ID within pipe (0 .. 3)\n+ * Traffic class ID within pipe (0 .. 8)\n * @param queue\n- * Queue ID within pipe traffic class (0 .. 3)\n+ * Queue ID within pipe traffic class (0 .. 15)\n * @param color\n * Packet color set\n */\n@@ -448,9 +448,9 @@ rte_sched_port_pkt_write(struct rte_sched_port *port,\n * @param pipe\n * Pipe ID within subport\n * @param traffic_class\n- * Traffic class ID within pipe (0 .. 3)\n+ * Traffic class ID within pipe (0 .. 8)\n * @param queue\n- * Queue ID within pipe traffic class (0 .. 3)\n+ * Queue ID within pipe traffic class (0 .. 15)\n *\n */\n void\n", "prefixes": [ "v2", "09/28" ] }{ "id": 55333, "url": "