Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55329/?format=api
{ "id": 55329, "url": "http://patches.dpdk.org/api/patches/55329/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-6-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-6-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-6-jasvinder.singh@intel.com", "date": "2019-06-25T15:31:54", "name": "[v2,05/28] sched: update port free API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a7bd99b06bbfe5b92bd48d9bd226e88ec996f8d1", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-6-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55329/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55329/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6BE901BA90;\n\tTue, 25 Jun 2019 17:32:15 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 9C4AB1BA4D\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:07 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:06 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:05 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711434\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:31:54 +0100", "Message-Id": "<20190625153217.24301-6-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 05/28] sched: update port free API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update port free api implementation to allow configuration\nflexiblity for pipe traffic classes and queues, and subport level\nconfiguration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.c | 71 ++++++++++++++++++++++++++++--------\n 1 file changed, 55 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c\nindex aea938899..22db212ed 100644\n--- a/lib/librte_sched/rte_sched.c\n+++ b/lib/librte_sched/rte_sched.c\n@@ -294,6 +294,29 @@ rte_sched_port_queues_per_subport(struct rte_sched_port *port)\n \n #endif\n \n+static inline uint32_t\n+rte_sched_subport_queues(struct rte_sched_subport *subport)\n+{\n+\treturn RTE_SCHED_QUEUES_PER_PIPE * subport->n_subport_pipes;\n+}\n+\n+static inline struct rte_mbuf **\n+rte_sched_subport_qbase(struct rte_sched_subport *subport, uint32_t qindex)\n+{\n+\tuint32_t pindex = qindex >> 4;\n+\tuint32_t qpos = qindex & 0xF;\n+\n+\treturn (subport->queue_array + pindex *\n+\t\tsubport->qsize_sum + subport->qsize_add[qpos]);\n+}\n+\n+static inline uint16_t\n+rte_sched_subport_qsize(struct rte_sched_subport *subport, uint32_t qindex)\n+{\n+\tuint32_t qpos = qindex & 0xF;\n+\treturn subport->qsize[qpos];\n+}\n+\n static inline uint32_t\n rte_sched_port_queues_per_port(struct rte_sched_port *port)\n {\n@@ -640,31 +663,47 @@ rte_sched_port_config(struct rte_sched_port_params *params)\n \treturn port;\n }\n \n-void\n-rte_sched_port_free(struct rte_sched_port *port)\n+static inline void\n+rte_sched_subport_free(struct rte_sched_subport *subport)\n {\n+\tuint32_t n_subport_queues;\n \tuint32_t qindex;\n-\tuint32_t n_queues_per_port;\n \n-\t/* Check user parameters */\n-\tif (port == NULL)\n+\tif (subport == NULL)\n \t\treturn;\n \n-\tn_queues_per_port = rte_sched_port_queues_per_port(port);\n+\tn_subport_queues = rte_sched_subport_queues(subport);\n \n \t/* Free enqueued mbufs */\n-\tfor (qindex = 0; qindex < n_queues_per_port; qindex++) {\n-\t\tstruct rte_mbuf **mbufs = rte_sched_port_qbase(port, qindex);\n-\t\tuint16_t qsize = rte_sched_port_qsize(port, qindex);\n-\t\tstruct rte_sched_queue *queue = port->queue + qindex;\n-\t\tuint16_t qr = queue->qr & (qsize - 1);\n-\t\tuint16_t qw = queue->qw & (qsize - 1);\n-\n-\t\tfor (; qr != qw; qr = (qr + 1) & (qsize - 1))\n-\t\t\trte_pktmbuf_free(mbufs[qr]);\n+\tfor (qindex = 0; qindex < n_subport_queues; qindex++) {\n+\t\tstruct rte_mbuf **mbufs =\n+\t\t\trte_sched_subport_qbase(subport, qindex);\n+\t\tuint16_t qsize = rte_sched_subport_qsize(subport, qindex);\n+\t\tif (qsize != 0) {\n+\t\t\tstruct rte_sched_queue *queue = subport->queue + qindex;\n+\t\t\tuint16_t qr = queue->qr & (qsize - 1);\n+\t\t\tuint16_t qw = queue->qw & (qsize - 1);\n+\n+\t\t\tfor (; qr != qw; qr = (qr + 1) & (qsize - 1))\n+\t\t\t\trte_pktmbuf_free(mbufs[qr]);\n+\t\t}\n \t}\n \n-\trte_bitmap_free(port->bmp);\n+\trte_bitmap_free(subport->bmp);\n+}\n+\n+void\n+rte_sched_port_free(struct rte_sched_port *port)\n+{\n+\tuint32_t i;\n+\n+\t/* Check user parameters */\n+\tif (port == NULL)\n+\t\treturn;\n+\n+\tfor (i = 0; i < port->n_subports_per_port; i++)\n+\t\trte_sched_subport_free(port->subports[i]);\n+\n \trte_free(port);\n }\n \n", "prefixes": [ "v2", "05/28" ] }