Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55326/?format=api
{ "id": 55326, "url": "http://patches.dpdk.org/api/patches/55326/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-3-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-3-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-3-jasvinder.singh@intel.com", "date": "2019-06-25T15:31:51", "name": "[v2,02/28] sched: update subport and pipe data structures", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2c17d709b2da5b070f4cdc17ef04b42958f743c4", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-3-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55326/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55326/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B31761BA59;\n\tTue, 25 Jun 2019 17:32:08 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 7A10D1B9FA\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:03 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:02 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:32:01 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711400\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:31:51 +0100", "Message-Id": "<20190625153217.24301-3-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 02/28] sched: update subport and pipe data\n\tstructures", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update subport and pipe data structures to allow configuration\nflexiblity for pipe traffic classes and queues, and subport level\nconfiguration of the pipe parameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n app/test/test_sched.c | 2 +-\n examples/qos_sched/init.c | 2 +-\n lib/librte_sched/rte_sched.h | 126 +++++++++++++++++++++++------------\n 3 files changed, 85 insertions(+), 45 deletions(-)", "diff": "diff --git a/app/test/test_sched.c b/app/test/test_sched.c\nindex 49bb9ea6f..d6651d490 100644\n--- a/app/test/test_sched.c\n+++ b/app/test/test_sched.c\n@@ -40,7 +40,7 @@ static struct rte_sched_pipe_params pipe_profile[] = {\n \t\t.tc_rate = {305175, 305175, 305175, 305175},\n \t\t.tc_period = 40,\n \n-\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},\n+\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1},\n \t},\n };\n \ndiff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c\nindex 1209bd7ce..f6e9af16b 100644\n--- a/examples/qos_sched/init.c\n+++ b/examples/qos_sched/init.c\n@@ -186,7 +186,7 @@ static struct rte_sched_pipe_params pipe_profiles[RTE_SCHED_PIPE_PROFILES_PER_PO\n \t\t.tc_ov_weight = 1,\n #endif\n \n-\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},\n+\t\t.wrr_weights = {1, 1, 1, 1, 1, 1, 1, 1},\n \t},\n };\n \ndiff --git a/lib/librte_sched/rte_sched.h b/lib/librte_sched/rte_sched.h\nindex 470a0036a..ebde07669 100644\n--- a/lib/librte_sched/rte_sched.h\n+++ b/lib/librte_sched/rte_sched.h\n@@ -114,6 +114,35 @@ extern \"C\" {\n #define RTE_SCHED_FRAME_OVERHEAD_DEFAULT 24\n #endif\n \n+/*\n+ * Pipe configuration parameters. The period and credits_per_period\n+ * parameters are measured in bytes, with one byte meaning the time\n+ * duration associated with the transmission of one byte on the\n+ * physical medium of the output port, with pipe or pipe traffic class\n+ * rate (measured as percentage of output port rate) determined as\n+ * credits_per_period divided by period. One credit represents one\n+ * byte.\n+ */\n+struct rte_sched_pipe_params {\n+\t/** Token bucket rate (measured in bytes per second) */\n+\tuint32_t tb_rate;\n+\t/** Token bucket size (measured in credits) */\n+\tuint32_t tb_size;\n+\n+\t/** Traffic class rates (measured in bytes per second) */\n+\tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n+\n+\t/** Enforcement period (measured in milliseconds) */\n+\tuint32_t tc_period;\n+#ifdef RTE_SCHED_SUBPORT_TC_OV\n+\t/** Best-effort traffic class oversubscription weight */\n+\tuint8_t tc_ov_weight;\n+#endif\n+\n+\t/** WRR weights of best-effort traffic class queues */\n+\tuint8_t wrr_weights[RTE_SCHED_BE_QUEUES_PER_PIPE];\n+};\n+\n /*\n * Subport configuration parameters. The period and credits_per_period\n * parameters are measured in bytes, with one byte meaning the time\n@@ -124,15 +153,44 @@ extern \"C\" {\n * byte.\n */\n struct rte_sched_subport_params {\n-\t/* Subport token bucket */\n-\tuint32_t tb_rate; /**< Rate (measured in bytes per second) */\n-\tuint32_t tb_size; /**< Size (measured in credits) */\n+\t/** Token bucket rate (measured in bytes per second) */\n+\tuint32_t tb_rate;\n+\n+\t/** Token bucket size (measured in credits) */\n+\tuint32_t tb_size;\n \n-\t/* Subport traffic classes */\n+\t/** Traffic class rates (measured in bytes per second) */\n \tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n-\t/**< Traffic class rates (measured in bytes per second) */\n+\n+\t/** Enforcement period for rates (measured in milliseconds) */\n \tuint32_t tc_period;\n-\t/**< Enforcement period for rates (measured in milliseconds) */\n+\n+\t/** Number of subport_pipes */\n+\tuint32_t n_subport_pipes;\n+\n+\t/** Packet queue size for each traffic class.\n+\t * All the pipes within the same subport share the similar\n+\t * configuration for the queues. Queues which are not needed, have\n+\t * zero size.\n+\t */\n+\tuint16_t qsize[RTE_SCHED_QUEUES_PER_PIPE];\n+\n+\t/** Pipe profile table.\n+\t * Every pipe is configured using one of the profiles from this table.\n+\t */\n+\tstruct rte_sched_pipe_params *pipe_profiles;\n+\n+\t/** Profiles in the pipe profile table */\n+\tuint32_t n_pipe_profiles;\n+\n+\t/** Max profiles allowed in the pipe profile table */\n+\tuint32_t n_max_pipe_profiles;\n+#ifdef RTE_SCHED_RED\n+\t/** RED parameters */\n+\tstruct rte_red_params\n+\t\tred_params[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE][RTE_COLORS];\n+\n+#endif\n };\n \n /** Subport statistics */\n@@ -155,33 +213,6 @@ struct rte_sched_subport_stats {\n #endif\n };\n \n-/*\n- * Pipe configuration parameters. The period and credits_per_period\n- * parameters are measured in bytes, with one byte meaning the time\n- * duration associated with the transmission of one byte on the\n- * physical medium of the output port, with pipe or pipe traffic class\n- * rate (measured as percentage of output port rate) determined as\n- * credits_per_period divided by period. One credit represents one\n- * byte.\n- */\n-struct rte_sched_pipe_params {\n-\t/* Pipe token bucket */\n-\tuint32_t tb_rate; /**< Rate (measured in bytes per second) */\n-\tuint32_t tb_size; /**< Size (measured in credits) */\n-\n-\t/* Pipe traffic classes */\n-\tuint32_t tc_rate[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n-\t/**< Traffic class rates (measured in bytes per second) */\n-\tuint32_t tc_period;\n-\t/**< Enforcement period (measured in milliseconds) */\n-#ifdef RTE_SCHED_SUBPORT_TC_OV\n-\tuint8_t tc_ov_weight;\t\t /**< Weight Traffic class 3 oversubscription */\n-#endif\n-\n-\t/* Pipe queues */\n-\tuint8_t wrr_weights[RTE_SCHED_QUEUES_PER_PIPE]; /**< WRR weights */\n-};\n-\n /** Queue statistics */\n struct rte_sched_queue_stats {\n \t/* Packets */\n@@ -198,16 +229,25 @@ struct rte_sched_queue_stats {\n \n /** Port configuration parameters. */\n struct rte_sched_port_params {\n-\tconst char *name; /**< String to be associated */\n-\tint socket; /**< CPU socket ID */\n-\tuint32_t rate; /**< Output port rate\n-\t\t\t\t\t * (measured in bytes per second) */\n-\tuint32_t mtu; /**< Maximum Ethernet frame size\n-\t\t\t\t\t * (measured in bytes).\n-\t\t\t\t\t * Should not include the framing overhead. */\n-\tuint32_t frame_overhead; /**< Framing overhead per packet\n-\t\t\t\t\t * (measured in bytes) */\n-\tuint32_t n_subports_per_port; /**< Number of subports */\n+\t/** Name of the port to be associated */\n+\tconst char *name;\n+\n+\t/** CPU socket ID */\n+\tint socket;\n+\n+\t/** Output port rate (measured in bytes per second) */\n+\tuint32_t rate;\n+\n+\t/** Maximum Ethernet frame size (measured in bytes).\n+\t * Should not include the framing overhead.\n+\t */\n+\tuint32_t mtu;\n+\n+\t/** Framing overhead per packet (measured in bytes) */\n+\tuint32_t frame_overhead;\n+\n+\t/** Number of subports */\n+\tuint32_t n_subports_per_port;\n \tuint32_t n_pipes_per_subport; /**< Number of pipes per subport */\n \tuint16_t qsize[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];\n \t/**< Packet queue size for each traffic class.\n", "prefixes": [ "v2", "02/28" ] }