Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55325/?format=api
{ "id": 55325, "url": "http://patches.dpdk.org/api/patches/55325/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-2-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190625153217.24301-2-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190625153217.24301-2-jasvinder.singh@intel.com", "date": "2019-06-25T15:31:50", "name": "[v2,01/28] sched: update macros for flexible config", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "da854ed59180e19631725290f4cd36c842da53e6", "submitter": { "id": 285, "url": "http://patches.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190625153217.24301-2-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 5160, "url": "http://patches.dpdk.org/api/series/5160/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5160", "date": "2019-06-25T15:31:49", "name": "sched: feature enhancements", "version": 2, "mbox": "http://patches.dpdk.org/series/5160/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55325/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55325/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0BBC71BA30;\n\tTue, 25 Jun 2019 17:32:06 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id DE88A1B9F4\n\tfor <dev@dpdk.org>; Tue, 25 Jun 2019 17:32:01 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2019 08:32:01 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.223.4])\n\tby orsmga006.jf.intel.com with ESMTP; 25 Jun 2019 08:31:59 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.63,416,1557212400\"; d=\"scan'208\";a=\"166711370\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com, Abraham Tovar <abrahamx.tovar@intel.com>, \n\tLukasz Krakowiak <lukaszx.krakowiak@intel.com>", "Date": "Tue, 25 Jun 2019 16:31:50 +0100", "Message-Id": "<20190625153217.24301-2-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190625153217.24301-1-jasvinder.singh@intel.com>", "References": "<20190528120553.2992-2-lukaszx.krakowiak@intel.com>\n\t<20190625153217.24301-1-jasvinder.singh@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 01/28] sched: update macros for flexible config", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update macros to allow configuration flexiblity for pipe traffic\nclasses and queues, and subport level configuration of the pipe\nparameters.\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\nSigned-off-by: Abraham Tovar <abrahamx.tovar@intel.com>\nSigned-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>\n---\n lib/librte_sched/rte_sched.h | 36 +++++++++++++++++++++++++-----------\n 1 file changed, 25 insertions(+), 11 deletions(-)", "diff": "diff --git a/lib/librte_sched/rte_sched.h b/lib/librte_sched/rte_sched.h\nindex 9c55a787d..470a0036a 100644\n--- a/lib/librte_sched/rte_sched.h\n+++ b/lib/librte_sched/rte_sched.h\n@@ -52,7 +52,7 @@ extern \"C\" {\n *\t multiple connections of same traffic class belonging to\n *\t the same user;\n * - Weighted Round Robin (WRR) is used to service the\n- *\t queues within same pipe traffic class.\n+ *\t queues within same pipe lowest priority traffic class (best-effort).\n *\n */\n \n@@ -66,20 +66,32 @@ extern \"C\" {\n #include \"rte_red.h\"\n #endif\n \n-/** Number of traffic classes per pipe (as well as subport).\n- * Cannot be changed.\n+/** Maximum number of queues per pipe.\n+ * Note that the multiple queues (power of 2) can only be assigned to\n+ * lowest priority (best-effort) traffic class. Other higher priority traffic\n+ * classes can only have one queue.\n+ * Can not change.\n+ *\n+ * @see struct rte_sched_subport_params\n */\n-#define RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE 4\n+#define RTE_SCHED_QUEUES_PER_PIPE 16\n \n-/** Number of queues per pipe traffic class. Cannot be changed. */\n-#define RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS 4\n+/** Number of WRR queues for best-effort traffic class per pipe.\n+ *\n+ * @see struct rte_sched_pipe_params\n+ */\n+#define RTE_SCHED_BE_QUEUES_PER_PIPE 8\n \n-/** Number of queues per pipe. */\n-#define RTE_SCHED_QUEUES_PER_PIPE \\\n-\t(RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE * \\\n-\tRTE_SCHED_QUEUES_PER_TRAFFIC_CLASS)\n+#define RTE_SCHED_QUEUES_PER_TRAFFIC_CLASS 4\n+/** Number of traffic classes per pipe (as well as subport).\n+ *\n+ * @see struct rte_sched_subport_params\n+ * @see struct rte_sched_pipe_params\n+ */\n+#define RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE \\\n+(RTE_SCHED_QUEUES_PER_PIPE - RTE_SCHED_BE_QUEUES_PER_PIPE + 1)\n \n-/** Maximum number of pipe profiles that can be defined per port.\n+/** Maximum number of pipe profiles that can be defined per subport.\n * Compile-time configurable.\n */\n #ifndef RTE_SCHED_PIPE_PROFILES_PER_PORT\n@@ -95,6 +107,8 @@ extern \"C\" {\n *\n * The FCS is considered overhead only if not included in the packet\n * length (field pkt_len of struct rte_mbuf).\n+ *\n+ * @see struct rte_sched_port_params\n */\n #ifndef RTE_SCHED_FRAME_OVERHEAD_DEFAULT\n #define RTE_SCHED_FRAME_OVERHEAD_DEFAULT 24\n", "prefixes": [ "v2", "01/28" ] }