Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55274/?format=api
{ "id": 55274, "url": "http://patches.dpdk.org/api/patches/55274/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190624204435.29452-8-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190624204435.29452-8-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190624204435.29452-8-stephen@networkplumber.org", "date": "2019-06-24T20:44:34", "name": "[v5,7/8] net/bonding: use new ethernet address parser", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "850b54f9aa7f6ab3a74ca227887395c9b630f18a", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190624204435.29452-8-stephen@networkplumber.org/mbox/", "series": [ { "id": 5140, "url": "http://patches.dpdk.org/api/series/5140/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5140", "date": "2019-06-24T20:44:27", "name": "net/ether: enhancements and optimizations", "version": 5, "mbox": "http://patches.dpdk.org/series/5140/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55274/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55274/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 17A501BCA0;\n\tMon, 24 Jun 2019 22:45:04 +0200 (CEST)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 80F771BC00\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 22:44:52 +0200 (CEST)", "by mail-pl1-f195.google.com with SMTP id g4so7534955plb.5\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 13:44:52 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tq144sm22061498pfc.103.2019.06.24.13.44.50\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 24 Jun 2019 13:44:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=;\n\tb=LeEFFLCSvl0BIbMHmWZblM2v2I8Oy4QWcuD7n9WRsZ2caBuk1ogjkEAqE+E9+ogycM\n\txCUA4CdQQ2XELQAbQwIAKeeZMyfBF1l4wChMcabICi4qpiWHRQst4j5mtPu/FmuvjBdm\n\tVbuIQ2HNiNti2OsBCtw9F9Zt2wugk8WsD8A2Xzqwam2YYrHG/IHtcTKwviAr7GkSw7TI\n\teind4+3MYBFGpKVP6xpf7JJrVpJmsooyZChtwaBGjzN/aWUkNv8k50ZKpL/OYG7EYEBc\n\tnyrQxse1QBYywNzLD894S+OH75WUuBhdGw5V/LpGK7ifju/I1FBY4sOmpbPXFNXw9fdH\n\trslA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=;\n\tb=HBf6a/pVPX6t7upuT5+p1EX4aQbiBzgorcKFcSbGuQQx4YKuTT5Nc8GQzdWXWpHi0l\n\tKxiNr/E4eT+D7bAe0IAcGfMmePjnqVBj7Yb7ewumxPiZZs1xB4POorVOAFCPXcjvCsJ9\n\tvycEPuhO69b1u08bJxpsas4q95H1QEH0/JhGjs2r5WFGmMqTwOR2GUk4+EpIBiU8uKsp\n\tU0CLQ+8Zmxc6kozvGdiIzyTuUK2o0HbuIKfTlSMVtHZXJH9LxiGapZGMJz5BFKHrWVYu\n\tv9urEpL+vtHlBg1uf12TNgJTPvfpJ/bTpTEvivf4MlwOlFtHfXHeP+i5muiDddHYjbOA\n\tncQg==", "X-Gm-Message-State": "APjAAAVB/ZsyoeWgqrfhAUfesd9DNtgbI5StveWQgSyjuJda13MI+1uh\n\t3i0vehnwkkUJ9sLmqwkjU2KvmmivDFI=", "X-Google-Smtp-Source": "APXvYqyEcI/97PaPqq1lAJ578BMBDL81LmFUZOScc02qE/hXPB+NbyRWiPm5GWcwKowWb3zZ1r1IAw==", "X-Received": "by 2002:a17:902:704a:: with SMTP id\n\th10mr41854781plt.337.1561409091399; \n\tMon, 24 Jun 2019 13:44:51 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 24 Jun 2019 13:44:34 -0700", "Message-Id": "<20190624204435.29452-8-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190624204435.29452-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190624204435.29452-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 7/8] net/bonding: use new ethernet address\n\tparser", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The cmdline library used to be the only way to parse a\nmac address. Now there is rte_ether_unformat_addr.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/bonding/Makefile | 2 +-\n drivers/net/bonding/meson.build | 2 +-\n drivers/net/bonding/rte_eth_bond_args.c | 6 +-----\n 3 files changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile\nindex 1893e3cad313..26c1782554cd 100644\n--- a/drivers/net/bonding/Makefile\n+++ b/drivers/net/bonding/Makefile\n@@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API\n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\n LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring\n-LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline\n+LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs\n LDLIBS += -lrte_pci -lrte_bus_pci\n LDLIBS += -lrte_bus_vdev\n \ndiff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build\nindex 00374edb2a9d..6267210adf5f 100644\n--- a/drivers/net/bonding/meson.build\n+++ b/drivers/net/bonding/meson.build\n@@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c\n \t'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c')\n \n deps += 'sched' # needed for rte_bitmap.h\n-deps += ['ip_frag', 'cmdline']\n+deps += ['ip_frag']\n \n install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h')\ndiff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c\nindex 01bbb06c1a84..936440fb8491 100644\n--- a/drivers/net/bonding/rte_eth_bond_args.c\n+++ b/drivers/net/bonding/rte_eth_bond_args.c\n@@ -7,9 +7,6 @@\n #include <rte_bus_pci.h>\n #include <rte_kvargs.h>\n \n-#include <cmdline_parse.h>\n-#include <cmdline_parse_etheraddr.h>\n-\n #include \"rte_eth_bond.h\"\n #include \"rte_eth_bond_private.h\"\n \n@@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused,\n \t\treturn -1;\n \n \t/* Parse MAC */\n-\treturn cmdline_parse_etheraddr(NULL, value, extra_args,\n-\t\tsizeof(struct rte_ether_addr));\n+\treturn rte_ether_unformat_addr(value, extra_args);\n }\n \n int\n", "prefixes": [ "v5", "7/8" ] }