Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55271/?format=api
{ "id": 55271, "url": "http://patches.dpdk.org/api/patches/55271/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190624204435.29452-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190624204435.29452-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190624204435.29452-5-stephen@networkplumber.org", "date": "2019-06-24T20:44:31", "name": "[v5,4/8] net/ether: use bitops to speedup comparison", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3a623087517713e32761872c2027bce939269b88", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190624204435.29452-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 5140, "url": "http://patches.dpdk.org/api/series/5140/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5140", "date": "2019-06-24T20:44:27", "name": "net/ether: enhancements and optimizations", "version": 5, "mbox": "http://patches.dpdk.org/series/5140/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55271/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69F981BC8F;\n\tMon, 24 Jun 2019 22:44:57 +0200 (CEST)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id C39A31BC7D\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 22:44:48 +0200 (CEST)", "by mail-pg1-f196.google.com with SMTP id m4so7124805pgk.0\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 13:44:48 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tq144sm22061498pfc.103.2019.06.24.13.44.46\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 24 Jun 2019 13:44:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=;\n\tb=hmBA8dHimb4tNJBmjkb8RPJREgaQyxbOmWD39IWOu+4ahr2fLqcQQ0b0Eiw6GGAQMj\n\tsb4VPW3dNmjcJ1wkQPzrMUAsIv/IDb7NjAORirSNgEfwuVkeoHqdBNDwVbxqg4dau9l+\n\tmzYMsZith9KJycKEq05aDA8vdfk1xXyA0XX+9KvHFHdnMOB5+Zc8rYJmutCOBnJT9IlS\n\t/VgV9lKXAy13cgU0WI6PV0CUpFLIn6KwAGjuSejXaOV5L22lkfjfrCneEXSuUscV2ufd\n\tsBh9U9DMrsIXBOcu5SscEcGCiFkOuM+J7QXDsEuDE4H1MuLbQgR36WyoG6nkNVqQW2/r\n\t1GNQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=8fFcBaPZKjQQPsKQQeFeSAG72mshjjR9mGZfTCJM/8s=;\n\tb=VOORtOzrS1a7EpuDuKhlWKyHBSa5yy8nSrBD6ixvqPpOeG0tN5DL2k3Ladk59Lgy2B\n\taz2XWpP009qpE+RrltYbtu5uVqyx+W+rCr37KDNHu8hMYMEnlamUcDrUIFtEs10kCScN\n\tyu+9hVgZw8RWua8VMNUefQhrHAdlBzfQNDLpkJ15KmDaYe1YV1h8ZyT+3+gvYlb+sAi+\n\tezar6udvolE95lj0KurlzuhQ7UOeuWPjsbDKDqtTpOHduoPOErDfeHBcHewzY8MbdVy9\n\tFL6h2kGDgTB+4wcgIvfxXGNG/v3hMTOgLai+iQYUL3nuPpOr9ejDlcWQO0BlKdcNyGFR\n\tJxcA==", "X-Gm-Message-State": "APjAAAXxwIoHBImPoYc/F9yoQKmD1DyQ0FvT2v/x19vRFRvMi92mimvv\n\tpp00zKYP9LcS1fH8jcZawTcAaI7UNQ4=", "X-Google-Smtp-Source": "APXvYqzzmXlnGDHTEFf1FgTbD4rzdbBYCP6kF5+B6b1sE8ax4tLh0x8gK6JzPpPyWwqDfVIX4Po2Ng==", "X-Received": "by 2002:a17:90a:9291:: with SMTP id\n\tn17mr26557795pjo.66.1561409087615; \n\tMon, 24 Jun 2019 13:44:47 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>", "Date": "Mon, 24 Jun 2019 13:44:31 -0700", "Message-Id": "<20190624204435.29452-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190624204435.29452-1-stephen@networkplumber.org>", "References": "<20190516180427.17270-1-stephen@networkplumber.org>\n\t<20190624204435.29452-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 4/8] net/ether: use bitops to speedup\n\tcomparison", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Using bit operations like or and xor is faster than a loop\non all architectures. Really just explicit unrolling.\n\nSimilar cast to uint16 unaligned is already done in\nother functions here.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n lib/librte_net/rte_ether.h | 17 +++++++----------\n 1 file changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h\nindex 8edc7e217b25..feb35a33c94b 100644\n--- a/lib/librte_net/rte_ether.h\n+++ b/lib/librte_net/rte_ether.h\n@@ -81,11 +81,10 @@ struct rte_ether_addr {\n static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1,\n \t\t\t\t const struct rte_ether_addr *ea2)\n {\n-\tint i;\n-\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; i++)\n-\t\tif (ea1->addr_bytes[i] != ea2->addr_bytes[i])\n-\t\t\treturn 0;\n-\treturn 1;\n+\tconst unaligned_uint16_t *w1 = (const uint16_t *)ea1;\n+\tconst unaligned_uint16_t *w2 = (const uint16_t *)ea2;\n+\n+\treturn ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0;\n }\n \n /**\n@@ -100,11 +99,9 @@ static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1,\n */\n static inline int rte_is_zero_ether_addr(const struct rte_ether_addr *ea)\n {\n-\tint i;\n-\tfor (i = 0; i < RTE_ETHER_ADDR_LEN; i++)\n-\t\tif (ea->addr_bytes[i] != 0x00)\n-\t\t\treturn 0;\n-\treturn 1;\n+\tconst unaligned_uint16_t *w = (const uint16_t *)ea;\n+\n+\treturn (w[0] | w[1] | w[2]) == 0;\n }\n \n /**\n", "prefixes": [ "v5", "4/8" ] }