Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55265/?format=api
{ "id": 55265, "url": "http://patches.dpdk.org/api/patches/55265/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190624164714.6560-10-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190624164714.6560-10-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190624164714.6560-10-stephen@networkplumber.org", "date": "2019-06-24T16:47:14", "name": "[v6,9/9] doc: update KNI documentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "db7430aa67be7b100a52c0ad2f95f384109177bc", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190624164714.6560-10-stephen@networkplumber.org/mbox/", "series": [ { "id": 5138, "url": "http://patches.dpdk.org/api/series/5138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5138", "date": "2019-06-24T16:47:05", "name": "kni: fixes and cleanups", "version": 6, "mbox": "http://patches.dpdk.org/series/5138/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55265/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55265/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EACA41BD72;\n\tMon, 24 Jun 2019 18:47:52 +0200 (CEST)", "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id DB0111BD29\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 18:47:32 +0200 (CEST)", "by mail-pf1-f193.google.com with SMTP id p184so7839455pfp.7\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 09:47:32 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tf7sm12814023pfd.43.2019.06.24.09.47.30\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 24 Jun 2019 09:47:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=0khlawSNIgDeYLk2xnYr3hkFbn+imFT3yJqOIe71Vj8=;\n\tb=fAAsQ5zPkkdY/rOG940YE7JrFsW4KVojZC6bahHpsa6qbX1kz1dAKGyydwSbvPGxiB\n\t0WH2ibqgSORym0yUe7caYm1ZRn6hwTxFLy5P5JM3dvtZwJBsvfsu1PfGELcIdR1xGXJ2\n\tYGCgqpCrTNbQpE0WtJErEGnvXJBOEbqJOuI2vR2xR1nqgErHD/lnJdmCbPdR7Xp16qJB\n\tJydrT68Am/X7Ph+pJ/ifY6ih+nsShXs+AltQy6XMbJiRREZQID5a1944rU7r49ew/Aau\n\tdD9ngRono0W4Aw1gslh4uRe+HFj7NYn2syR4JRf3BAwEjadH7mzXEFGJPxbykmB81uuJ\n\tAisw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=0khlawSNIgDeYLk2xnYr3hkFbn+imFT3yJqOIe71Vj8=;\n\tb=h1lI/2xTcpycqQQIaNwNW3nJlo01LIEoVQ/QP/rM5wJHpBIeXfLi+ETKiki6ksIu6F\n\tPinCHyOLlGFoO8y7RKjRX0AX3GJsElid9cHpRT7AURiasmj4Eey9kes4qiYA64R9CYhd\n\tNuukZLhUuQs7MdSNwWHuEtll2jGb/06qDbvw4lnELBsv28YKfzbcHRYeh8potpbJE0YT\n\t2RpQYLq+fhDkg7e/2MYONFNSkeOQpYpMKsBprwIjQYAxBm5VAIgdeYIWaIL7Hg/Zq+53\n\trCtgZ6me9wRaaB+Uk7dtX0rgzJhSfelxUtD+SUXUtrTHn8wPBeR7UL9wrw6qK8G7pVp8\n\t4vVQ==", "X-Gm-Message-State": "APjAAAUgWO1iyDsE/fry+KYxPZcZkX0Mb0vNP0tlUqWgp3MySkzMl7tn\n\tSMXwOw7i4NvoSJTzZF1DW0GqTk55zWA=", "X-Google-Smtp-Source": "APXvYqz2Md4OIYioWZYrYFg0IsY3nmydTaOb4yoFt+DQrTCJsgW9nIzL2zvUl3OUxzspweXtjy9YRw==", "X-Received": "by 2002:a17:90a:778c:: with SMTP id\n\tv12mr24526774pjk.141.1561394851706; \n\tMon, 24 Jun 2019 09:47:31 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 24 Jun 2019 09:47:14 -0700", "Message-Id": "<20190624164714.6560-10-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190624164714.6560-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190624164714.6560-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 9/9] doc: update KNI documentation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Update KNI documentation to reflect current ethtool support.\n\nReplace references to out dated tools (ifconfig) with\nmodern iproute2. Tshark is a better replacement for tcpdump.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n .../prog_guide/kernel_nic_interface.rst | 9 +++----\n .../sample_app_ug/kernel_nic_interface.rst | 24 ++++++++++++-------\n 2 files changed, 20 insertions(+), 13 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst b/doc/guides/prog_guide/kernel_nic_interface.rst\nindex daf87f4a8edf..5afd05c0a745 100644\n--- a/doc/guides/prog_guide/kernel_nic_interface.rst\n+++ b/doc/guides/prog_guide/kernel_nic_interface.rst\n@@ -290,7 +290,8 @@ It then puts the mbuf back in the cache.\n Ethtool\n -------\n \n-Ethtool is a Linux-specific tool with corresponding support in the kernel\n-where each net device must register its own callbacks for the supported operations.\n-The current implementation uses the igb/ixgbe modified Linux drivers for ethtool support.\n-Ethtool is not supported in i40e and VMs (VF or EM devices).\n+Ethtool is a Linux-specific tool with corresponding support in the kernel.\n+The current version of kni provides minimal ethtool functionality\n+including querying version and link state. It does not support link\n+control, statistics, or dumping device registers.\n+\ndiff --git a/doc/guides/sample_app_ug/kernel_nic_interface.rst b/doc/guides/sample_app_ug/kernel_nic_interface.rst\nindex a7e549d5213a..aac4ebd8d4ff 100644\n--- a/doc/guides/sample_app_ug/kernel_nic_interface.rst\n+++ b/doc/guides/sample_app_ug/kernel_nic_interface.rst\n@@ -21,14 +21,14 @@ The FIFO queues contain pointers to data packets in the DPDK. This:\n \n * Provides a faster mechanism to interface with the kernel net stack and eliminates system calls\n \n-* Facilitates the DPDK using standard Linux* userspace net tools (tcpdump, ftp, and so on)\n+* Facilitates the DPDK using standard Linux* userspace net tools (tshark, rsync, and so on)\n \n * Eliminate the copy_to_user and copy_from_user operations on packets.\n \n The Kernel NIC Interface sample application is a simple example that demonstrates the use\n of the DPDK to create a path for packets to go through the Linux* kernel.\n This is done by creating one or more kernel net devices for each of the DPDK ports.\n-The application allows the use of standard Linux tools (ethtool, ifconfig, tcpdump) with the DPDK ports and\n+The application allows the use of standard Linux tools (ethtool, iproute, tshark) with the DPDK ports and\n also the exchange of packets between the DPDK application and the Linux* kernel.\n \n The Kernel NIC Interface sample application requires that the\n@@ -220,13 +220,13 @@ Enable KNI interface and assign an IP address:\n \n .. code-block:: console\n \n- # ifconfig vEth0_0 192.168.0.1\n+ # ip addr add dev vEth0_0 192.168.0.1\n \n Show KNI interface configuration and statistics:\n \n .. code-block:: console\n \n- # ifconfig vEth0_0\n+ # ip -s -d addr show vEth0_0\n \n The user can also check and reset the packet statistics inside the ``kni``\n application by sending the app the USR1 and USR2 signals:\n@@ -234,16 +234,16 @@ application by sending the app the USR1 and USR2 signals:\n .. code-block:: console\n \n # Print statistics\n- # kill -SIGUSR1 `pidof kni`\n+ # pkill -USR1 kni\n \n # Zero statistics\n- # kill -SIGUSR2 `pidof kni`\n+ # pkill -USR2 kni\n \n Dump network traffic:\n \n .. code-block:: console\n \n- # tcpdump -i vEth0_0\n+ # tshark -n -i vEth0_0\n \n The normal Linux commands can also be used to change the MAC address and\n MTU size used by the physical NIC which corresponds to the KNI interface.\n@@ -254,13 +254,19 @@ Change the MAC address:\n \n .. code-block:: console\n \n- # ifconfig vEth0_0 hw ether 0C:01:02:03:04:08\n+ # ip link set dev vEth0_0 lladdr 0C:01:02:03:04:08\n \n Change the MTU size:\n \n .. code-block:: console\n \n- # ifconfig vEth0_0 mtu 1450\n+ # ip link set dev vEth0_0 mtu 1450\n+\n+Limited ethtool support:\n+\n+.. code-block:: console\n+\n+ # ethtool -i vEth0_0\n \n When the ``kni`` application is closed, all the KNI interfaces are deleted\n from the Linux kernel.\n", "prefixes": [ "v6", "9/9" ] }