Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55261/?format=api
{ "id": 55261, "url": "http://patches.dpdk.org/api/patches/55261/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190624164714.6560-6-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190624164714.6560-6-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190624164714.6560-6-stephen@networkplumber.org", "date": "2019-06-24T16:47:10", "name": "[v6,5/9] kni: use proper type for kni fifo's", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ea3b0b24974d20d15fdf8bcacf32c23a1df694bb", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190624164714.6560-6-stephen@networkplumber.org/mbox/", "series": [ { "id": 5138, "url": "http://patches.dpdk.org/api/series/5138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5138", "date": "2019-06-24T16:47:05", "name": "kni: fixes and cleanups", "version": 6, "mbox": "http://patches.dpdk.org/series/5138/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55261/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55261/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 212721BD0E;\n\tMon, 24 Jun 2019 18:47:40 +0200 (CEST)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id CBA4C1BCEA\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 18:47:27 +0200 (CEST)", "by mail-pg1-f194.google.com with SMTP id y72so7413922pgd.8\n\tfor <dev@dpdk.org>; Mon, 24 Jun 2019 09:47:27 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tf7sm12814023pfd.43.2019.06.24.09.47.25\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 24 Jun 2019 09:47:25 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=;\n\tb=VlybDhCa2IZgaQo+N5xEysg/i4y/7+by64zpSYiLmMmbFBFz2CTwyRvbPktQUUc5Rt\n\t81iEG601qwLReKAN2fVYVB1K4vqXb1TykQssVghSZiXDvrqPkWTBZD4uC94Gds9ojbPh\n\tpwlrplieAd+/P9qiJNSALsvj8+OHU+jXw/Him8DmGQeZ2VUIRJHytUt5lpeABtBfmH5F\n\tKNB6ysWgoypMEo83geNlr8KEQOBIYh3Mz/VOntY2OtYOimtv0HzF0hX/5wgOKFsocceg\n\tmtVYHEk2gcm4etLMR4+WLcBewDW940zRxncBTmBWiLtKjCGX3HecetyiXvc1qd/JW55+\n\tivyA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=MaX/9U1VKQDRlwJP1eh9LKqP+HAkhTNljy8r1/SknpU=;\n\tb=R8kii7ZKvQDX2W/Ho9Y8Fgx8ufOToL44ckNWDts9jp6i19MmSjdmiwgY7jtOjWUSeF\n\tBVktZGVnVU/ychAfPA0hgq0Vp470GED7W5Dd4wiL1665EVxaVbourkRnumE3f8qg867L\n\tvd5ktfsNwoEu+PhssI9zv32hNyFI/HOLW1/bPhJSyf0JMD6hRj6Vf+I5p7YyVWesZu2Y\n\tbBp1s1Q6rE5e4a6N2JGO8aUn09rV9cWD8P4SWkR8SYWKtAB1KHdOJcTVeYrsFAQIkUcv\n\thn8L+Z4dSJzxLOwQWWV+N6WFMzTogV0zUoYNWBmriV4KYm2PlggYkwgGomY4D/6peZgB\n\tOeNQ==", "X-Gm-Message-State": "APjAAAVbTmxKuGcfjzlWpjgcLXFV0jaUXb5R+KI6RS2CyJtfLkw6TB9N\n\trw4lOiTf7yySYl7y+RrHsgbR4/1gZXU=", "X-Google-Smtp-Source": "APXvYqxl3D4D5pGrNfkpXYZk1Aj+DBEfGD8Tk/n39gOG1pJGBVxPUdtNiXzaSVOhcvEzJvMiXM73ig==", "X-Received": "by 2002:a63:231c:: with SMTP id\n\tj28mr33375206pgj.430.1561394846638; \n\tMon, 24 Jun 2019 09:47:26 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 24 Jun 2019 09:47:10 -0700", "Message-Id": "<20190624164714.6560-6-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190624164714.6560-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190624164714.6560-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 5/9] kni: use proper type for kni fifo's", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Using void * instead of proper type is unsafe practice.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex f3e6c3ca4efa..ceba5f73c1d9 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -51,22 +51,22 @@ struct kni_dev {\n \tstruct net_device *net_dev;\n \n \t/* queue for packets to be sent out */\n-\tvoid *tx_q;\n+\tstruct rte_kni_fifo *tx_q;\n \n \t/* queue for the packets received */\n-\tvoid *rx_q;\n+\tstruct rte_kni_fifo *rx_q;\n \n \t/* queue for the allocated mbufs those can be used to save sk buffs */\n-\tvoid *alloc_q;\n+\tstruct rte_kni_fifo *alloc_q;\n \n \t/* free queue for the mbufs to be freed */\n-\tvoid *free_q;\n+\tstruct rte_kni_fifo *free_q;\n \n \t/* request queue */\n-\tvoid *req_q;\n+\tstruct rte_kni_fifo *req_q;\n \n \t/* response queue */\n-\tvoid *resp_q;\n+\tstruct rte_kni_fifo *resp_q;\n \n \tvoid *sync_kva;\n \tvoid *sync_va;\n", "prefixes": [ "v6", "5/9" ] }