Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55145/?format=api
{ "id": 55145, "url": "http://patches.dpdk.org/api/patches/55145/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190620220924.32079-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190620220924.32079-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190620220924.32079-3-stephen@networkplumber.org", "date": "2019-06-20T22:09:24", "name": "[2/2] net/netvsc: fix xstats for VF device", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "84d10181426127e28cb9bcc70179966d81041080", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190620220924.32079-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 5105, "url": "http://patches.dpdk.org/api/series/5105/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5105", "date": "2019-06-20T22:09:22", "name": "net/netvsc: xstat fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/5105/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55145/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4663E1D4B9;\n\tFri, 21 Jun 2019 00:09:39 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 61CC51D4A4\n\tfor <dev@dpdk.org>; Fri, 21 Jun 2019 00:09:34 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id r1so2427271pfq.12\n\tfor <dev@dpdk.org>; Thu, 20 Jun 2019 15:09:34 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ty12sm422226pfn.187.2019.06.20.15.09.31\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tThu, 20 Jun 2019 15:09:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=31KiY49ADPgIgutfL4dOVmEFHnvBXuq6MNhrX3o5lc0=;\n\tb=qM/FOJlgkwIlv3Vr4F7KRXyJO5kxAcllYQjqMnlvGSlZJ6eUOPY1sRyNySbXPx+BSe\n\tMUvvyMOJ3NL3rJspmm3EYqLgXY+FNg2r8nYZSuduA1Kxx2txtuYbAiKtA6T2gh9pJEZW\n\t88SyStmok3NoqDmTsahHvy/Z1OhrjXamDkxuZSQ5fUTfyGz55/6n0BMoKXhdVkePDDdV\n\teHSt6x9xADCi5ndtLfzBj6U3NHAM9YkWoiQ1xwcqAq62NZyUinZHWBQWFJborMYoWBJw\n\tRIulzL2pHQ5I1s34Fb/DQezh+AoiH2e9WRDttsd7KyzfK45UyPiUlwswOyc++KSTYiLj\n\tTSAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=31KiY49ADPgIgutfL4dOVmEFHnvBXuq6MNhrX3o5lc0=;\n\tb=eQKQk/3/E8tFUvsx0DlNbU2Ht2AYbG/X48zgm/mBiAA9GGIZ0AMi/SjQzJrGqyF9tI\n\tWP3VfyJGL1EaHB00pOimPvHqSvychtC/eLy4KX8vxFusRFuuO/zvRto5e0MOjsrpI0sN\n\tMFHp98yCsaXChDkXCBHxjAprnoUfDSOP96DwB8QCANRJKLAckvwCc4Epld5fQyL03t64\n\tjDC7tDbj1hCEFGF3NbWZj/lUR50LBaKyFZBAjER0I9boek9SBWpc0X2nHdZxgXHNi/7J\n\tVSoMFSmN7R8SrzrX2o10Iw5y9KA9O5wF3pjR461rj7huY8WpG3568OCnQb9dAsBDlkJu\n\tIOag==", "X-Gm-Message-State": "APjAAAU5CWuIFRUu/+bcyjmsXVdIEZaomy41VYgVzk51JeM1r/cHDngW\n\tbjRSFczT0eoYXZtq2AvjBWN7rZ5aytk=", "X-Google-Smtp-Source": "APXvYqyMG9Mi3OEyFk7dzuTk2ICXYkj/PX8CmJyu5ity5ie5eLAqkd22fv62hW2UKE+/MV1c1LoJZQ==", "X-Received": "by 2002:a63:231a:: with SMTP id\n\tj26mr14473025pgj.389.1561068573307; \n\tThu, 20 Jun 2019 15:09:33 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 20 Jun 2019 15:09:24 -0700", "Message-Id": "<20190620220924.32079-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190620220924.32079-1-stephen@networkplumber.org>", "References": "<20190620220924.32079-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/netvsc: fix xstats for VF device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The id values for VF stats were not being offset correctly.\nAnd getting xstats for VF device only worked if VF device supported\nit; it did not support the generic stats.\n\nFixes: dc7680e8597c (\"net/netvsc: support integrated VF\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/netvsc/hn_ethdev.c | 2 +-\n drivers/net/netvsc/hn_var.h | 2 +-\n drivers/net/netvsc/hn_vf.c | 26 ++++++++++++++++++--------\n 3 files changed, 20 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex d37db7c6a232..2b1b2ba3b845 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -598,7 +598,7 @@ hn_dev_xstats_get(struct rte_eth_dev *dev,\n \t\t}\n \t}\n \n-\tret = hn_vf_xstats_get(dev, xstats + count, n - count);\n+\tret = hn_vf_xstats_get(dev, xstats, count, n);\n \tif (ret < 0)\n \t\treturn ret;\n \ndiff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h\nindex bf94d90a7635..be657af0982a 100644\n--- a/drivers/net/netvsc/hn_var.h\n+++ b/drivers/net/netvsc/hn_var.h\n@@ -237,5 +237,5 @@ int\thn_vf_xstats_get_names(struct rte_eth_dev *dev,\n \t\t\t unsigned int size);\n int\thn_vf_xstats_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_xstat *xstats,\n-\t\t\t unsigned int n);\n+\t\t\t unsigned int offset, unsigned int n);\n void\thn_vf_xstats_reset(struct rte_eth_dev *dev);\ndiff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c\nindex 27ac87e7e975..3a833d447ac1 100644\n--- a/drivers/net/netvsc/hn_vf.c\n+++ b/drivers/net/netvsc/hn_vf.c\n@@ -506,17 +506,19 @@ int hn_vf_xstats_get_names(struct rte_eth_dev *dev,\n \tstruct hn_data *hv = dev->data->dev_private;\n \tstruct rte_eth_dev *vf_dev;\n \tint i, count = 0;\n-\tchar tmp[RTE_ETH_XSTATS_NAME_SIZE];\n \n \trte_spinlock_lock(&hv->vf_lock);\n \tvf_dev = hn_get_vf_dev(hv);\n-\tif (vf_dev && vf_dev->dev_ops->xstats_get_names)\n-\t\tcount = vf_dev->dev_ops->xstats_get_names(vf_dev, names, n);\n+\tif (vf_dev)\n+\t\tcount = rte_eth_xstats_get_names(vf_dev->data->port_id,\n+\t\t\t\t\t\t names, n);\n \trte_spinlock_unlock(&hv->vf_lock);\n \n \t/* add vf_ prefix to xstat names */\n \tif (names) {\n \t\tfor (i = 0; i < count; i++) {\n+\t\t\tchar tmp[RTE_ETH_XSTATS_NAME_SIZE];\n+\n \t\t\tsnprintf(tmp, sizeof(tmp), \"vf_%s\", names[i].name);\n \t\t\tstrlcpy(names[i].name, tmp, sizeof(names[i].name));\n \t\t}\n@@ -527,18 +529,26 @@ int hn_vf_xstats_get_names(struct rte_eth_dev *dev,\n \n int hn_vf_xstats_get(struct rte_eth_dev *dev,\n \t\t struct rte_eth_xstat *xstats,\n+\t\t unsigned int offset,\n \t\t unsigned int n)\n {\n \tstruct hn_data *hv = dev->data->dev_private;\n \tstruct rte_eth_dev *vf_dev;\n-\tint count = 0;\n+\tint i, count = 0;\n \n \trte_spinlock_lock(&hv->vf_lock);\n \tvf_dev = hn_get_vf_dev(hv);\n-\tif (vf_dev && vf_dev->dev_ops->xstats_get)\n-\t\tcount = vf_dev->dev_ops->xstats_get(vf_dev, xstats, n);\n+\tif (vf_dev)\n+\t\tcount = rte_eth_xstats_get(vf_dev->data->port_id,\n+\t\t\t\t\t xstats + offset, n - offset);\n \trte_spinlock_unlock(&hv->vf_lock);\n \n+\t/* Offset id's for VF stats */\n+\tif (count > 0) {\n+\t\tfor (i = 0; i < count; i++)\n+\t\t\txstats[i + offset].id += offset;\n+\t}\n+\n \treturn count;\n }\n \n@@ -549,7 +559,7 @@ void hn_vf_xstats_reset(struct rte_eth_dev *dev)\n \n \trte_spinlock_lock(&hv->vf_lock);\n \tvf_dev = hn_get_vf_dev(hv);\n-\tif (vf_dev && vf_dev->dev_ops->xstats_reset)\n-\t\tvf_dev->dev_ops->xstats_reset(vf_dev);\n+\tif (vf_dev)\n+\t\trte_eth_xstats_reset(vf_dev->data->port_id);\n \trte_spinlock_unlock(&hv->vf_lock);\n }\n", "prefixes": [ "2/2" ] }