Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55137/?format=api
{ "id": 55137, "url": "http://patches.dpdk.org/api/patches/55137/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190620192048.13814-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190620192048.13814-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190620192048.13814-7-stephen@networkplumber.org", "date": "2019-06-20T19:20:45", "name": "[v5,6/9] kni: return -EFAULT if copy_from_user fails", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c6cf09b1d314385dad9c045b30da4db2e7d65ce8", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190620192048.13814-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 5102, "url": "http://patches.dpdk.org/api/series/5102/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5102", "date": "2019-06-20T19:20:39", "name": "kni: fixes and cleanups", "version": 5, "mbox": "http://patches.dpdk.org/series/5102/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55137/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55137/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C64921D492;\n\tThu, 20 Jun 2019 21:21:18 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 19F511D467\n\tfor <dev@dpdk.org>; Thu, 20 Jun 2019 21:21:05 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id f25so2066824pgv.10\n\tfor <dev@dpdk.org>; Thu, 20 Jun 2019 12:21:05 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tj11sm255703pfa.2.2019.06.20.12.21.02\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tThu, 20 Jun 2019 12:21:03 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=9ZfM4adtNVrF7wT1Mjc0z707Ax+G9osFiWtI1ekyG9E=;\n\tb=BsHKJBwl9VUEkFWXS5327E2HSNc3JDo08kdmSflhKcNR/vk+do8O7NwoVxObllrIr4\n\tdR/3V75lo7xfJqGaizCIJPF2Iptm+TkpcMN0TZCHlRVJF+IgkigxogvXH5Z0eFODvM6Q\n\tQfX3uZaShjt69gEFYHOzWOJOaQK5gSzl6PtLDje1/KsxqFF1azO8z0c2Wmtaf9H+RwDe\n\tN383YNFsyTxoWNVIaTdhPwRJR9y9vQmN2gaB7bqDBgTdlA+j6/obiNRd0PNdSs0Kab1n\n\tSxs2w/rNYf7V4Ml6QNK9UNvjdXvgU0vQvkeasWw+sxU0ARGSaQP5WrI0YU9cHpqE0LLT\n\trXHg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=9ZfM4adtNVrF7wT1Mjc0z707Ax+G9osFiWtI1ekyG9E=;\n\tb=cGycGbewS2Slb2Vqrwc1IiFIQXKZdf9cZl52whJXj1pLbECinTMa80edl6xSMjyCl3\n\t04rcik6QySxST/uTqMTa5dlS2nLSmu+Zf4tSlp8eiMlsVdFDdueoTNu3ImLQC3s5fu2A\n\tJEjQzLI+QFT9qKPrWkOknpAKR3k5SNTsFg+MVmUd41LfiLayZQOsNvPjAa131FeobTfV\n\twXxUjR9S4uagFTlK02PQ96ICRDyGQlrLEW7niDBDR/qB5kcZcLcC9gr1aE8nScoSvnG6\n\tP9JTuIugopNs5UsKgQX/mXurF29fHylagtdMcZbrsZ8D2HGxi00biZXA0aB7wkks1Bq5\n\t6loQ==", "X-Gm-Message-State": "APjAAAUbDrHoCkEGuFE4xZ5GL2I5daxfmxlrDirk4IwTeLun6aT2m2hw\n\t0zaN6KJAeZuaF4C99axNSaS2rrhqYOE=", "X-Google-Smtp-Source": "APXvYqweTTjSqy2DX7zzUUPrwsAFkuqExuDAONUbp7+6r5u+mlZamQ8CpSVNd5N5pH2sUgwGYwVY0g==", "X-Received": "by 2002:a17:90a:9291:: with SMTP id\n\tn17mr1252663pjo.66.1561058464045; \n\tThu, 20 Jun 2019 12:21:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 20 Jun 2019 12:20:45 -0700", "Message-Id": "<20190620192048.13814-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190620192048.13814-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190620192048.13814-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 6/9] kni: return -EFAULT if copy_from_user\n\tfails", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The correct thing to return if user gives a bad data\nis to return -EFAULT. Logging is also discouraged because\nit could be used as a DoS attack.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_misc.c | 16 +++++-----------\n 1 file changed, 5 insertions(+), 11 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c\nindex b59cf24c2184..be45f823408f 100644\n--- a/kernel/linux/kni/kni_misc.c\n+++ b/kernel/linux/kni/kni_misc.c\n@@ -301,11 +301,8 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,\n \t\treturn -EINVAL;\n \n \t/* Copy kni info from user space */\n-\tret = copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info));\n-\tif (ret) {\n-\t\tpr_err(\"copy_from_user in kni_ioctl_create\");\n-\t\treturn -EIO;\n-\t}\n+\tif (copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info)))\n+\t\treturn -EFAULT;\n \n \t/* Check if name is zero-ended */\n \tif (strnlen(dev_info.name, sizeof(dev_info.name)) == sizeof(dev_info.name)) {\n@@ -427,15 +424,12 @@ kni_ioctl_release(struct net *net, uint32_t ioctl_num,\n \tif (_IOC_SIZE(ioctl_num) > sizeof(dev_info))\n \t\treturn -EINVAL;\n \n-\tret = copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info));\n-\tif (ret) {\n-\t\tpr_err(\"copy_from_user in kni_ioctl_release\");\n-\t\treturn -EIO;\n-\t}\n+\tif (copy_from_user(&dev_info, (void *)ioctl_param, sizeof(dev_info)))\n+\t\treturn -EFAULT;\n \n \t/* Release the network device according to its name */\n \tif (strlen(dev_info.name) == 0)\n-\t\treturn ret;\n+\t\treturn -EINVAL;\n \n \tdown_write(&knet->kni_list_lock);\n \tlist_for_each_entry_safe(dev, n, &knet->kni_list_head, list) {\n", "prefixes": [ "v5", "6/9" ] }