Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/55100/?format=api
http://patches.dpdk.org/api/patches/55100/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190619185958.27306-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190619185958.27306-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190619185958.27306-5-stephen@networkplumber.org", "date": "2019-06-19T18:59:54", "name": "[v4,4/8] kni: drop unused fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d37da3341adf7a1fb44c4ee0e3dabb6d169aabf3", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190619185958.27306-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 5091, "url": "http://patches.dpdk.org/api/series/5091/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=5091", "date": "2019-06-19T18:59:50", "name": "kni: fixes and cleanups", "version": 4, "mbox": "http://patches.dpdk.org/series/5091/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/55100/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/55100/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7E9611D177;\n\tWed, 19 Jun 2019 21:00:15 +0200 (CEST)", "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D8E1C1D12D\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 21:00:07 +0200 (CEST)", "by mail-pf1-f196.google.com with SMTP id p184so138673pfp.7\n\tfor <dev@dpdk.org>; Wed, 19 Jun 2019 12:00:07 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tg8sm18613397pfi.8.2019.06.19.12.00.04\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tWed, 19 Jun 2019 12:00:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=eVpCCGqv4anpgjgB0iS05xOJSNV5B1c7nQVpCcdAfXk=;\n\tb=GImtclffayvUf//LAax4etCiT9hF5txTmRf9RIZJC+/XfiGXjkKtPtEMec+4EqYTKL\n\tL/igjL5ShHb6tgoBqdf0f4z/vbjkUJuXEK+Th2RdXBTjiCG3HtLazX3UKLNMZcokZwMR\n\tLji3Y6Wu6ktjFus/0vjSukyvUnU2OrEHSNtDOTBzju9sYmL8rhQuHgNp0Pr9CHca7DsG\n\t7uCRnAjRoqcXVbuJejJw6Ru4LZ5JsnF0F0NZOY3UUUyqckYsAhEPsse5QWGFjzPY7LXP\n\t8J4myOQoHYswQDZmm7p9cFBkHi6PCjbklBlgBslw4b/r3d6o4Ce1tbDA3mgMhQUDHQCp\n\t3t/A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=eVpCCGqv4anpgjgB0iS05xOJSNV5B1c7nQVpCcdAfXk=;\n\tb=mYosd/ybRq6HKjjh20rEWutBOEeYxrV3pp1a6seffmepu8BAFZeEXOiwjyXpaUn+ej\n\t7rEvXWgy8xfPn343bNi4O4zoEOSkzWIgxkIbzXEIlotTrohOdjpygwWfYNCl5cNpLC9y\n\tIFHCWJWFGBX55HvS+l0dmylW0XCXT+PSS3n8tHYkohGj7ptbj+5T5xAFbzfViuGcxEz9\n\tWWZKCdsN0Eq5xzGeLeUH5A+87TrpUcy3pU1EPPgUTidP/trGmk7kJMPJjL6bXE8jukEW\n\tnS1UZa2oiN4McIpCzS0hBizL4CL1h8/BtZovAG35KBppiVdd6ou3Lv34q5f1tScgoOQg\n\tuefQ==", "X-Gm-Message-State": "APjAAAU83PnVGnmvaTQ59JC1GFHia4F3rWRC85swAKYReUj2ZyfKnX9I\n\tORhpImsK4r1Y1Fgmg22ICSvSBpk5nhw=", "X-Google-Smtp-Source": "APXvYqw2ohikQCjwU/VrKi3qpRwUMO3jRuA02UD6UuG/C1MjYuLFYKPvttoO/7z3esfjm2asfsRkqw==", "X-Received": "by 2002:a63:1b46:: with SMTP id b6mr1493689pgm.183.1560970806455;\n\tWed, 19 Jun 2019 12:00:06 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <sthemmin@microsoft.com>,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 19 Jun 2019 11:59:54 -0700", "Message-Id": "<20190619185958.27306-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190619185958.27306-1-stephen@networkplumber.org>", "References": "<20190610175155.21374-1-stephen@networkplumber.org>\n\t<20190619185958.27306-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 4/8] kni: drop unused fields", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nThe kni net structure only exists in driver no API/ABI.\nSeveral fields were either totally unused or set and never used.\n\nThe fields in dev_info do need to stay in the ABI but\nkernel can ignore them.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n\nkni: drop unused status element\n\nYet another ethtool leftover.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n kernel/linux/kni/kni_dev.h | 5 -----\n kernel/linux/kni/kni_misc.c | 1 -\n 2 files changed, 6 deletions(-)", "diff": "diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h\nindex 21e4b0d92368..f3e6c3ca4efa 100644\n--- a/kernel/linux/kni/kni_dev.h\n+++ b/kernel/linux/kni/kni_dev.h\n@@ -39,8 +39,6 @@ struct kni_dev {\n \t/* kni list */\n \tstruct list_head list;\n \n-\tint status;\n-\tuint16_t group_id; /* Group ID of a group of KNI devices */\n \tuint32_t core_id; /* Core ID to bind */\n \tchar name[RTE_KNI_NAMESIZE]; /* Network device name */\n \tstruct task_struct *pthread;\n@@ -79,9 +77,6 @@ struct kni_dev {\n \t/* mbuf size */\n \tuint32_t mbuf_size;\n \n-\t/* synchro for request processing */\n-\tunsigned long synchro;\n-\n \t/* buffers */\n \tvoid *pa[MBUF_BURST_SZ];\n \tvoid *va[MBUF_BURST_SZ];\ndiff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c\nindex 1fc5eeb9c8ca..b59cf24c2184 100644\n--- a/kernel/linux/kni/kni_misc.c\n+++ b/kernel/linux/kni/kni_misc.c\n@@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num,\n \tkni = netdev_priv(net_dev);\n \n \tkni->net_dev = net_dev;\n-\tkni->group_id = dev_info.group_id;\n \tkni->core_id = dev_info.core_id;\n \tstrncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);\n \n", "prefixes": [ "v4", "4/8" ] }{ "id": 55100, "url": "